From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f172.google.com (mail-qk1-f172.google.com [209.85.222.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF8BB3A254B for ; Tue, 19 May 2026 23:48:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779234500; cv=none; b=SHnoUNg5CAP2XFplev7x6P9h2qVzExUWsbn48mnfoQL5TGGRurq9IWm6UjNu6HcrfpctSz5VPFniTFI3HvZfVapOhjSytbXGKoFl4qeVGlYnP971s9cXYb37EmCuBRYNw6Zc8WoDG3S96UO68dYenP79iZp90ecsYwFCX52/LEc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779234500; c=relaxed/simple; bh=nK0DU3MeJuxGLlbEPZuVHXpO7Oe8fCVlyNAcJlYiKqM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ulNuo3XAp7dVy96sACn+VmDkUVC5Xk16F54Vt4l8aBIwgTfiTCHTy+jNGrSowJzEgjZJjL2gewWEBznArDO30s2JCquhX4cUMTwNDbympFPyCWHgMnw8fdeqrDL3Tk2CzZtQ6SThyCV96WTW7WTKT6J8hDG2ElZGdcuMZPKiZJg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qlcL8UDR; arc=none smtp.client-ip=209.85.222.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qlcL8UDR" Received: by mail-qk1-f172.google.com with SMTP id af79cd13be357-91066394ef8so339908885a.1 for ; Tue, 19 May 2026 16:48:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779234498; x=1779839298; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=FwP0HqBvQS3H4GOf9mcFliGMej6PKLk/wYq89RJjKaw=; b=qlcL8UDRa0+iwt0ztq+lFd8JfHRh5E0T7tJ/8/MihRJjL3R0nlAz7VpiQ4lJUzhnNB MBCUC2f126TSfrBUMZtfJlFT34/FfhdDYRyL7Yn6EvC5aY1Y5aF5LvZR16x6m5eNbZQG Llc1RyRLbWkN8V2hjXGetyZ2VlIkKbWjaklOerg/wYEqBDxwDDOGon8yGfgBCzKWOzJN h2Fe66zXK0N3PFugg5VLPyjP5Wa4NZAerMlRJ3oRD1lnSb2A+BOSFW50CQuVwYENciJG nWBZQ+LsITnm6V55xC2vb/Z3WH6CW96vzqX8uyRAIF7NrPkzs81sTpWMZ/pKE9PIpFLs h6Ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779234498; x=1779839298; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FwP0HqBvQS3H4GOf9mcFliGMej6PKLk/wYq89RJjKaw=; b=E3p8eXQ+3kpgjfq7pTUBUEOD/b8vv9howWcr3/91hvZ8u016UYlF4WELur3vbThRdz sfzmEj3Je8TritUIOiZviiCIL23ynqGblmZZJGLqN1dddTHyrtYm4cuIQvLSiNmZfA1P 7nViiT4vqEZC5LDW7t4N1fjyznDOVEBijQl3nS2h/ZXWzBPEBzw33mA6H0Qhr0q2DIJS mzupYYAYPRJpmmGRmVJZ0iOHqB3znNQSQM+qZ4EXrC7EzAZbX4ovkadfzcMkW7oQx8d2 QbibeWV2Fn2smq+IaxOFkNgc2NzU9vH0/5Lrr27dgCqABci5VvZZtn333QnHIi0WIqH4 J1vQ== X-Forwarded-Encrypted: i=1; AFNElJ/3wwxMCMEgfALFODz68da9IMT7A10VFKX7M14042Nd0DVnG6FpKAo9hOkyPlxvl7lytamzfJZr+5EadrE=@vger.kernel.org X-Gm-Message-State: AOJu0YwMKBGtCjQ/VtsK+JEJa0wUOJUYh1byjVEzXG+ZnIYE5b8usmln I7EbRLi6p8EZOs+OggqzhoWALlwxZkb+MI6ignrvu8J6K6HhyBnumYZ6 X-Gm-Gg: Acq92OGjE/qnwLToAVsmEkZGf4Ni58M5xX+aMgj+ghHlhnwn5F/baKfyJM0A+Zdycu7 /n2x+hYHHD2axLUAZD2e8iAhATq2I1uXOZ67Ko1r5ycVrYabN/jN+hy4vMRsj4UFWS+VmlFfTOv LWu1+M4yVf/nTInGi+xKtt8AYMWFteEXynrhkm0uwR5i1CnzQkAfQBat7WvLhfZcQmXn/LrGQP2 25ocpuN9H8WAS7jpKyh+puw7qd2hDKFE2kSZc6OdTdpznyw/zkjh552tVsSIjpVljoyCBktCTF7 qlkflfQ4zenZvrMvo/0c7obMcF5twJzAbj+ZppLDDQH8wzRosJlqE3aau+OcyyGgUeQdc4Qqjdw jqk0V5VHiEZ4qaFWq816LJUvtRmHPCDMMpRJceLMSBCZsctsqjFmdlArPgf0t5+qgZ+WN3CaEWK qsqxxYHlz5VPY9BBIPRzjuf5D5S4bUfazy77IujzAD/I77lQakEUrEU+Tdo7EuuR/V05WrGWNyM lY1PGVAB9Uix/YPewXME/4= X-Received: by 2002:a05:620a:a2dc:20b0:912:f763:f2b4 with SMTP id af79cd13be357-912f763f2ffmr1784376285a.11.1779234497830; Tue, 19 May 2026 16:48:17 -0700 (PDT) Received: from errol.ini.cmu.edu (pool-108-17-68-229.pitbpa.fios.verizon.net. [108.17.68.229]) by smtp.gmail.com with ESMTPSA id af79cd13be357-910ba36e68csm1993285485a.10.2026.05.19.16.48.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2026 16:48:17 -0700 (PDT) Date: Tue, 19 May 2026 19:48:15 -0400 From: "Gabriel L. Somlo" To: Andy Shevchenko Cc: Inochi Amaoto , Ulf Hansson , Karol Gugala , Mateusz Holenko , Joel Stanley , Kamil Rakoczy , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Yixun Lan , Longbin Li Subject: Re: [PATCH v4] mmc: litex_mmc: Set mandatory idle clocks before CMD0 Message-ID: References: <20260517015323.264179-1-inochiama@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett On Tue, May 19, 2026 at 10:52:10AM +0300, Andy Shevchenko wrote: > On Tue, May 19, 2026 at 5:51 AM Inochi Amaoto wrote: > > On Mon, May 18, 2026 at 06:45:26PM -0400, Gabriel L. Somlo wrote: > > ... > > > /* Update sd_clk */ > > - if (ios->clock != host->sd_clk) > > + if (ios->clock != host->sd_clk) { > > litex_mmc_setclk(host, ios->clock); > > + } > > FWIW, it's a stray change. and I'm still getting: [ 6.508084] mmc0: invalid bus width [ 6.510652] mmc0: error -22 whilst initialising SD card when booting with this change on 64-bit litex/rocket. Thanks, --Gabriel