From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C006238B130 for ; Mon, 1 Jun 2026 11:09:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780312157; cv=none; b=HXP8DfPGEWm35AVZFgtnVrKOi23eyekTfW8HQIN8u9cqc4zp8D/xSmd02h7hrj9kxloRNQbjKVYO56867Yl63wrNugBRLs6S+WuY8KVcDuAXwmSu+QSGzreXTCv0pmRVo2YX35Vu0B1qIoGJtuOuLBzxkGABBovT0vMW8/ahhLQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780312157; c=relaxed/simple; bh=QpnjQudDF58V1/FPsPcDplOMFvOALDVksNq/0qRLSds=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Q03bFXn3sC43fZEnI1y0AqBTtgd2pROkh/17tqt02OuLtD33m37MxqnRAnmFzoJPvZETVFqBD72s4cEazUU9top1SKjqkzXZJPgSt3Ic1ERsKSCMQvsqHV4QWAM+5TWAsVoKUuVazePHk7YqD3GPLjR2sZB/xlGOTfCDMP8JDT4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=X5YsJ8Xj; arc=none smtp.client-ip=209.85.208.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="X5YsJ8Xj" Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-68b73f1a8ebso6478072a12.1 for ; Mon, 01 Jun 2026 04:09:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780312154; x=1780916954; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=nvWyF+YOv3aLEiatSz6/qAj4smg4GeRiDdaf9XLf71g=; b=X5YsJ8XjvEqAff7VG9CFVQcQwOHENrto7PPqIFG+gGnOGT02mhkOsN2BVJl9eZoDVW eKDNvIZh2F/kj0VB1kYhAtsSTJqZ8vrfEsrDfrOJZWpbh5qRuJx1wSuZbco3lbVg1b0c 6J3KdGrpUM7uP0a90zoiKqq8pqRFV37cPP7Xt2W1XH/mh3d6RLB2roA5RDLab/gh8/aJ YlkyLzNUx84YccOU97mKCVKri7LxUz1uTjM2tnbajdmBBkHReXvreTURBIGyn8zEwhD8 MArHC77w4411elSSe6Jj7xo1QR0EAltoozRZEFFEvGfxbPq34n0OdT99+pQHkH/0W7xQ X3xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780312154; x=1780916954; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nvWyF+YOv3aLEiatSz6/qAj4smg4GeRiDdaf9XLf71g=; b=XRhaVuZEySrHrFuMpCG+g6qa5S9s2Fz4xYy6pRMfQlxg5p/f6nQH/UHNREXcWV4niE hBkjDOCREx2RHwgO75P2lePRamU1uOhIA16XoMhO2DQ68CLUY6SlSZoz5sVZJaJ7ZyYl 83t8fLgfiuR2/vLsp78aK0n73EQTYdmM6GLPxCqjrNbdHrgabhHXec97gXv/8vC8Sbk+ VQxoDQUBRUAbQggDp0LDRTc4ON0mfWWiwSpjtHO73x6VsO3Ff3IYh8rAWEe2MOIkcfbT TQFruFY26T5hi/Fn3K+YC7TjCi4H11Dj2E1P8P2wUlt16UqN+FDdR23bQNptnwCPiclg zlmg== X-Forwarded-Encrypted: i=1; AFNElJ89zT4NkJa3px9Oy6lQHY/l4l5hiX8frZBKGTjoRUSBXAGeoSAZrI7Nl57VcitlC/FCB94qvx10Uzh5O/U=@vger.kernel.org X-Gm-Message-State: AOJu0YybMSd8cH0tvvipFJAnASnnaahEr/lgML2py63iA5/V5OacSuJx KrXhrxQ7FmbEspJt+/39OqexWQEk+x57pQdzKlVc6dMV3HG35gUnLw8h X-Gm-Gg: Acq92OFWbxdQEh9v04Zp+Ok/7Z9zXvoEHrbo7WpJnwVuw97tvHRKnY4NAwEnTzJsDwC nASoGvS4aeRLxJnXxcYDzORJcpJJhJmhogSXcp4JTTVWFVcHiBa5oojnQCch/U3lOYynhGCQIrp cqWymsbJ6VgIPxpGydD6ZfoShWX/HddFP6jGqAB45DsqpANiuitHilwi41fGQ8CJrHTAepW/Jk9 n33vIbI7F4o4m0dm4ZvA/2xddbv5DcT7t2Kn22xCfNcI528XAWdVI/L7dyHsadrr0LUfGFVxNtq rDw5OgsF2R5mfToN/eUkn94i16bUQd1fpA44tlZFjCkyQrxBvr9gkElWdWrC2WVJgDEaHTpTWbH piP3Ln0v/P+sJhiUfBVk8PfPDds7qkcy18987qoJbcguPMZvBjFOkKCWe2q69+LXrBqvlk6u1sX mLimq2TSH62+ZX6UnA2KA7dL1MAGGjPYxB1g== X-Received: by 2002:a17:907:2843:b0:bec:64d4:3872 with SMTP id a640c23a62f3a-bec64e37d56mr245047366b.24.1780312153930; Mon, 01 Jun 2026 04:09:13 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bed94f9f82asm78921366b.20.2026.06.01.04.09.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jun 2026 04:09:13 -0700 (PDT) Date: Mon, 1 Jun 2026 14:09:09 +0300 From: Dan Carpenter To: Hungyu Lin Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: sm750fb: remove duplicate init_status structure Message-ID: References: <20260530222432.4303-1-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260530222432.4303-1-dennylin0707@gmail.com> On Sat, May 30, 2026 at 10:24:32PM +0000, Hungyu Lin wrote: > struct init_status duplicates struct initchip_param and is only used > within the sm750fb driver. > > Replace the remaining users of struct init_status with > struct initchip_param, remove the duplicate structure and eliminate > the unnecessary cast in hw_sm750_inithw(). > > No functional change intended. > > Signed-off-by: Hungyu Lin > --- Looks good to me. :) Reviewed-by: Dan Carpenter regards, dan carpenter