From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2613C39B947 for ; Mon, 1 Jun 2026 11:12:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780312344; cv=none; b=fqHXEBWtALlL2qAChz/ZHmM+vTeNmqaRkThatj00vLUkbhnUf5peoLtbbKHHCCoINGPJUuyjsfoINiE6KSxI6Y5T8MnKCCT0z9CV8oCTnPP7XmXYObaeTPxH5lP0EnRJpJV1sX5XV3GEiLyyHPJxJRy3OzyAlBoGHmhVDVUPDi8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780312344; c=relaxed/simple; bh=2kVjzgJhIizFfuEYAIfPUfgr7E0a2NPpngUcGQybYy0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=P2dHdTApeTD3uEXjJj53qRlWRaOQOGpOBUXUbebH6hoQ8TEWqU12c+6GV+MNrZhIhBl3TMrgMmO8CLczWjG9xImfGEDZdEsxGrEyg4r3ZpeGuCaArfMD5Lz8PDLLFPETQ+lH0RxaYYGPWuJtECpvA9OU6gilAq54QrULx8lNL3M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kKCwsKs/; arc=none smtp.client-ip=209.85.218.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kKCwsKs/" Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-beb8a08a6c8so236351366b.2 for ; Mon, 01 Jun 2026 04:12:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780312341; x=1780917141; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=3TgnaRVqfZTZla4JliJ2eTss2v12jmTs6tQc9EqQ2PA=; b=kKCwsKs/wXPUKCIW20EJhe3DNn3H9SOoqlf2rgcd+FWmlcZA32cCSrqZN2WLf0+GiU IiJhxHdd03Pbhod/W/jxTQfPnVL+dWJfE6i4YxKi5rMz4so5wKTQPNev1tE9tBJ9HjHs gIvk8SdbRvpO74lb90MLdutK2U5qIP0O53GuVIYUKU6979SzERXYWlODEZ+tp/TLqZ3T vOb91JKMWH+P64falXbxVyRBN/M9XCLuRkwm6F4he5ausgvb2tNzoYvtBJJ7+/nPiEyQ cvni8h1JbiUsUYUf3ob5SxZahmtyLdK/oYcxP/ZN0QqfscNCIWt/wIGohmPdkxJ+EQ6k ZJ+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780312341; x=1780917141; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3TgnaRVqfZTZla4JliJ2eTss2v12jmTs6tQc9EqQ2PA=; b=T4TlswXmIi+6AmEPxt6QyN7JW1zWaw011EWcXDRhtr3yZIxqDp18PACOelwXXXbeA9 R9nOtMorTqOwiA89+C3gS+mltAn1JMofMZ+d2Ddwv0MNHKA7V8VfFnS2HMEvyvEWPjcr gqc3rVN8bOGX+3DqMM8WhUV/1HNk092Gy++y3/XXj76D7rb7YKTWiZQL2jd6JmrAfDlj flJTNSrmYTXgbm6IAQ7zduivjVybV3MX/7Z1D/jT3/QY0V0ssvN+fYl3E7kbhTFdc8oi ov63rBqUdKrcJTuxblaHqQW26jg+by9q6/85cQvRirhHEHYJCg6kHYZdsrAs/OiRUOqE P1Xg== X-Forwarded-Encrypted: i=1; AFNElJ8q3g2gOj6fUXb9LCFk/W6FzXcRhPwm5N3q3NjHt1RWA8KzwNZKMxKbG8o6LDnZuXpYDF/7abvum1tb7JQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyTSJORA321lgj7WYLol+ktL3e/xpZKwlvbZCNfbISQ7SUZrvyh C5chcR+ysThRvWpTH8g7UXmOltSDLuzXfn9zvOTbaf3JDHOPB5Z3D6rz X-Gm-Gg: Acq92OFDyzlztCyPqnH4vpqBFWaUjERF9ZPApkLHCBh8ntscyd5qtYxMdxay+AE5nyW SFJl7VEg+EePOyOeR5Zqr+ACUA6L7d9Tqof70smRXAa4bMHgMK96GmifS3VFkbY+hu1bDLqISAL eFWMEWzdL8mAWxN7WCLp2v+wj7vPL55ZWwXZ2qv+wu4Rm+CzBM4g37aPreGEQspkG0CYHfglyWZ 3gGXpVhLZqvW0c5T7kvlkhi3s/yiZO2EXqBCOpHzWlOrSvO+zNrnOAhqWhFRKhSO3LPZ42ySTiJ G+MegN1ewGhnltYV5M6uAI+IRZemUS6QKn6REHBo8YFmM5aV6eeNyDBu7LkKDMi9Yu8c9VZB0s5 eF1BQP06jQbqkXzTwpKK6/PNPvjTmby+GwVWoO99BvD0i/pP6F4vQ4qg1M6mS8489j5Dfk5n8Yz RKOc5xzttqCrxhdZociIsK+1CzhzboUTQ0fg== X-Received: by 2002:a17:907:d9e:b0:bdd:45d9:8e15 with SMTP id a640c23a62f3a-beab3851adbmr641529366b.15.1780312341514; Mon, 01 Jun 2026 04:12:21 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bed25666221sm108317066b.29.2026.06.01.04.12.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jun 2026 04:12:20 -0700 (PDT) Date: Mon, 1 Jun 2026 14:12:17 +0300 From: Dan Carpenter To: Colton Spurgin Cc: gregkh@linuxfoundation.org, vaibhav.sr@gmail.com, mgreer@animalcreek.com, johan@kernel.org, elder@kernel.org, greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: greybus: audio_manager_module: add newlines to sysfs_emit calls Message-ID: References: <20260531005007.98382-1-colton@coltonspurgin.tech> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260531005007.98382-1-colton@coltonspurgin.tech> On Sat, May 30, 2026 at 07:50:07PM -0500, Colton Spurgin wrote: > sysfs_emit() format strings should include a terminating newline. > Add missing '\n' after 6 formatted strings in show functions. > > Signed-off-by: Colton Spurgin This checkpatch warning only applies to new code. For existing code you risk breaking userspace. regards, dan carpenter