From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF6B13ADBAF for ; Mon, 1 Jun 2026 18:29:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780338593; cv=none; b=jtu7cFmHbfDHm19UeaXMNAD9q1g7OCYkzdQNIx9wJVsX3gVTwANBuTdMMWuqb6RDtTPrsJBk1mMXqaQcNIf/DRyQX9rc8SQ1nuXAEhreWxDSBFEGkL6T/WriMQCRfJl5URwmYTDEU+GvKzVmGgc6I47x9rFU0UBpkq+wpSvTj70= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780338593; c=relaxed/simple; bh=nadSAkhHHCb9f3c6rk4eM63toF0mz1MXe3So0Pi8lgw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sFKBdeqlUmtFl7GRvjyGhfnwQ00PBWzbvRVLOluhvxuiGc3R2fdCfLf61HdTwIlSUTPiXYPMJ5q3L5QN8WUX2OjIByuV4l+Wl3LTkUh0MhrmCn+GEpi5f/eZMv4DgHMHHfjcbiELtfWj7Q7jVdQJeVsgAahPN1R3FkuulkSSOZ8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=rs3yuPe1; arc=none smtp.client-ip=209.85.208.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rs3yuPe1" Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-6870ad8072eso14021881a12.0 for ; Mon, 01 Jun 2026 11:29:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780338590; x=1780943390; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ZXHa4sPZRNZdOP8iF9391NRH2h78tUBVH5EmiEm/OR0=; b=rs3yuPe1RLA0EM2WQ32bbwPZ1+yRjH0zxpXyaN9UoXCHFxZSxWai3TuZLFQ8IrBdQe MXEyp9hJ8xFHn5dG9r7tOcthsPfKtctTWf465qBMAV+EJeoTMwEuBn9AF6B91KCeBFC6 Afmh9NF5NUdgAxkS4D/3jRqOvjKb2U8+AKvlreyM1tuMlWHATiiWRwmq6R9O1yLiDCuU gvpaSeX/gEWfz7pcBo3fITKGZ7TtOuVOihEML4Ivsm9o6FPeK4fs16A0zo/tEqkPO9qx z2BL+R2LMVAlIKghikcthbwd6t5366tKkWGqkY/wj0IdnJaLyI6tIcPqUz9+n6p56QhW xDxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780338590; x=1780943390; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZXHa4sPZRNZdOP8iF9391NRH2h78tUBVH5EmiEm/OR0=; b=UyP5f9p15Kx9Cymy6n/f3ztGk7JXf78uGUgQH7EVtcW4HIZgbHylORZn3XKnHiX2lA Z8x1bovA4oiRuq6CXgdZv0sxcqMrRxLgh2ExHcK0amSKq+vW18nX6tGvA1iT8suD6EMs AhcAgcbgGGA2VaGw9k5HY6lVcF5wotqESFZbIBFw/JDPwhyA3YBP+kikynzSrwrCFKjn gS/WkITikQVIOGQx7yKSMI8f5ZEYtAKipPotDOU/TS1gL7E2BRkkr5xSGDPOmc2L9/Q9 7PBv5vKFinNi1OqLg2O30u7bEL8s+zR16sMu/BBcGDMRHmmKpMCEDff7eV9Ox/0q63oU C8Pw== X-Forwarded-Encrypted: i=1; AFNElJ9PSMRWV532WabD+uxNbKg1roe5KuopIy9yyKghEzr+3otZ3sTJEJNdYj3e7V4WzAcQ3vNGA7YDJX4IFTk=@vger.kernel.org X-Gm-Message-State: AOJu0YxRQ/boYwVZixP8WanblZTvtjYR1JlCTxmPHFxI44YbAnMgyBGV s+WB6KGX7qWA59nSirIzMqpqCfvcTnqZHowFmpkEIdt7rGRwC9U4yJPo X-Gm-Gg: Acq92OHWTfYuSwDLA6XRxXCKyLB/zEbWdbwz7pYEtHgTmQiwCCKDwFcrQHKKcTVMA0j 3Ow52HhC45iQGUt4akImXr+ZuhNAdc/KqW+2J0iSlzX031qSoH9iPYQMezlhgF0a1WCEiWO4EMn UFK0xDaACcQxq8RopcYMo8Qg84tH3crvnZqnASblJoMl6IkyzXH7ADiB8FCr5bwnlJsqhDD1f6+ JT7VuW5bb0kscirAj62jqQ1iAJu2r851yHh/kT/zLXTbJl1vUX9HRZtUoM15xfjGxqvUsEftM6C gNhdXu18vOabyz1in5NEU2j18+loUbLfXxgXvNOQrTaFR99ILdaiyo13YMUhljlS5j+R3UFCDOZ B0JO1dzIE309dQHOUefjIlJA72wWQdtqjJo1ooh0fGMT4OITl5QzaOAKumv1Q1CDbv2EtP7I5/o cX6bU1RPQf7/FQYZveNqRqGnLcEGNLWA== X-Received: by 2002:a05:6402:3211:b0:68d:c45d:e64a with SMTP id 4fb4d7f45d1cf-68dd77193f1mr363586a12.4.1780338590013; Mon, 01 Jun 2026 11:29:50 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-68ceb8523f1sm2274331a12.21.2026.06.01.11.29.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jun 2026 11:29:49 -0700 (PDT) Date: Mon, 1 Jun 2026 21:29:46 +0300 From: Dan Carpenter To: Tomasz Unger Cc: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] staging: rtl8723bs: remove unnecessary parentheses Message-ID: References: <20260601-staging-fix-1-v3-1-331ec58683c0.ref@yahoo.pl> <20260601-staging-fix-1-v3-1-331ec58683c0@yahoo.pl> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260601-staging-fix-1-v3-1-331ec58683c0@yahoo.pl> On Mon, Jun 01, 2026 at 08:11:59PM +0200, Tomasz Unger wrote: > Remove unnecessary parentheses to clear checkpatch.pl warnings > > Example of fixed warnings: > CHECK: Unnecessary parentheses around dvobj->cam_cache[id] > CHECK: Unnecessary parentheses around 'val != 0xfe' This changed in v3. Btw, how were you even seeing this warning? I disabled it. Were you working against an old tree? > > Checkpatch warnings regarding line length above 100 columns on modified > lines were also fixed Please no, that's a separate fix. > > V2->V3: > Reverted condition parentheses changes per Dan Carpenter's review: > staging rules deliberately silence this checkpatch warning > > Changes in v3: > - Reverted condition parentheses changes per Dan Carpenter's review > - Link to v2: https://lore.kernel.org/all/20260531061022.573089-1-mavick4022@gmail.com/ > This stuff doesn't belong in the permanent git log. There are still some changes which should be removed from the commit. > Signed-off-by: Tomasz Unger > --- > Changes in v2: > - EDITME: describe what is new in this series revision. > - EDITME: use bulletpoints and terse descriptions. > - Link to v1: https://patch.msgid.link/20260527-staging-fix-1-v1-1-66ad880bcf76@yahoo.pl Those sorts of comments go here. > > To: Greg Kroah-Hartman > Cc: linux-staging@lists.linux.dev > Cc: linux-kernel@vger.kernel.org This stuff is fine since it is just discarded but it's also unnecessary. regards, dan carpenter