mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Frank Li <Frank.li@nxp.com>
To: Stefano Radaelli <stefano.radaelli21@gmail.com>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	imx@lists.linux.dev, pierluigi.p@variscite.com,
	Stefano Radaelli <stefano.r@variscite.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1 1/1] arm64: dts: imx91-var-som-symphony: fix RGB_SEL handling
Date: Mon, 1 Jun 2026 16:42:32 -0400	[thread overview]
Message-ID: <ah3uuIeZ4Z6BMwfi@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <20260529134850.22196-1-stefano.r@variscite.com>

On Fri, May 29, 2026 at 03:48:50PM +0200, Stefano Radaelli wrote:
> From: Stefano Radaelli <stefano.r@variscite.com>
>
> RGB_SEL is a board-level signal driven by the PCAL6408 GPIO expander on
> the Symphony carrier board.
>
> The signal needs to be driven high on the i.MX91 variant to keep the
> board in the expected display configuration. Move the handling of this
> line from a fixed regulator tied to the PCAL6408 supply to a GPIO hog on
> the correct GPIO expander.

Look like this can't resolve your problem.  gpio driver may probe later
than display, so gpio-hog may not set correct when display setup.

Frank
>
> Fixes: b3292129dcef ("arm64: dts: imx91-var-som: Add support for Variscite Symphony board")
> Signed-off-by: Stefano Radaelli <stefano.r@variscite.com>
> ---
>  .../dts/freescale/imx91-var-som-symphony.dts     | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx91-var-som-symphony.dts b/arch/arm64/boot/dts/freescale/imx91-var-som-symphony.dts
> index ac9fed58357e..c1e6c9978275 100644
> --- a/arch/arm64/boot/dts/freescale/imx91-var-som-symphony.dts
> +++ b/arch/arm64/boot/dts/freescale/imx91-var-som-symphony.dts
> @@ -97,13 +97,6 @@ reg_fec_phy: regulator-fec-phy {
>  		regulator-always-on;
>  	};
>
> -	reg_rgb_sel: regulator-rgb-enable {
> -		compatible = "regulator-fixed";
> -		regulator-name = "RGBSEL";
> -		gpio = <&pca9534 7 GPIO_ACTIVE_HIGH>;
> -		enable-active-high;
> -	};
> -
>  	reg_usdhc2_vmmc: regulator-usdhc2 {
>  		compatible = "regulator-fixed";
>  		regulator-name = "VSD_3V3";
> @@ -258,7 +251,6 @@ pca6408: gpio@21 {
>  		#interrupt-cells = <2>;
>  		interrupt-parent = <&gpio2>;
>  		interrupts = <4 IRQ_TYPE_EDGE_FALLING>;
> -		vcc-supply = <&reg_rgb_sel>;
>  		wakeup-source;
>
>  		tpm-enable-hog {
> @@ -267,6 +259,14 @@ tpm-enable-hog {
>  			output-high;
>  			line-name = "tpm_en";
>  		};
> +
> +		/* RGB_SEL */
> +		lvds-brg-enable-hog {
> +			gpio-hog;
> +			gpios = <7 GPIO_ACTIVE_HIGH>;
> +			output-high;
> +			line-name = "lvds_brg_en";
> +		};
>  	};
>
>  	/* USB Type-C Controller */
> --
> 2.47.3
>

  reply	other threads:[~2026-06-01 20:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-29 13:48 Stefano Radaelli
2026-06-01 20:42 ` Frank Li [this message]
2026-06-03  9:12   ` Stefano Radaelli
2026-06-03 18:03 ` Frank.Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ah3uuIeZ4Z6BMwfi@lizhi-Precision-Tower-5810 \
    --to=frank.li@nxp.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pierluigi.p@variscite.com \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=stefano.r@variscite.com \
    --cc=stefano.radaelli21@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®