From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2310D394EA6
	for <linux-kernel@vger.kernel.org>; Tue,  2 Jun 2026 12:27:43 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1780403265; cv=none; b=tacmOAi+SrBZnsK8fXmhZFVo3IiUGFROGTE556tOTc/YmrKnK+GYn5ZLpJqc+lZcBjSW1wwNuQqqqVgMGrJzbIQkGdACBLnZq96Okm7d9wx9OfaQX0YZxOUWflf9SyZJCn8ZGj9hYytlciUsqlauA+dL7EhF3zv+V0XZLceAzLk=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1780403265; c=relaxed/simple;
	bh=39WEf6zIZHP5iGMMkNJQuPBwWYNkWeJT+8q0IqaVn70=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=d+N0TJVci+bqEZLtLNIUscjLt7zaU9UwiXru5bJrgQengRM0ES9VROyXDzzL9E8zl+Pnk6P6FXSv6tPfJdOgqV5ls/tM4RDRZRVItygXQ4ColM2KXXeDt4P1XCDIvVeIJLbIjE3mg5neO1wpZxkmKyYBxSYtMmvA2xHsu6dQZ1I=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KytPpwjS; arc=none smtp.client-ip=100.103.45.18
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KytPpwjS"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9BB5C1F00893;
	Tue,  2 Jun 2026 12:27:42 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org;
	s=k20260515; t=1780403263;
	bh=39WEf6zIZHP5iGMMkNJQuPBwWYNkWeJT+8q0IqaVn70=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To;
	b=KytPpwjSafLfL8lgUtnQ8xtkbT6KcgWmXjGDHTMnarQ4fhBoLIJF+p51zwO7WJhMp
	 sGzVEE5vuuf2s+1ZhCW1WSRPx9hJyog9bdcZECJ9yGJaiYDWdxM5P2mumpWDlj0M49
	 zNIYWvKll9ZYRrq3hLnivC1LWx9CgCGHlxdurcwG2fK+nvjkUNrv/vetgshV/dLcU4
	 lrAOBpFsKeoU39QCDdy+SGN+N8U4R8Owm8z7C4AVpg2Rtuj3DtHrSYEaicWtBvRZ+N
	 2liXLgnpaom5nRcDs795/9A1Arhv4mjMk2YC7w3E3konyhBTMdhRKpcPn0r51iJebC
	 i3r52Prlx6JKg==
Date: Tue, 2 Jun 2026 13:27:38 +0100
From: Keith Busch <kbusch@kernel.org>
To: liuxixin <gliuxen@gmail.com>
Cc: linux-nvme@lists.infradead.org, axboe@kernel.dk, hch@lst.de,
	sagi@grimberg.me, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/2] nvme: fix FDP fdpcidx bounds check
Message-ID: <ah7MOp-cE0KqaW0i@kbusch-mbp>
References: <20260527133205.GA12042@lst.de>
 <cover.1779930057.git.gliuxen@gmail.com>
 <20260528083016.GB7073@lst.de>
 <20260528083043.GC7073@lst.de>
 <cover.1748418000.git.gliuxen@gmail.com>
 <a1e2f3c4d5b6a7890abcdef1234567890abcdef12.1748418000.git.gliuxen@gmail.com>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <a1e2f3c4d5b6a7890abcdef1234567890abcdef12.1748418000.git.gliuxen@gmail.com>

On Thu, May 28, 2026 at 06:00:01PM +0800, liuxixin wrote:
> The fdpcidx bounds check sets n = NUMFDPC + 1 but used > instead of >=,
> incorrectly accepting fdp_idx when it equals n (i.e. NUMFDPC + 1).

Thanks, applied patch 1 to nvme-7.2.

Take a look at my omment on patch 2 and let me know if we should wait for
a new version for that one.