From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D2898360EC6 for ; Tue, 2 Jun 2026 15:15:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780413349; cv=none; b=Gn2RLthZry9+4OCTbVqRyqVLSPGpqm1IxxOYye4NarJmnXCgAo0yjeCo5JxViyDH1BZsSYcjcKX+0WMqzbm3t8KE2yBL+cMW3NCpMeJtFld1AC1+Oy2EN3nULhdhsUxhol7+4PwL8kXTzZZ+bd+2yeVP+mBZJg8mp4FJCKFQJ9k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780413349; c=relaxed/simple; bh=mik5UeIt+SCSul1bs+RQRBREsSE2vEHd/ETDhBGDMVU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VlMusHC1yZ+oZQu0LadtvtBaAt+sKXjhYa09zEJVb67pvT3OXBprWe/t4I/QdbYDN7roZCsGnOvM2yFxTCyarSh3mtWndWzlMwEYcjdzfuciC1tk4JBNNa6rNWFFoHqS1CygpxN3g5c0f4WsG5dt/JJ4979z1U2EvdMrrOAy8Jc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Uoztegv+; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Uoztegv+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 15E341F00893; Tue, 2 Jun 2026 15:15:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780413348; bh=LxZaES6QzKJciwH+6bxlgoIAWhn5EPiEaviksyyXPJY=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=Uoztegv+qozYXlC6oNk1quA4Ackno4FHkPnjiQUnU5XVgDzQlNiOtWyom1xxC6Kx4 gnugmhdnBZr/t4MpGvmbp+Mf24NclAbQDPu0e0Ww1Wfzj/RU0lL7cYyYptM1SGIRT7 InzSaOMjn2F5dP2bZ+WViuiDLx6/QCAjv36nTGVHYh+krsC1ndYS7pogbn4OLhC7xE wB34gnu2W0gn+1nAhodLp4hoDTWma7LuGVVFccBQXF/jgYApbo9qf2P/OU0Xpg8LgX AXFO10v4qm6l3JMUWVQ4jOCE/HMR4ZnlLsTS1PJA24r6lEZC7GOuXWvY8Ov9jsBow+ I31k5oU7A2SJQ== Date: Tue, 2 Jun 2026 16:15:41 +0100 From: Keith Busch To: John Garry Cc: Chao Shi , Jens Axboe , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Christoph Hellwig , Sagi Grimberg , Daniel Wagner , Hannes Reinecke , Maurizio Lombardi , Sungwoo Kim , Dave Tian , Weidong Zhu Subject: Re: [PATCH v3] nvme: core: reject invalid LBA data size from Identify Namespace Message-ID: References: <20260515185853.2761456-1-coshi036@gmail.com> <0938b6f8-8001-4fcf-95a4-327fa9077163@oracle.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0938b6f8-8001-4fcf-95a4-327fa9077163@oracle.com> On Tue, Jun 02, 2026 at 02:10:07PM +0100, John Garry wrote: > On 15/05/2026 19:58, Chao Shi wrote: > > + if (id->lbaf[lbaf].ds < SECTOR_SHIFT || > > + check_shl_overflow(le64_to_cpu(id->nsze),> + id->lbaf[lbaf].ds - > SECTOR_SHIFT, > > + &capacity)) { > > + dev_warn_once(ns->ctrl->device, > > + "invalid LBA data size %u, skipping namespace\n", > > + id->lbaf[lbaf].ds); > > + ret = -ENODEV; > > + goto out; > > + } > > JFYI, this is giving a C=1 warning: > > drivers/nvme/host/core.c:2411:13: warning: unsigned value that used to be signed checked against zero? > drivers/nvme/host/core.c:2411:13: signed value source > > I can't seem to quieten it myself, though. > > BTW, I would have thought that check_shl_overflow would catch > id->lbaf[lbaf].ds < SECTOR_SHIFT (so that we don't need the extra check). I see it too. check_shl_overflow has checks that suggest it was expecting a signed type, as all the < 0 checks don't make sense for unsigned. The warning seems harmless, but I'd too like to see it suppressed. I think it's odd that I'm not seeing a similar error for the similar usage in generic_check_addressable() from fs/libfs.c. They look the same to me with respect to the types passed in.