From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Stepan Ionichev <sozdayvek@gmail.com>
Cc: jic23@kernel.org, andrea.merello@iit.it, dlechner@baylibre.com,
nuno.sa@analog.com, andy@kernel.org, hcazarim@yahoo.com,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: imu: bno055: terminate dev_err() strings with a newline
Date: Wed, 3 Jun 2026 01:17:15 +0300 [thread overview]
Message-ID: <ah9Wa4jaKZwm_HVh@ashevche-desk.local> (raw)
In-Reply-To: <20260520190851.11390-1-sozdayvek@gmail.com>
On Thu, May 21, 2026 at 12:08:50AM +0500, Stepan Ionichev wrote:
> Two dev_err() calls in bno055_ser_write_reg() and bno055_ser_read_reg()
> are missing the trailing newline, so the kernel log buffer continues
> the next message on the same line.
>
> Add the missing \n.
Surprisingly the kernel log buffer will be fine even without this patch.
So the commit message should say something about consistency of the style
and theoretical problems in the future in case one switches back from dev_err()
to pr_err().
You can dig into sources to understand why your patch changes nothing in the
behaviour.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-06-02 22:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-20 19:08 Stepan Ionichev
2026-05-20 20:13 ` Maxwell Doose
2026-05-22 14:59 ` Jonathan Cameron
2026-06-02 22:18 ` Andy Shevchenko
2026-06-02 22:17 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ah9Wa4jaKZwm_HVh@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andrea.merello@iit.it \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=hcazarim@yahoo.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=sozdayvek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®