From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 026EF25A642 for ; Fri, 22 May 2026 10:56:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779447399; cv=none; b=XGJD8s15b6Lx/lFJcrHnaC9HtR5jEaXdgRSwNC6n+h6/MpSL2zSk6lNF4/EbX/ygwruzqoj+MNV0rVzUbhUQNfuZQxkKGM7pQSrRJriemJ/V+Z46yz1RU0oKZIH4gbHLp8sC/PFAG4K01q1tmyXSouh3uRaN4eUqFG6uipvrUGk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779447399; c=relaxed/simple; bh=G3C8AA3aBQG4zBiFmg6i/Kea2xbAGhfwlk80hRI8Pco=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=a8X624k2UeUHPTUuVEggxmsBaHI1ImeDo9Zoc9GnKiqVCMwWw98OKX4nkqHtWxIqtfc3EGxvoEFhuEW6xM/d1jceJkq1sxCykQY7boJpBu7ljiELen7Hju+rCOWoQdZ12ZYdhBiOYVqY7pg1dtyi9dG2GhET3/hIDspCnJk16P0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=GZDvQ+BV; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="GZDvQ+BV" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 56E231F000E9; Fri, 22 May 2026 10:56:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779447397; bh=G3C8AA3aBQG4zBiFmg6i/Kea2xbAGhfwlk80hRI8Pco=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=GZDvQ+BV2gIhWz1KcWNqIokkPe3+pmnvjtNIR8a7OmQ20Vp3wjz13sSaV/AwQwWcb y0KZqqt1/Z1Yndl3pxfh9EYG8klpv60UUkB/iW8GNYRb5JxG1qNpiJ821hOO+QgTD7 ZNY/DeESqUZO9+u3THunLruifoVxeSGm2han7zPPTGgfXYoflsgEVIwAHfrW1RrCBF H6TEAzLOTFWGz1Ec3DiYk3GbRu58XR8da/ccOcyODVhw4/FJQpuMZ2TPyglqIwnSWz 51y7TuwS/pM+vTTa/fyHQCp3s5SVSIYBUZR0gIDbM77Po6lYqc6HgYyJn/PCuuraB9 SElpOCmLCj22g== Date: Fri, 22 May 2026 11:56:31 +0100 From: Lorenzo Stoakes To: Barry Song Cc: ranxiaokai627@163.com, hughd@google.com, baolin.wang@linux.alibaba.com, akpm@linux-foundation.org, leitao@debian.org, ziy@nvidia.com, liam@infradead.org, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, lance.yang@linux.dev, david@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, ran.xiaokai@zte.com.cn Subject: Re: [PATCH v3 2/2] mm: shmem: refactor thpsize_shmem_enabled_show() with helper arrays Message-ID: References: <20260518123238.56344-1-ranxiaokai627@163.com> <20260518123238.56344-3-ranxiaokai627@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Fri, May 22, 2026 at 06:44:18PM +0800, Barry Song wrote: > On Fri, May 22, 2026 at 6:35 PM Lorenzo Stoakes wrote: > > > > On Mon, May 18, 2026 at 12:32:38PM +0000, ranxiaokai627@163.com wrote: > > > From: Ran Xiaokai > > > > > > Replace the hardcoded if/else chain of test_bit() calls and string > > > literals in thpsize_shmem_enabled_show() with a loop over > > > huge_shmem_orders_by_mode[] and huge_shmem_enabled_mode_strings[] arrays. > > > > > > This makes thpsize_shmem_enabled_show() consistent with > > > thpsize_shmem_enabled_store() and eliminates duplicated mode name strings. > > > > > > Signed-off-by: Ran Xiaokai > > > > From: ranxiaokai627@163.com > > > > This does not match the From: field of the email. > > > > This is violating kernel process. See > > https://docs.kernel.org/process/submitting-patches.html > > I’m not aware of this rule, since I usually see From matching > Signed-off-by. Do we really have such a rule? Sorry, I might be a > bit ignorant about this 🙂 We do yes. But I was wrong here, as the From: field was provided inline (doing that and including the From: field in the To/Cc I think suffices). > > > > > Please either update this to your 163 email account or resend from your > > zte.com.cn address, otherwise we can't take this. > > > > Cheers, Lorenzo > > Cheers, Lorenzo