From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A67930E821 for ; Fri, 22 May 2026 08:19:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779437961; cv=none; b=nALqPQV5wzYmmxZ102fYwWNhyCOFJ630/6ir/ShoF0QdItHdDBmU/AQ/1PR21GytYA303yyPDrBQtH0yG5UHlWxiQ3mzKvf7pct8eYfCKYB3v5wynOMcjX2enIwy0T/q4u19wLIx6ohcV52DWolnLXNE7ZISeZXwbsE58jZrH6U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779437961; c=relaxed/simple; bh=K76PmehaROa3caw645nVV956t4rYqwhcRJKbaCfQyas=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bhJeougMx7nkozye5+ZJcDTmS0NSDrtlytlwcQJVWGQpl4nieYiee6ZtEdfhVqjYz+QBcDbKg0a5Fjkx8Fe4IyYlfOk4RHAGaprHS/j+skqN/jmoiyGm0PW/ZQMQ599fGeglpfivcq3xcY6ymtbiMXI7oinnnOT6r6iZlXumZYw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=b1CJNC9r; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="b1CJNC9r" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-488ab2db91aso73720465e9.3 for ; Fri, 22 May 2026 01:19:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779437959; x=1780042759; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=SQjdyFA3zMVN8xrvWkSk7MeeUm/hFE7TcsbJtkRO6lw=; b=b1CJNC9rbzz1UnykUFY9tGwQeDV1f0oZcyfe4ZxJOozR8Krq8z3Rtd7yom+kGBpKbc bq4kQoycZ3Rt3f3nSI0wiCS36zsBsHoblMI+uHMBk2C4tU2haTVRoFiwn9IzuVvT4nrJ S91NnjvyovTGIOqlQYAUIRfLVwwhVz020dMomAKClqJ8eslR6PzJz25l9bFp5TTCfVOA UcToBsQe+BDTdLTZmLFTQh52IMwnv/bNdL4WqmY5LTTsU1yZWWT5cEtsKS/Ki6Vx+cSs lJYl1NWsj+Atvd0xwjDEWFLjoVAvY2fnh+zbbuFfO/Cjfazmj63xuEKzR0uFIiAhzcar E79A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779437959; x=1780042759; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SQjdyFA3zMVN8xrvWkSk7MeeUm/hFE7TcsbJtkRO6lw=; b=ZRCdRyOJPmCAt91UHBlhaENQhJAW3reoGxfIT4tdzm+VbSua2KfTOTzXn+lfVdQsAS sAmMK3168K2yihdRRs1LzYpgkm2UeIuVfVYtEm4bBnNN8EUmkI8BvSwKnw3QxFMJfcmG 69sXQq92csC+nh0JpNrBISTlZtNJJjQ9OSst07poPIXkMn3OiZJUojTavkkobWzlJZGs LjFXNq1e1ZnuunSuu/OjuJ4z0IWJ318YDh18qmSRh1d/5tkbyrvoyFHUzJ8FdZelHMVr +aic0nSRBTtdC5vGw5A5l6hCqLz+K+9Hkp5uPAZrU5oFyQvD6qvStuWr5TWonXvFDKYJ W5Rw== X-Forwarded-Encrypted: i=1; AFNElJ+HkawFwOPF13l038FZ7Gn2sTSut9oxk486nt9YntUJNJ5yOGGja3XxkEjg0Y5UmzPKmvM3RJFNHyfA9QU=@vger.kernel.org X-Gm-Message-State: AOJu0YzAj+r6E1DW1gqpG3MScnLLkNgEI/JKgr4bqxebGaUb5y4rPwUx 6E+BUghc0tv8i2xHGp3Al9f1WSOE+A26KEvZooY5BRYqZOHAfrDA48LL X-Gm-Gg: Acq92OH2xx+sV+Sq6JNzWR8lINhtyPf7Waqo6omVjlRj4efYvh6cwhXZNwKaXkRIyMU REzPF9i2fKAYlqY7V1sV99CJ05wQ/xQD5j9CRysCv066Vux9bi03vdAxlu66qs4OE8ZTFfGnwe/ GdjAV6nW7Ly7gI2BgRDysbjGblDvGn38zPsCgBuSnoQatJUdhqMCxVF9RThBHdJFIYJ6aWysRop GyuYxjXA9Dh7GsySSESAa0e3mtfrilrZEc1fGZRECdgMJqwD0j/sv2jHE/DgwGv2YcfDmNUUCnV 0R9uz/dJ4cva8wunvMUYlYRTkC0RjLceZbAI/du+BdYbS9H99Det+tyrQ/mfrpSPTrSQ0LU3sfi WlSWunj0+nkr8bKI15Y5+3S1RXnxFa8ehOQWg/KEfHubo0JhZXysFza/w+w0HTY6dLEnQwSuXPt VwAPWVRRaTT/jDdovk2mDEBYSLVHtVSmX4fzFVeCtTCxoYow5tbOtFrg9YDHC33vBQ70ymwCR5f FlK7LPlW03mCtBgCC/GtXYfkOFqgcoYvg== X-Received: by 2002:a05:600c:530e:b0:490:18cb:e820 with SMTP id 5b1f17b1804b1-490426d1a33mr30905905e9.21.1779437958781; Fri, 22 May 2026 01:19:18 -0700 (PDT) Received: from fedora (cpc92878-cmbg18-2-0-cust539.5-4.cable.virginm.net. [86.16.54.28]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49044775266sm9567105e9.33.2026.05.22.01.19.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 May 2026 01:19:18 -0700 (PDT) Date: Fri, 22 May 2026 09:19:16 +0100 From: Vishal Moola To: Brendan Jackman Cc: Andrew Morton , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Johannes Weiner , Zi Yan , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/page_alloc: drop a misleading __always_inline Message-ID: References: <20260517-b4-drop-always-inline-v1-1-97b90930e8b8@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260517-b4-drop-always-inline-v1-1-97b90930e8b8@google.com> On Sun, May 17, 2026 at 11:37:05PM +0000, Brendan Jackman wrote: > get_pfnblock_migratetype() is called from outside page_alloc.c, so it > cannot always be inlined. Remove the annotation to avoid misleading > readers. > > At least in my minimal config, with GCC, this doesn't change > mm/page_alloc.o at all. > > Suggested-by: Vlastimil Babka > Link: https://lore.kernel.org/all/016c8bef-57ef-44ef-bf60-86dbfd368dcd@kernel.org/ > Signed-off-by: Brendan Jackman > --- Reviewed-by: Vishal Moola