From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A96C466B4C for ; Fri, 22 May 2026 16:39:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779467983; cv=none; b=hpesshivPeoBchtgjpkcNKhgNI7CpxL9mYbjljhaRw58y97HgRxk26+LWY/j4bgVeemsDR/FtnmBy8V6+QyB5p+UE8dZNYbAVuxBFPy7BHfhJ9e1Z/2rHacnkWf9SoC7YF1w9FNXn/MFj6JuuScj0qVBG2m1pxPFOSLMXx4EM8U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779467983; c=relaxed/simple; bh=z03yOLfePnutgrdptQvCWmoWp17mpFWdnNjNXys44yA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=F4yN99CQZIp9I1Uqq4rWqrR/Hh1Zxz1wif9ZIzuVNkDjgpWyR7F8fiPFBbcoYXFD8wi8OP/ad91irVsqKAHPMBejnd3FOw/cnRD1htrrxk3/inZYC32HC3pHbQo+mq8B96SgRZoCyok8kGB28hEIJEdBYZPTrSfWVC+tQyNSiAc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=l1fUqlYM; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="l1fUqlYM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6D8E11F000E9; Fri, 22 May 2026 16:39:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779467981; bh=yHQOjzL79KFwlGy7K6imilcrIfMmMX1LgRmEpNbNmUk=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=l1fUqlYME0EEz52BXbw7gSyCB43SnXj85ncD0k3fsYtlGjbJ27r3ifTOlhE6Tupoe C+uMyQM/56ODnRd7cHZ24yPe+DvHYlaGKoSOJlMs+iqyc7hTax0+EvGH+8dLi29/O9 bcx+Ty+rL2BCNBhZL4cnm8mcD+ZJ5x0puc9cetbmWjqanU4IMNoqmcIFgGNujS6T7V mB07RwXpbiSdtVRR4Y3yOiYnYXI61Uj0oU09uwTf6Bk6x9w+VkkLwcktqyCsfc4oF2 An0bDyTWm1XYuXep+SEj7UqH3jAfkrD9F+kx15tD3GB6Dn1vwYX3kY5IJxVKSqvfdI FmACe6PbQeO8Q== Received: from phl-compute-04.internal (phl-compute-04.internal [10.202.2.44]) by mailfauth.phl.internal (Postfix) with ESMTP id CE5E7F40078; Fri, 22 May 2026 12:39:39 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-04.internal (MEProxy); Fri, 22 May 2026 12:39:39 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefhedrtddtgdduhedtieejucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepmfhirhihlhcu ufhhuhhtshgvmhgruhcuoehkrghssehkvghrnhgvlhdrohhrgheqnecuggftrfgrthhtvg hrnhepueeijeeiffekheeffffftdekleefleehhfefhfduheejhedvffeluedvudefgfek necuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepkhhirh hilhhlodhmvghsmhhtphgruhhthhhpvghrshhonhgrlhhithihqdduieduudeivdeiheeh qddvkeeggeegjedvkedqkhgrsheppehkvghrnhgvlhdrohhrghesshhhuhhtvghmohhvrd hnrghmvgdpnhgspghrtghpthhtohepgedtpdhmohguvgepshhmthhpohhuthdprhgtphht thhopeihrghnrdihrdiihhgrohesihhnthgvlhdrtghomhdprhgtphhtthhopegurghvvg drhhgrnhhsvghnsehlihhnuhigrdhinhhtvghlrdgtohhmpdhrtghpthhtohepphgsohhn iihinhhisehrvgguhhgrthdrtghomhdprhgtphhtthhopehsvggrnhhjtgesghhoohhglh gvrdgtohhmpdhrtghpthhtohepthhglhigsehkvghrnhgvlhdrohhrghdprhgtphhtthho pehmihhnghhosehrvgguhhgrthdrtghomhdprhgtphhtthhopegsphesrghlihgvnhekrd guvgdprhgtphhtthhopeigkeeisehkvghrnhgvlhdrohhrghdprhgtphhtthhopehlihhn uhigqdhkvghrnhgvlhesvhhgvghrrdhkvghrnhgvlhdrohhrgh X-ME-Proxy: Feedback-ID: i10464835:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 22 May 2026 12:39:39 -0400 (EDT) Date: Fri, 22 May 2026 17:39:38 +0100 From: Kiryl Shutsemau To: Yan Zhao Cc: dave.hansen@linux.intel.com, pbonzini@redhat.com, seanjc@google.com, tglx@kernel.org, mingo@redhat.com, bp@alien8.de, x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-coco@lists.linux.dev, kai.huang@intel.com, rick.p.edgecombe@intel.com, yilun.xu@linux.intel.com, vannapurve@google.com, ackerleytng@google.com, sagis@google.com, binbin.wu@linux.intel.com, xiaoyao.li@intel.com, isaku.yamahata@intel.com Subject: Re: [PATCH v2 3/4] x86/tdx: Drop exported function tdx_quirk_reset_page() Message-ID: References: <20260430014852.24183-1-yan.y.zhao@intel.com> <20260430015001.24242-1-yan.y.zhao@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260430015001.24242-1-yan.y.zhao@intel.com> On Thu, Apr 30, 2026 at 09:50:01AM +0800, Yan Zhao wrote: > KVM invokes tdx_quirk_reset_page() to reset TDX control pages (including > S-EPT pages, TDR page, etc.), as all those pages are allocated by KVM TDX > and thus always have struct page. > > However, it's also reasonable for KVM to reset those TDX control pages via > tdx_quirk_reset_paddr() directly, eliminating the need to export two > parallel APIs. Keeping tdx_quirk_reset_page() as a one-line helper in the > header file is also unnecessary. > > No functional change intended. > > Suggested-by: Paolo Bonzini > Suggested-by: Xiaoyao Li > Signed-off-by: Yan Zhao Acked-by: Kiryl Shutsemau -- Kiryl Shutsemau / Kirill A. Shutemov