From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4885D3126D7 for ; Sat, 23 May 2026 07:53:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779522800; cv=none; b=nZswoxHXDo4YRqb32b9RSVKjBsjK4uYQ7umbx8M6hcRDtJlTn+2900MXNx1uJIoBW61yeMcNVkZVjeymg90rOx0Ncf0P0aEdpHd+dE5hueADr9FE34rH/fIJj7R7hWy2n3TQ/JBgTNy1VelSCk7acZUWbL+qXpw2+xxDOqXHjMM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779522800; c=relaxed/simple; bh=/u0BUnxicbI901xd1+sfzYs4bKPpIgIBaoY9Qr6bahQ=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cYEjsWlglBgt1dZhTBtokgrkNUame6oycDRR1BTb6I/OP0lyoyA7Y7KJRvwwBzk+VGW3+D0c5K5IoBasFdTHWoL2PG9MTfiEI87QF2bslzIAPSgOMzMPuEUHgB4+yaAzMDnZZczOAm8BtS+SielxYskZTkWqXu5mn/hjCvWUz6w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cOP0KSgf; arc=none smtp.client-ip=209.85.167.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cOP0KSgf" Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-5a8891f0c51so8362125e87.1 for ; Sat, 23 May 2026 00:53:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779522796; x=1780127596; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=zd0pyH4JyTVrhWiF/m1kbVJHvnAmP0kTBiQpkGCTOkE=; b=cOP0KSgfvYPnWn71dlBP+LUeuUCqFVHHkFLqDGNIXqwz6zmvTlVK8/1YRKXTl5XkpF GYA/lYdsKaQuQGIoyp7kLP/1SxXp/cj8oFyUgmFlREjvSYEobL4llbqiZI9BhWQ/9J4k WyWIwsufOG3D4wP92mugdXt9/9NEt3GXNICIXIDVXJcb0TPw+ZOcHHaF+FCDZE3IuVyP cUc3pbDGDz8stNEgwa+hR7ppCae2ZB9rUfYZqVVosJhX+ivbIlzNOe4W7VNQf8VUq2Eh As21oUD8LpKQL5jNbCKR8yUhvZjnXBjBmzGwbW0pVCwBoA9YrVhmBDEFknEsl5AZj9T9 5PxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779522796; x=1780127596; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zd0pyH4JyTVrhWiF/m1kbVJHvnAmP0kTBiQpkGCTOkE=; b=PfAPVdpD2CQQr+lt8ro45qDrI+nDADpl9TbmFooSDPF0MoMFyjOusjTDKrsue+seVb bFfCFaOVVXqPMRwz0HvwCgO1UkRHCbyL11v05WcJAAqPvviaGGp3ULXRS/R5MbGM9JyO UJ2gsHNEGoLIvuutnnmacUD+w+ad1Qevvfcm7CBXrRDW80K5YPtyoPG7x85+v0onMBw1 h58kWg5FwndNpd3+l8Sd9X148xRoUmq58iUWcGhTM7kG0k0nORbWbUlMoYiqYUSdYnKe n0PdKjQH0KX7/2dt0c3tr58xomz406Fnip86N0oKFvEVN3J067O/RRl68U6KaGydfewJ soyg== X-Forwarded-Encrypted: i=1; AFNElJ9P6OSTgm3QX4pTy/e6HnmLhwst7GzHTgiCg9g9WLrVSB2ufCPM0Z9oGh1DEMEnFdrr9OXxlVbCKP2vS0U=@vger.kernel.org X-Gm-Message-State: AOJu0Ywchk5hGB6beaFZiw9wAiCy+cFaQOCOnkRRgfhMq+V61ghHIcth VmdaBTXnNKO0fiUT2pvZx1q5ffa1F634HH8C0Tt4AdAxL6QDLBbiCmsn X-Gm-Gg: Acq92OHxJKkspNlcdmmniVm/3Z1qjQxj98GXho6UawOH0qsIWT9rf8dCA0gmhx1VPm9 OMX5gz54b3bsT0r7K1l/7sPZxD+YNIPsPUYnjiSGAZ5rUjG9kntNKPudKqrB0DhF7f9uIy81mAY 5rFnyer2yLOWPpJoaG4sSQBF8XIxKZVf9Z+wGzC14s9XXXrOr4TLcX6/NE5bcxQnOw7fJMF4Nbx 6mubQ273+tfzrB1ub7W/odmCdZN4wfduo8yF5MDASEYV+2QQactkInpWrE9CUJcccof7m3mms9s QX8evbOZruNqNi9IH9e5lSut03YVxfJnXlHcU+orBZsIWRl8V4qDzAdT9MGWtEXbYnA9PDcO/e8 K6i0EHFqgKVhB0ymaJqIxryhf5+u0wvv0zbjt7n54Lrx4P4cLUxaUXFSube9PLlAd7rX6vrzl+E Tl/DHwOzpMUrmMiM89ipuq60rFpVGFqXZh787XfSpjCwBzHUoSqXmdl3Sby9grPQ== X-Received: by 2002:ac2:4312:0:b0:5a8:a754:4b57 with SMTP id 2adb3069b0e04-5aa323b28e6mr1722088e87.41.1779522796191; Sat, 23 May 2026 00:53:16 -0700 (PDT) Received: from pc636 (host-90-238-28-226.mobileonline.telia.com. [90.238.28.226]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5aa32cb37a7sm981873e87.2.2026.05.23.00.53.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 May 2026 00:53:15 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Sat, 23 May 2026 09:53:12 +0200 To: Wen Jiang Cc: linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, will@kernel.org, akpm@linux-foundation.org, urezki@gmail.com, baohua@kernel.org, Xueyuan.chen21@gmail.com, dev.jain@arm.com, rppt@kernel.org, david@kernel.org, ryan.roberts@arm.com, anshuman.khandual@arm.com, ajd@linux.ibm.com, linux-kernel@vger.kernel.org, jiangwen6@xiaomi.com Subject: Re: [PATCH v3 6/6] mm/vmalloc: align vm_area so vmap() can batch mappings Message-ID: References: <20260522053146.83209-1-jiangwenxiaomi@gmail.com> <20260522053146.83209-7-jiangwenxiaomi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260522053146.83209-7-jiangwenxiaomi@gmail.com> On Fri, May 22, 2026 at 01:31:46PM +0800, Wen Jiang wrote: > From: "Barry Song (Xiaomi)" > > Try to align the vmap virtual address to PMD_SHIFT or a > larger PTE mapping size hinted by the architecture, so > contiguous pages can be batch-mapped when setting PMD or > PTE entries. > > Signed-off-by: Barry Song (Xiaomi) > Signed-off-by: Wen Jiang > Tested-by: Xueyuan Chen > --- > mm/vmalloc.c | 33 ++++++++++++++++++++++++++++++++- > 1 file changed, 32 insertions(+), 1 deletion(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 50642246f4d40..040d400928aab 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -3620,6 +3620,37 @@ static int vmap_batched(unsigned long addr, unsigned long end, > return err; > } > > +static struct vm_struct *get_aligned_vm_area(unsigned long size, > + unsigned long flags, const void *caller) > +{ > + struct vm_struct *vm_area; > + unsigned int shift; > + > + /* Try PMD alignment for large sizes */ > + if (size >= PMD_SIZE) { > + vm_area = __get_vm_area_node(size, PMD_SIZE, PAGE_SHIFT, flags, > + VMALLOC_START, VMALLOC_END, > + NUMA_NO_NODE, GFP_KERNEL, caller); > + if (vm_area) > + return vm_area; > + } > + > + /* Try CONT_PTE alignment */ > + shift = arch_vmap_pte_supported_shift(size); > + if (shift > PAGE_SHIFT) { > + vm_area = __get_vm_area_node(size, 1UL << shift, PAGE_SHIFT, flags, > + VMALLOC_START, VMALLOC_END, > + NUMA_NO_NODE, GFP_KERNEL, caller); > + if (vm_area) > + return vm_area; > + } > + > + /* Fall back to page alignment */ > + return __get_vm_area_node(size, PAGE_SIZE, PAGE_SHIFT, flags, > + VMALLOC_START, VMALLOC_END, > + NUMA_NO_NODE, GFP_KERNEL, caller); > +} > + > /** > * vmap - map an array of pages into virtually contiguous space > * @pages: array of page pointers > @@ -3658,7 +3689,7 @@ void *vmap(struct page **pages, unsigned int count, > return NULL; > > size = (unsigned long)count << PAGE_SHIFT; > - area = get_vm_area_caller(size, flags, __builtin_return_address(0)); > + area = get_aligned_vm_area(size, flags, __builtin_return_address(0)); > if (!area) > return NULL; > > -- > 2.34.1 > This one LGTM: Reviewed-by: Uladzislau Rezki (Sony) -- Uladzislau Rezki