From: Dan Carpenter <error27@gmail.com>
To: artur.ugnivenko@gmx.de
Cc: gregkh@linuxfoundation.org, ahmet@sezginduran.net,
linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH v7 3/3] staging: rtl8723bs: fix lines ending in parentheses in hal/sdio_halinit.c
Date: Sun, 24 May 2026 12:01:56 +0300 [thread overview]
Message-ID: <ahK-hNFBJSp2NOhz@stanley.mountain> (raw)
In-Reply-To: <20260522142700.23335-1-artur.ugnivenko@gmx.de>
On Fri, May 22, 2026 at 04:27:00PM +0200, artur.ugnivenko@gmx.de wrote:
> From: Artur Ugnivenko <artur.ugnivenko@gmx.de>
>
> Fix checkpatch warnings on lines that end in patentheses in
> hal/sdio_halinit.c.
>
> In _InitNormalChipRegPriority specifically pack all of the
> queues into a struct, to pass that as one argument instead of
> six individual values, so that those lines can be shortened and
> not end in parentheses.
>
> Signed-off-by: Artur Ugnivenko <artur.ugnivenko@gmx.de>
> ---
This is a grab bag of changes.
The new code is CamelCase.
I'm not sure it's really nicer than the old code.
regards,
dan carpenter
prev parent reply other threads:[~2026-05-24 9:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-22 13:19 [PATCH v7 0/3] staging: rtl8723bs: fix several style issues " artur.ugnivenko
2026-05-22 13:19 ` [PATCH v7 1/3] staging: rtl8723bs: shorten long lines " artur.ugnivenko
2026-05-22 13:20 ` [PATCH v7 2/3] staging: rtl8723bs: fix inconsistent braces " artur.ugnivenko
2026-05-22 14:27 ` [PATCH v7 3/3] staging: rtl8723bs: fix lines ending in parentheses " artur.ugnivenko
2026-05-24 9:01 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ahK-hNFBJSp2NOhz@stanley.mountain \
--to=error27@gmail.com \
--cc=ahmet@sezginduran.net \
--cc=artur.ugnivenko@gmx.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome