From: Ahmet Sezgin Duran <ahmet@sezginduran.net>
To: onish-cmd <neharora23587@gmail.com>
Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: sm750fb: Fix CamelCase style issues
Date: Sun, 24 May 2026 12:12:48 +0000 [thread overview]
Message-ID: <ahLqZbelgE6WWzjp@sezginduran.net> (raw)
In-Reply-To: <20260524115823.8813-1-neharora23587@gmail.com>
On Sun, May 24, 2026 at 05:28:23PM +0530, onish-cmd wrote:
> From: Onish Sharma <neharora23587@gmail.com>
>
> - Rename struct members: powerMode -> power_mode, pvReg -> pv_reg,
> pvMem -> pv_mem, setAllEngOff -> set_all_eng_off,
> resetMemory -> reset_memory.
> - Rename enum members: sm750_24TFT -> SM750_24TFT, etc.
> - Corrected MODULE_PARM_DESC formatting to comply with kernel style.
> - Note: g_fbmode warning intentionally kept to allow runtime assignment.
>
> Signed-off-by: Onish Sharma <neharora23587@gmail.com>
You are doing way too much in a single patch.
Also doesn't apply to staging-testing, your base is probably too old.
Make sure to base it from Greg's latest staging-testing branch.
Regards,
Ahmet Sezgin Duran
prev parent reply other threads:[~2026-05-24 12:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-24 11:58 onish-cmd
2026-05-24 12:12 ` Ahmet Sezgin Duran [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ahLqZbelgE6WWzjp@sezginduran.net \
--to=ahmet@sezginduran.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=neharora23587@gmail.com \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®