From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 23FF9358388; Mon, 25 May 2026 05:55:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779688518; cv=none; b=HnIDX4t//44it7xsBsabTVZv7EfxZo2QexGOdzB64lz+HnObWFXwhyjQIHsV/cMsUZNQYTToU0ajcI4b4oOdUbL5YqDyuTEScXchHOfh3aDNjZkebRvFiftuUbSbhbLyjTDEmuECGwGWKqrGOrL9Hs2/C9YR+iUsO77ru88gn4Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779688518; c=relaxed/simple; bh=/zIwOpbitf7WLzXzmB3Euq/uS1lyI9bpSUSP2miWa70=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=C0IcRiGX1n0HDMTzZAQbAEVdEu+xsQoGbL/hwXXSf9STT141EZ8wKQT787y4JaWIjCCTzBRRNr9bHG9UB/iaxLeefgi7qw9EqddL/pLZaspoNzkJ02ZUQ6T/HOT0Ko+c5Nw3aOWAZ0CFSSdq6qSamvjCc/eqNaaQ1ZwksybPgrw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=xlW8pfbL; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="xlW8pfbL" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=/zIwOpbitf7WLzXzmB3Euq/uS1lyI9bpSUSP2miWa70=; b=xlW8pfbLdj/TK2bo5zU5BLi1bi jXwYk8Y8nVYNhtjUqqjt3d92LokhxVkY/NxR8seyumuHMG7iW8bK/ScSNopbOZj5pRUSnwtr3WsHP gf3/rdFOt15PtkKSruX9KWpjTwi6h+ZvvnzJxrTLjfE7IaStcaX7xj/4BXCuYsPpBBUMbnhDKGu54 KvEpOKXXLA53tq0dssb4vb78JUFKDShhxhp4oQykeU+KAsnH3hlDqrhRK+xS3AutnIROYAdj3BHii n0/1TsZzWNZPhBVyfdxUrDxo5Fk1V+e4skjVlx5HZfDmDfIj0mFT/Jp3ga1/CdC8g5jPzF4N9gL2b aaPGt9RA==; Received: from hch by bombadil.infradead.org with local (Exim 4.99.1 #2 (Red Hat Linux)) id 1wROHS-0000000GMhh-4BHY; Mon, 25 May 2026 05:55:14 +0000 Date: Sun, 24 May 2026 22:55:14 -0700 From: Christoph Hellwig To: John Hubbard Cc: Sumit Semwal , Christian =?iso-8859-1?Q?K=F6nig?= , Christian Brauner , Jens Axboe , linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, LKML , stable@vger.kernel.org Subject: Re: [PATCH v2] dma-buf: set SB_I_NOEXEC and SB_I_NODEV on the pseudo filesystem Message-ID: References: <20260523011117.121390-1-jhubbard@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260523011117.121390-1-jhubbard@nvidia.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html On Fri, May 22, 2026 at 06:11:17PM -0700, John Hubbard wrote: > The dma-buf pseudo filesystem dispenses S_ANON_INODE inodes via > alloc_anon_inode() but never sets SB_I_NOEXEC on its superblock. > Since commit 1e7ab6f67824 ("anon_inode: rework assertions") in 6.17, > path_noexec() warns on exactly that combination, so an mmap() on any > dma-buf fd trips the warning: Just as last time this came up, we really should set this higher up. There isn't really a reason why pseudofses should not set SB_I_NOEXEC by default.