mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Petr Mladek <pmladek@suse.com>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	John Ogness <john.ogness@linutronix.de>,
	Sergey Senozhatsky <senozhatsky@chromium.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [QUESTION] printk: time namespaces and printk timestamps
Date: Mon, 25 May 2026 11:30:08 +0200	[thread overview]
Message-ID: <ahQWoDQq-AYV-SXt@pathway.suse.cz> (raw)
In-Reply-To: <e64e30fb-2a9a-47fd-ba81-dc1104fe2e90@t-8ch.de>

On Mon 2026-05-25 10:47:46, Thomas Weißschuh wrote:
> On 2026-05-25 10:37:40+0200, Petr Mladek wrote:
> > On Sat 2026-05-23 17:20:45, Thomas Weißschuh wrote:
> > > It looks like the monotonic timestamps of printk records do not take the
> > > callers time namespace into account when emitted through /dev/kmsg,
> > > /proc/kmsg and syslog(2).
> > > 
> > > To me this looks like a bug. What do you think? Should it be changed?
> > 
> > To be honest, I have never heard about time namespaces before ;-)
> > 
> > So, you propose to use the timestamp with the namespace-specific
> > offset when a message is added from the given namespace, e.g. via:
> > 
> >    echo "This message is from another time space" > /dev/kmsg
> > 
> > Do I get it correctly?
> 
> My idea was rather to do the conversion when *reading* the message from
> a time namespaced user process.

I see. But it might produce messages with negative timestamps. I am
not sure if it is a good idea. I guess that many tools might get
confused.

> > I see two potential problems:
> > 
> > 1. printk() historically used a monotonic clock. I am not sure if any
> >    usespace application depends on it but there is a risk of breaking
> >    something.
> 
> >From the perspective of the namespaced process currently the timestamps
> from printk may in fact not be CLOCK_MONOTONIC.

The messages stored in the kernel ring buffer currently always have
monotonic timestamps.

I guess that you talk about matching kernel messages with other
userspace logs. But they might be inconsistent also because
of using different clocks...

There were several discussions in the past about storing more
timestamps from different clocks in the printk ring buffer.
But it never went anywhere.

Best Regards,
Petr

  reply	other threads:[~2026-05-25  9:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-23 15:20 Thomas Weißschuh
2026-05-25  8:37 ` Petr Mladek
2026-05-25  8:47   ` Thomas Weißschuh
2026-05-25  9:30     ` Petr Mladek [this message]
2026-05-25 10:26       ` Thomas Weißschuh
2026-05-25 13:29         ` Petr Mladek
2026-05-25 15:38           ` Thomas Weißschuh
2026-05-26 20:08             ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ahQWoDQq-AYV-SXt@pathway.suse.cz \
    --to=pmladek@suse.com \
    --cc=john.ogness@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@weissschuh.net \
    --cc=rostedt@goodmis.org \
    --cc=senozhatsky@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox