From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 982623F58E2
	for <linux-kernel@vger.kernel.org>; Mon, 25 May 2026 15:49:28 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1779724169; cv=none; b=r1OJQ6EjgR5fYgCYYFB40iPeOrnNDkNndtRR50ftNnCcWzhQs4ohPotq/wOgMVGcKPrrMpk8RfaL6IyVuPnID6BffijRAyvPLLn16lp7d90C0QLOZA5WrC1qxD301OA73b2QNe1zHCc4wjmrOvrbxb9nmPE28vH8uaFDkAggA9w=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1779724169; c=relaxed/simple;
	bh=GPn7mz/hOKyenCC/J9V5+C9r2DRle9onNe7SqIivCUM=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=GPLl9LxJAQaNKUxmZZDhTNuitme8Mofu2YX21f36cNc1plQdtNidMjkzs/JUmyIC5klF37M/YSYP7N/tvYnmXg2KNqQdD1OzwAa0HFAFe4/srQLx+uCmLZI5QF8peTOmaLzvZS8AJHnb2E14U8NZ/MrSQs4peLZx/FfQkjsGm4k=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=V9jBY2BT; arc=none smtp.client-ip=100.103.45.18
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="V9jBY2BT"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id B6F391F000E9;
	Mon, 25 May 2026 15:49:27 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org;
	s=k20260515; t=1779724168;
	bh=sRxOUxStqxdr7ToPr/z6CmzNEjf8/d5APNiGmvmk6X0=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To;
	b=V9jBY2BTNbs4SFj0tf+g+3EF4U9ADRJ2jZuWAWh91wmrf1B7L/JeYZOxG7HGp8eHC
	 wvacoVas7/3LAyBdaJH5cCz5uEj4So+8jRZ4LygljjrXnOam/SZd0997r7y7LxhFRD
	 YDjZBdp50CUb0164zek5j14gvJvUn0c1aLvB/PHCipRtNPr8/jBcd5NS6O5zzCveHV
	 MQkZA/MH8a6SsbdFBbZoFgFMLeowb30BHGhW2AXMZzsfSY7Onx2sMRTB52ukxMTmnv
	 EjkGRmTF7sjrSi/HXEGu9jJ334IrTgNqe3eNOAAm2VA0o49qUBaTiXXiuTui3JjKA7
	 PFG2lW8+7wlKw==
Date: Mon, 25 May 2026 09:49:26 -0600
From: Keith Busch <kbusch@kernel.org>
To: Tokunori Ikegami <ikegami.t@gmail.com>
Cc: Chao Shi <coshi036@gmail.com>, linux-nvme@lists.infradead.org,
	Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
	Jens Axboe <axboe@kernel.dk>,
	Tatsuya Sasaki <tatsuya6.sasaki@kioxia.com>,
	Maurizio Lombardi <mlombard@arkamax.eu>,
	linux-kernel@vger.kernel.org, Sungwoo Kim <iam@sung-woo.kim>,
	Dave Tian <daveti@purdue.edu>, Weidong Zhu <weizhu@fiu.edu>
Subject: Re: [PATCH v5] nvme: reject passthrough of driver-managed Set
 Features
Message-ID: <ahRvhmaMCCqnxV62@kbusch-mbp>
References: <20260523225629.3964037-1-coshi036@gmail.com>
 <cda74a96-cff1-402a-bcdb-745c85f6c87b@gmail.com>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cda74a96-cff1-402a-bcdb-745c85f6c87b@gmail.com>

On Tue, May 26, 2026 at 12:34:03AM +0900, Tokunori Ikegami wrote:
> > +static bool nvme_cmd_allowed(struct nvme_ctrl *ctrl, struct nvme_ns *ns,
> > +			     struct nvme_command *c, unsigned int flags,
> > +			     bool open_for_write)
> 
> The struct nvme_ns does already have the struct nvme_ctrl *ctrl as a member
> variable as below so seems not necessary to add the function argument struct
> nvme_ctrl *ctrl.

This filter is for admin commands, so the 'ns' parameter is NULL for
this case.