From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7677B30BF68 for ; Tue, 26 May 2026 06:40:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779777631; cv=none; b=H1ZKJf5McQbn27kvJjxFuZaPXZoaH+fAWFcXDgsfnuRViKcjy5w0ss2e8llDdszztmRCqDJ9TbPC9deGQTfvG+fCE9V0Ml+Eg2W3vGKkkOZnDS4dYy9jdf02aoiAQOKkjKXp5IkvSRuI78cJaxOUHLOiJMfTnHV2O0F6Sc5SqGQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779777631; c=relaxed/simple; bh=0NF+O+HoFTX0wu1zGNOBZVBBYrPw9TwSaJ3lP6Q9m34=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=e8W5tSvABu6bdveFAUBAlETIV9QzfeuewzgqI2Kmkuuv/oXNqWfh+xQvC+nWWrtJkgLJ3lWdYCNpcRF2mIJjBZY9h26NStB9WE3hW6zPBGckLR++cm4NvzswOzsJJt8GmKxYKRNLbtt8Yj1xX7At1LkV389/ePxl+7rSLdWDF3U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=LJKqASH8; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="LJKqASH8" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=V2LceI+pOGTyXpaEeUAnDgzfZRyybbEx7vkadX2yVVA=; b=LJKqASH8uJftSyUGg+aUZ/Tl2p g86TZtPlcJ47qF0EQ13OZVqTTSnA+Fx5e9j9vuZ86dlLf7C8lk9RH9LSSz4qNjrrhmocWExF8cvHl mj2zyIavwSt+7u25sd6qtY5XTT4Tf9CPZ3wpI3BhLJ77XJNbQeYOI3JLdWksfP4qNkRjE+65BgLSv z3tINTqGlAUBbWD+Bwgn2+wAbJZnwbUbvWQCXm/l0j8G9qpH3wpj24nwQ4SrsUiT1LQZu7SC4dNtn X0zkmE8uo6WivwCmL2A3dM+UgoklLORwcyFr4MY1m0PCamAU7U+akrydEv86KakSwj6OfivGce6HY e84dkrcg==; Received: from hch by bombadil.infradead.org with local (Exim 4.99.1 #2 (Red Hat Linux)) id 1wRlSn-00000001Bfa-3nRY; Tue, 26 May 2026 06:40:30 +0000 Date: Mon, 25 May 2026 23:40:29 -0700 From: Christoph Hellwig To: Farhad Alemi Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] freevxfs: don't BUG() on duplicate OLT entries Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html On Mon, May 25, 2026 at 06:10:59PM -0700, Farhad Alemi wrote: > +static inline int > vxfs_get_fshead(struct vxfs_oltfshead *fshp, struct vxfs_sb_info *infp) > { > - BUG_ON(infp->vsi_fshino); > + if (infp->vsi_fshino) > + return -EINVAL; > infp->vsi_fshino = fs32_to_cpu(infp, fshp->olt_fsino[0]); > + return 0; > } > > -static inline void > +static inline int > vxfs_get_ilist(struct vxfs_oltilist *ilistp, struct vxfs_sb_info *infp) > { > - BUG_ON(infp->vsi_iext); > + if (infp->vsi_iext) > + return -EINVAL; I'd still keep a WARN_ON_ONCE in the conditional here as this is an unexpected condition. > + if (vxfs_get_fshead((struct vxfs_oltfshead *)oaddr, infp)) Overly long line here. Otherwise looks good. For the next resend please also include Christian Brauner as he picks up the freevxfs patches through the VFS tree.