From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C01103CBE6B for ; Tue, 26 May 2026 09:13:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779786812; cv=none; b=q/XufunccIpVrgHj3+o5QAcl9EXaK94bE5nACT4LQUik3Ki4SYKV/4ZCsmU4IQ6UwQcxTv/ieITOsMhat5lYIvW/IzWghsPab0bxfQE5bFxajb9E/wOw02WahY4v0ou7Co3zDaEa6IWjoXoFOh4bDO0ItsUgDs3k0GhLaswtUlU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779786812; c=relaxed/simple; bh=tnvNzldi4dh3CYgWJ3taA4pfAMb9zwfhwb4IJLga2JI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rodpkvJ4WTO7p2JJmitSd2LsFMT49WSfIAGKWhSfyCC18nK64bkIkojAh64dnLywM4gC13bL2WH9bL+XhT2MqZV3ubbYHnw/bIlQCcIcyP8sSpRnL57npX/JlYJo4TqkcSwbZ/yrSTHEOa6zuz0LOuGf11Xzyi6FJ9QQFPWP9g4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=KC/TPjn2; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="KC/TPjn2" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-48e8132c6d0so65080465e9.1 for ; Tue, 26 May 2026 02:13:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1779786809; x=1780391609; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=YbTEfLFWlj213t5VNtgTRv1qDlCZyoJalSTQ1GEGHb4=; b=KC/TPjn21zoq4c++SBN2GGIfzNG0w0VhJeNdPYZSbdRbfCvxQ/5K9w1AwCXyz4+OEw cb5a3EGx8jleO9kRoGrqlob8nCNUqAzpKWcf6WCWqy8F8jRVG/CQCQPJYJ9+CLp7Mxkz Dq5RX0Wq+k0gjA6o1ccZVoIDqC11A8AmhoCuwrSdTJhp5bPrfLhytOEJ5/wnC10Ep7l6 eqI9mkbNam/yd8w7+5PMX5bv+VBoYmtc4W3IwPpdTAwVBjx5Kb3kq2RxzduJrWJ9046t xa7q/KDw4X+tiG7B22PAnWJeX4J1nLgTBqblSNzDACzFpO5b2+g32+1nyKQI0Q6Dqy14 EaBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779786809; x=1780391609; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YbTEfLFWlj213t5VNtgTRv1qDlCZyoJalSTQ1GEGHb4=; b=oRsRsOBrFpMmhFReReXBqGLncsgs8gL7nXNbMd/YQrsnik/FZtr0F/DYsBv4+On/NX Gn1m6RTIfZcuCwEg+KaThLCI/GGTKlRlc0liX+XnNYj49Ook8UOH6DfmeW46QgbC1V/s 8UPEN2EADmnNK7IbmD7DKZ4LPERJMFaHHT6lIIiuE8QRSUIin3HNqlbxSDYGSF/pEoxc DDBoSgTX+NGjlj1oitIQh+wzYRQqOz1TSwBq8Bk8utsmqdjO4j/5F3lIiIePCUuahcnK sLbmjGz61ARS+3Y2PocMQSH7uCp4dWcJuPPHJbgkOENhtdZbV1fuGvEyYVDBHjH4zNIf 0cIg== X-Forwarded-Encrypted: i=1; AFNElJ9U+4o52yw+mTy5LT+ZV53yJ+PqiJ4EIz54kbViyn1ONNkXOE5qx3KsiDPYtbAYQr/QJ1Q9ZCnAigB1g78=@vger.kernel.org X-Gm-Message-State: AOJu0YwP4wXkQhMOlz9Nkf/3JIcCtP4Egir8m2Twkyx/te8pGGLPxqEF 0HtnHXy8mgZWUloosawN8s7vhn0KH3GQK2MAmbp9sSkky3sHe2Lq7zIaQdg7Ztd9dXs= X-Gm-Gg: Acq92OEG4WiZ3Qn7LeMFVzaH+8hF0DgRVu62Qw636Zf/XleFlWN5qWlEbew+vvayZkn z6QSB+7vLw7KgsatDpu2STflxybW1hilV2Ye5ESTs+LVL6iotgCB/h0uItNUhIPA6gdVzhKWfJL RVXV6PtVFqgZtdd6fHV+wowoyGlzNANsHVWKXD4kKm4v88O94rXZNzDa3d8F+qx0LDTPET/Z+kU 0VKAG4h2/UoF2K9GB3OJUXxxX1SAm5Hyy09ZyKMSmCsSWjXrFlDkC7rYrtyd7KVdclNUh4ZHRwB 88aS4BvbAHA8gCqjtUo1QHt6/dkkjlm9Km47HunVsbZ+GelBqnRm376X2GJn69IeGOHLekmprhy i9kuO+Yf+Oc5SrIZX5FR4wIkcVrNd6pZxt3YNWNJ+aLLCLo2Wce4LHyLCLS2QruLlbttPNDc9pw 4Xz+Ei9n5TpjEVocQVQnbl2AsW0g== X-Received: by 2002:a05:600c:3541:b0:490:6e12:542c with SMTP id 5b1f17b1804b1-4906e125469mr77110415e9.23.1779786809077; Tue, 26 May 2026 02:13:29 -0700 (PDT) Received: from pathway.suse.cz ([176.114.240.130]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45eb6c9de2dsm32566273f8f.4.2026.05.26.02.13.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 May 2026 02:13:28 -0700 (PDT) Date: Tue, 26 May 2026 11:13:27 +0200 From: Petr Mladek To: Kaitao Cheng Cc: akpm@linux-foundation.org, rostedt@goodmis.org, andriy.shevchenko@linux.intel.com, linux@rasmusvillemoes.dk, senozhatsky@chromium.org, linux-kernel@vger.kernel.org, Kaitao Cheng Subject: Re: [PATCH] lib/vsprintf: Require exact hash_pointers mode matches Message-ID: References: <20260519130117.48097-1-kaitao.cheng@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260519130117.48097-1-kaitao.cheng@linux.dev> On Tue 2026-05-19 21:01:17, Kaitao Cheng wrote: > From: Kaitao Cheng > > hash_pointers= accepts a small set of mode strings, but the parser uses > strncmp() with the length of each valid mode. That accepts values with > trailing garbage, such as hash_pointers=autobots or > hash_pointers=nevermind, as valid aliases for auto and never. > > Use strcmp() so that only the documented mode strings are accepted. > Invalid values will continue to fall back to auto through the existing > unknown-mode path. > > Signed-off-by: Kaitao Cheng JFYI, the patch has been committed into printk/linux.git, branch for-7.2. Best Regards, Petr