From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 633A23DA7EE
	for <linux-kernel@vger.kernel.org>; Tue, 26 May 2026 14:41:06 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1779806468; cv=none; b=J1QCLLJ5saSwaKKaB8dWn7n9iTsf8VO5/TcFHZpl31NxBaRee0gj5RY1KDrKHdV3ZzQTfIwAsjfUZf+5S+5vSzd3c+Mr+qG2WWUE5df7qAlWf23qExkFkKI+2DG97wk2BJ6ki5JgXR51cg4wbKSFAXy/ydnExqIipeSi8UuB4A0=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1779806468; c=relaxed/simple;
	bh=YURtTwNhC/DnylKar0vYZXnYU6Ai0Pcuggo1KWGJtA0=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=SfzHfwXWdNcpBG/aDcdf58xevjIwEkyEj7frwId7jIKK9XYgaG1qGeDPis3/S7lFYN0tN5ON1o6LiNei+fKwVMG/153vwl9zzXN9OeK4DjmoZWnTAzOPZ8q6KhfNIpJNQdEdDsVLGBtXYdXyFuH15/Cc7RQ75/PtTyP/3UI68wM=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=RiKBGIsr; arc=none smtp.client-ip=100.103.45.18
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="RiKBGIsr"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 51F831F000E9;
	Tue, 26 May 2026 14:41:05 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org;
	s=k20260515; t=1779806465;
	bh=S8xGth6pf7eNo2Xwd+YtTPggqwpp7m9sBjiE/SxNsWk=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To;
	b=RiKBGIsrg4KJJw1rHb/phZ9i0CZ9Gf/1NuDQeoB13nOIcuXtdIvGu2WhWEGN9uJUS
	 lw3bNczQmA8zPq62UzQZtgv3UtYMeURL4SeKxaWrJT9Fn3Mvl8fS2fGrqWx3eY6XjE
	 +tiEWpOzpadaxjjAK6iRjgCr3JhvcWnnCZ5Imlp7sZExzfeJG8rGuRdMmTUn8Rl+FJ
	 a42ts5WafeDok2lGC6HV4b7+6Ojd20bmiPxi5XAZYsN6x/H9fK9o5vU29jN13XqfGR
	 7SYZtcx9RBsQu75/52ry/QEDXQZ2uT1fCQ5l+2wrXe1J/7glB7qY9/MOm2LnrCcPLz
	 3Y+jckOPPoSKQ==
Date: Tue, 26 May 2026 08:41:03 -0600
From: Keith Busch <kbusch@kernel.org>
To: liuxixin <gliuxen@gmail.com>
Cc: linux-nvme@lists.infradead.org, axboe@kernel.dk, hch@lst.de,
	sagi@grimberg.me, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/1] nvme: fix FDP configuration log parsing
Message-ID: <ahWw_09BJkQi9zQe@kbusch-mbp>
References: <177978195864.4106423.11658267582906445997@gmail.com>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <177978195864.4106423.11658267582906445997@gmail.com>

On Tue, May 26, 2026 at 03:52:38PM +0800, liuxixin wrote:
> @@ -2262,10 +2263,10 @@ static int nvme_query_fdp_granularity(struct nvme_ctrl *ctrl,
>  		goto out;
>  	}
>  
> -	n = le16_to_cpu(h->numfdpc) + 1;
> -	if (fdp_idx > n) {
> +	numfdpc = le16_to_cpu(h->numfdpc);
> +	if (fdp_idx > numfdpc) {

Can't this be fixed with just a simpler one-line change:

+	if (fdp_idx >= n) {