From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 321DC22D7B5 for ; Wed, 3 Jun 2026 06:47:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.17 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780469233; cv=none; b=BQPTYu6UreWQibNq95n6H6GUpCDSMIACEXXPZKa1ouv4CPHLGUnCEPZss0TfSApHuZ7PuBboWqbLI0M1WZo9c/f3s5AzEBZEY8is+QEo9YHW3qI6zmY9JxdHKVHEDtu6S3IfWMQcXJB3J8vrgH6WX7bWGteg4Y1Dl5sis6gMNug= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780469233; c=relaxed/simple; bh=jyZkhlBYg/KvnRv/whaTOJ1M/1Jmowiq9pVxSFYpuPw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Soaa+MeaYtJ2ucevRWa4/smMebT8Z6Bn6TJVemBdzoizKas6Fx05LmrykhkIIBZkLiIqtp0yHVpNcQE3zqY4HRMd9Lz0bqeBe07E6hxOIISCpj3os7uTlHADCv5V9H6uhEZPIOm6FhRHtZtVQ8/jidGuMejjo20ARD7jiLq80GU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=QgFBEOpJ; arc=none smtp.client-ip=198.175.65.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="QgFBEOpJ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1780469232; x=1812005232; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=jyZkhlBYg/KvnRv/whaTOJ1M/1Jmowiq9pVxSFYpuPw=; b=QgFBEOpJYxdRAnauZZ1oEvhaPYPP7CkJx0ECPcRehcZd+Xh/+63PPzEV IzaCGUKsCNMWenF9kObNiEYmJ8F/7t3N2LqXLjr/imlx76W8ZtvSg8yC4 unmHlnw1suY7kPHNBcfpZyOPuZ0UyzQq5hUuRRff9YLfESSchKrqbPAsG lRmy4u8LTfYlQecFT0TZKe8GeBidSSu67ERXmx9OW/nyhIgOZ41+qpFIp GP1vha3fDkxPsC+ABjKE5UT51ViMqLKGVqGCTovAa0vKkRF1BDMJujwEL 5YJeOUWoTdy1kuPPaMNamCH6JKT6TIzS/kovD0cNnxfHFCvtdAYiHruam w==; X-CSE-ConnectionGUID: yehAYG5rSImeA65awp0pgw== X-CSE-MsgGUID: 5kTCdBISS5C3fWXjzeEFUw== X-IronPort-AV: E=McAfee;i="6800,10657,11805"; a="81263198" X-IronPort-AV: E=Sophos;i="6.24,184,1774335600"; d="scan'208";a="81263198" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jun 2026 23:47:12 -0700 X-CSE-ConnectionGUID: WjPibeZXQEiu0g+DNyfLXw== X-CSE-MsgGUID: Q/r5kTlfRoq2brf/rhxiEQ== X-ExtLoop1: 1 Received: from pgcooper-mobl3.ger.corp.intel.com (HELO localhost) ([10.245.244.116]) by fmviesa003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jun 2026 23:47:09 -0700 Date: Wed, 3 Jun 2026 09:47:06 +0300 From: Andy Shevchenko To: Dmitry Antipov , Petr Mladek , linux-kernel@vger.kernel.org Cc: Andrew Morton , Steven Rostedt , Rasmus Villemoes , Sergey Senozhatsky , rodrigo.alencar@analog.com, dlechner@baylibre.com, jic23@kernel.org Subject: Re: [PATCH v1 1/2] kstrtox: Make _parse_integer() take variadic arguments Message-ID: References: <20260602203706.103449-1-andriy.shevchenko@linux.intel.com> <20260602203706.103449-2-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260602203706.103449-2-andriy.shevchenko@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Tue, Jun 02, 2026 at 10:29:46PM +0200, Andy Shevchenko wrote: > Instead of having different functions that just use default parameters, > combine those to use variadic arguments, so the user may call it using > the same name. ... Maybe we also need to add a comment here /* Do NOT call this directly, use _parse_integer() wrapper instead */ > unsigned int _parse_integer_limit(const char *s, unsigned int base, unsigned long long *res, > size_t max_chars); ... Overall I think independently on the new user (if it comes or not) this change is good on itself. Petr, what do you think about this? -- With Best Regards, Andy Shevchenko