mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Miguel Vadillo <miguel.vadillo@intel.com>, rafael@kernel.org
Cc: linux-acpi@vger.kernel.org, lenb@kernel.org,
	linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
	mehdi.djait@linux.intel.com, wei.a.xu@intel.com,
	atul.raut@intel.com
Subject: Re: [PATCH] ACPI: scan: Honor _DEP for Intel CVS devices
Date: Wed, 3 Jun 2026 10:43:17 +0300	[thread overview]
Message-ID: <ah_bFVtDCzWPeE4z@kekkonen.localdomain> (raw)
In-Reply-To: <20260601194040.18223-1-miguel.vadillo@intel.com>

Hi Miguel, Rafael,

Thanks for the patch.

On Mon, Jun 01, 2026 at 12:40:40PM -0700, Miguel Vadillo wrote:
> CVS (Computer Vision Sensing) is an ACPI-enumerated device that sits
> inline in the CSI-2 path between the camera sensor and Intel IPU.
> On platforms where CVS is present, the camera sensor's ACPI node
> declares a _DEP dependency on the CVS device.
> 
> The CVS driver must be fully initialized before camera sensor drivers
> probe, because CVS controls the CSI-2 link ownership handshake (via
> GPIO REQ/RESP), the MIPI/CSI-2 lane configuration, and the camera
> power domain. Without CVS ready, the sensor driver can bind but the
> CSI-2 stream will not function correctly.
> 
> The CVS driver calls acpi_dev_clear_dependencies() at the end of its
> probe() to unblock waiting consumers once it is ready.
> 
> Move the CVS HIDs from acpi_ignore_dep_ids[] to acpi_honor_dep_ids[]
> so that camera sensor enumeration is deferred until the CVS driver has
> finished probing, matching the behavior already in place for IVSC.
> 
> Signed-off-by: Miguel Vadillo <miguel.vadillo@intel.com>

Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>

Rafael: do you think this could still make it to 7.2? Otherwise cameras
might not work on a some laptops where they did use to.

The default configuration is appropriate in some laptops so camera used to
work without the CVS driver but now that we have the CVS driver merged and
the CVS device is part of the software node / ACPI graph, probing the
camera sensor driver will in fact not take place at all (and obviously the
camera won't work in this case).

-- 
Kind regards,

Sakari Ailus

  reply	other threads:[~2026-06-03  7:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-01 19:40 Miguel Vadillo
2026-06-03  7:43 ` Sakari Ailus [this message]
2026-06-08 12:21   ` Rafael J. Wysocki
2026-09-12 16:50 ` Thorsten Leemhuis
2026-09-13  8:27   ` Thorsten Leemhuis
2026-09-13 10:38     ` Rafael J. Wysocki (Intel)
2026-09-13 20:21     ` Sakari Ailus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ah_bFVtDCzWPeE4z@kekkonen.localdomain \
    --to=sakari.ailus@linux.intel.com \
    --cc=atul.raut@intel.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mehdi.djait@linux.intel.com \
    --cc=miguel.vadillo@intel.com \
    --cc=rafael@kernel.org \
    --cc=wei.a.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®