From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from AM0PR02CU008.outbound.protection.outlook.com (mail-westeuropeazon11013063.outbound.protection.outlook.com [52.101.72.63]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CCDCD402453; Wed, 3 Jun 2026 08:59:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.72.63 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780477168; cv=fail; b=sZrS0UlJ84OqaY/WsAsU0SAIEYOUEqL6wcUhIFaEgyoM6XAVxC2845pms7zfhQ44XCtBxCSyJa3ziXN5g6JlxwI4P8mAqKQ69VxkE3VR56oMJXnD7HKsf2l8IIcSxm3+UvjWX7vnbwbgg8ELkq9b+wLUgUSJHCO7eA8vNa9ch4Y= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780477168; c=relaxed/simple; bh=IchDvtYrp0m86h01VfnpL32/4pgNfS6dv9Uk5IdAmfM=; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GMva2zBAWLc5I7ARHoiTgcGPxuoXXXw/3PSH0/1K/EGVYPKcHOLevLaCdByrv7ZNBpIWKM7Ij8aGLLuQ3WYustnZ5crh1CINudwy6lZ+I2gyxtDE+4rWQPi3axl6vGdEl8tR2Ac7ROSOAqiVKctGjfgsztJpbK6Ez1U1PEXdTwU= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com; spf=pass smtp.mailfrom=foss.st.com; dkim=fail (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b=j9iFMqQP reason="signature verification failed"; arc=fail smtp.client-ip=52.101.72.63 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=foss.st.com Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b="j9iFMqQP" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=tPeKAqFQcl1aIHO6wj+OwXyXflCFarURAuPz72jOUbP+0jdxntW3JUyP4JSpoAjq0UVpYFSF6TeTGXhxjbxhbBmUNq8Iucvohs+bKn4ODyDCI9+AzrOVyo/vLgHy5MSe9g5sBOn1+ZcSAIdeVY1AAX7OQcXmW4tZjpnLU7zGnJ5Z2/RlMS5KavOmH7PEbi+2idxUFfLm4nHyL2I/mhkTZY/2nkHEb3bCpfu8ZpLRDFjEIIL4qjXBxCbo9/S0HbrlA7m+9rWRrW2P+8/F9NqrUW6jLFOWbYdTYIB73zs00LAoa7P+xOWRDhQxgb9SpEX6Du4iwVvTD8bmRVDXKEkFbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HNOTBXCN38+2RyNzrO3uBkD4t8BJgScnmbAFK79Q7+U=; b=eFXmqRyZMLszBUXYT2KsdNfJyNvInwte7r0wuWsZOkTT8lxSwNE4hKMUoCwaTWe02EKr8iu1bTxsCF6Wz5fSVMcXB5l/PRt2swYtKtJn31zfvPPvF/WcBMIiq6cpbGk/RoyWnxlEwQUILQzeYCH048RfVL8nOXpxI04t3kK31mNIT+uFXC0+eil9iqyZtyXUO+/fml4bNcHhaO5m4ZAmCbVovd7kgA53sAK9zJyH27b6zqOw9lUCzWyhXDbAHeeyKLJpv51+eUu8FWnqBG5OeiwaP7o1GhHP86wornl806PNsOC6BGYaDJoOAK/iffsk36MzJ+Ez3SrREPzGWQhW5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 164.130.1.60) smtp.rcpttodomain=gmail.com smtp.mailfrom=foss.st.com; dmarc=fail (p=none sp=none pct=100) action=none header.from=foss.st.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HNOTBXCN38+2RyNzrO3uBkD4t8BJgScnmbAFK79Q7+U=; b=j9iFMqQPsNB0l80jONKDwQOwaCFs6bLh5Szn3mKVDZjxSUJLXMPKr1TG7rpE2y0//kim65WChUy7iUhOgXbWIQvUsbIgUdAnSZG4Ub92Lch/qrfQSoLUl1SGJSYxKagSvcTy3VH9ZYrbVlUVC0vSdcqUa50zfe8aj3Qjvz2huKtVErMN70BYYcU18c0yyYhqUg6txiF6+/RtnPHV99tlPzYolgtDs+3dU5wsg1ErwhZAMqMZcpOZNMjEP8OnbpOeiQeHcsW34oaLNATKInHlgZlbpsqksTsS2jo3K7Qod1b8hpYJxSaLGib7fUb1MvBti9TRdEKD5l2clAu/Fu0JTw== Received: from AM4PR0302CA0028.eurprd03.prod.outlook.com (2603:10a6:205:2::41) by AM4PR10MB9404.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:6cf::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.92.7; Wed, 3 Jun 2026 08:59:22 +0000 Received: from AM3PEPF0000A78D.eurprd04.prod.outlook.com (2603:10a6:205:2:cafe::19) by AM4PR0302CA0028.outlook.office365.com (2603:10a6:205:2::41) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.92.7 via Frontend Transport; Wed, 3 Jun 2026 08:59:22 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 164.130.1.60) smtp.mailfrom=foss.st.com; dkim=none (message not signed) header.d=none;dmarc=fail action=none header.from=foss.st.com; Received-SPF: Fail (protection.outlook.com: domain of foss.st.com does not designate 164.130.1.60 as permitted sender) receiver=protection.outlook.com; client-ip=164.130.1.60; helo=smtpO365.st.com; Received: from smtpO365.st.com (164.130.1.60) by AM3PEPF0000A78D.mail.protection.outlook.com (10.167.16.116) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.92.5 via Frontend Transport; Wed, 3 Jun 2026 08:59:22 +0000 Received: from STKDAG1NODE2.st.com (10.75.128.133) by smtpO365.st.com (10.250.44.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.35; Wed, 3 Jun 2026 11:03:06 +0200 Received: from gnbcxd0016.gnb.st.com (10.130.77.119) by STKDAG1NODE2.st.com (10.75.128.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.35; Wed, 3 Jun 2026 10:59:21 +0200 Date: Wed, 3 Jun 2026 10:59:14 +0200 From: Alain Volmat To: Guillermo =?iso-8859-1?Q?Rodr=EDguez?= CC: Pierre-Yves MORDRET , Andi Shyti , Maxime Coquelin , Alexandre Torgue , Wolfram Sang , , , , Subject: Re: [PATCH] i2c: stm32f7: fix timing computation ignoring i2c-analog-filter Message-ID: References: <20260526091210.20383-1-guille.rodriguez@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260526091210.20383-1-guille.rodriguez@gmail.com> X-Disclaimer: ce message est personnel / this message is private X-ClientProxiedBy: ENXCAS1NODE2.st.com (10.75.128.138) To STKDAG1NODE2.st.com (10.75.128.133) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM3PEPF0000A78D:EE_|AM4PR10MB9404:EE_ X-MS-Office365-Filtering-Correlation-Id: 12200be5-17c5-4e70-c7a4-08dec14e67c8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|36860700016|376014|56012099006|18002099003|22082099003|11063799006; X-Microsoft-Antispam-Message-Info: DrO0UUcR1bC14SVQLHbI6luo3TowYdUO/oOmSAnE1MEcP4j+7aH+PanoyiIHF8JFlvtBEIJVMa3Z+FQy4tJRQaWTJXUyOs2+HhjVAp8Og/gBfCyy1S1JzU+hi+EtI0VNv4PJ1zGQExAXH3E9OH0nTXi8Te12zADCNxtP23mpLMEzapvkQ+ei6MpYpPNm0q6YOipHUdCPDxOXxMzlxci+IZnJwIVq4EYr9X0EyGMLBl5eLmEFkrXlfM3IZSs/91faa6LsnuhjGayBLmRzIV2OBdSDGXnBUJMCY+EI5DHhIcWkVOdMOzo9zU/sB15VHNWWiT6y+mYqB71MpWs8m7phIQs+h3hEBBLTT7Sxv4SZZ39h9QXRfHRV9zhC+Qpdar2MdPGMLSTcCJ2AGDr4xFKG1IPtCboYi/WIRSfd4FepsRwQOm2O2/2pEDpCeKMSlYCGlCf9VwnFA7+5EgTcJPPDYvonEBiwfsR25DPEhqkgjLP3voKZVRJQy+plfJ5BgP9iDJLVlKOOiM2vdn3cmse3h2B0LgSJzuWrk6kB5eZo8vlMwIH7JHpYfvYM88pPFMfOPR46xJ+UMKcBMMOo3w9SrxLHzY/rLuUl2AAhqfprjWvlCRw4HeCUgBHqkccYsTFlediszAtX472538JDX00CODtV/HXG/gOBQd2fNwmQ+uZR24j3mImasVTP7k2rFFU874UBFBN6ptQk/+Y+c8NWZD2kaqvn97NaoasECSF0uVk= X-Forefront-Antispam-Report: CIP:164.130.1.60;CTRY:IT;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:smtpO365.st.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(36860700016)(376014)(56012099006)(18002099003)(22082099003)(11063799006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: zbtgNgEfWf99Dfem7x7TpZ0stoX6luZOr7uCU9qMjLI/u5QxC4/Dk3WPpOu0HHXBNmfMm6KfWb/qZEibzX+rYw0dAn5IImXpeBkwPPdH046SWrjOqq5NWuBKIU9oElZMYl7Zy1v4zaBsgddNHRtFjbBkbq26hVhCZcQkVHhUNRIfIhAMXkC1NYpciDAcok8D7oxiREA/JyzfoRhigXgK5VkjK1MAYROCGS/yivala69S7adeQH635tA7c+sqqTXKrTcspXlnl134gh7avzbHRSpyiNZd/BpvEumHTawQJEbKnYUqM5Jn/DOzk0vCLAq1/KTe/FIUHgM26nUzJyv4WBq3ETj3mMSJZZjV77sWYwCfwZmv22ddwsjOSM6EMm8Y2mttHp7zTSM4wZG6pAiHaB1Ev7ocxEjkmIaE6ZevHDq6Dr/vD6j0yN1KaQbwBCES X-OriginatorOrg: foss.st.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jun 2026 08:59:22.5095 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 12200be5-17c5-4e70-c7a4-08dec14e67c8 X-MS-Exchange-CrossTenant-Id: 75e027c9-20d5-47d5-b82f-77d7cd041e8f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=75e027c9-20d5-47d5-b82f-77d7cd041e8f;Ip=[164.130.1.60];Helo=[smtpO365.st.com] X-MS-Exchange-CrossTenant-AuthSource: AM3PEPF0000A78D.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR10MB9404 Hi, thank you for you patch. On Tue, May 26, 2026 at 11:12:09AM +0200, Guillermo Rodríguez wrote: > stm32f7_i2c_compute_timing() uses i2c_dev->analog_filter to pick > the analog filter delay, but i2c_dev->analog_filter is parsed from > the "i2c-analog-filter" DT property only after the compute_timing > loop in stm32f7_i2c_setup_timing(), so in practice the timing > calculations always ignore the analog filter. On an STM32MP1 board > with clock-frequency = <400000> and i2c-analog-filter set, measured > SCL frequency was ~382 kHz. > > This also affects (widens) the computed SDADEL range. At high bus > clock speeds, this can select an SDADEL value that violates tVD;DAT > (data valid time). > > Fix by parsing "i2c-analog-filter" before the compute_timing loop. > > Fixes: 83c3408f7b9c ("i2c: stm32f7: support DT binding i2c-analog-filter") > Cc: stable@vger.kernel.org > Signed-off-by: Guillermo Rodríguez > --- > drivers/i2c/busses/i2c-stm32f7.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c > index 53d9df70ebe4..067af255bd22 100644 > --- a/drivers/i2c/busses/i2c-stm32f7.c > +++ b/drivers/i2c/busses/i2c-stm32f7.c > @@ -694,6 +694,9 @@ static int stm32f7_i2c_setup_timing(struct stm32f7_i2c_dev *i2c_dev, > if (!of_property_read_bool(i2c_dev->dev->of_node, "i2c-digital-filter")) > i2c_dev->dnf_dt = STM32F7_I2C_DNF_DEFAULT; > > + i2c_dev->analog_filter = of_property_read_bool(i2c_dev->dev->of_node, > + "i2c-analog-filter"); > + > do { > ret = stm32f7_i2c_compute_timing(i2c_dev, setup, > &i2c_dev->timing); > @@ -715,9 +718,6 @@ static int stm32f7_i2c_setup_timing(struct stm32f7_i2c_dev *i2c_dev, > return ret; > } > > - i2c_dev->analog_filter = of_property_read_bool(i2c_dev->dev->of_node, > - "i2c-analog-filter"); > - > dev_dbg(i2c_dev->dev, "I2C Speed(%i), Clk Source(%i)\n", > setup->speed_freq, setup->clock_src); > dev_dbg(i2c_dev->dev, "I2C Rise(%i) and Fall(%i) Time\n", > -- > 2.25.1 > Acked-by: Alain Volmat Regards, Alain