From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41C3E2236E3; Wed, 27 May 2026 05:49:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=198.175.65.15 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779860945; cv=fail; b=VCXq1n7I+NTQjKY0dAF90K2AmoB6+EaQ3CLzb0QxoIXoawDt69Smy1dupxGpF49wAJTURp7oLvd0PU36wheQ9nE6+LCBn9PnymfZhEhTZtTJfTXvaS6bkJwKPArCHEVG1F9N3cXm+sZuipcPJU6SpU4wq3TkX3q7omBZcXVHvjs= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779860945; c=relaxed/simple; bh=xlNh76EZVKEtc671Tz4130A+keyV0JfRrbVzUKXKpfs=; h=Date:From:To:CC:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=kZI9IqlyxJntpGR7sMYp0dqxv9j42L2u2w2JIIo3m34RRR3EShUd/lXPXxz1PmGmceY88377OqkPmPjNe2FrqQZD/vvLu/fwBmy6umxuZMlXjv+6pTLBIX9V2Q3MkZy20E4ROEB9H1iTQWZiYDWmRnwbBxg55lFTU28oLmcD2Qk= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=EWBFShnL; arc=fail smtp.client-ip=198.175.65.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="EWBFShnL" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1779860944; x=1811396944; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=xlNh76EZVKEtc671Tz4130A+keyV0JfRrbVzUKXKpfs=; b=EWBFShnLmEfO0I5NhQQ10qEURo2Kpgnpe0Jf7joeQf7OQNTd7DVmbaTN Fq8Meub85waK6oDdX66pcH1XKeGX90xLF8A/0wMyC93+d5ijV3Hw3+snb 8tehLqLEcR8mT3LgZMc9cYgA5gLixsQLHvIPrPZOJAgsaThQItDpZnY52 F3o6rl4KCkcfv4B5mmxFfa0c+GtFDNA/fP6q6wNjdTAduKBpqS+F7GBA3 Bv2I3fE61F5f2vQLBgTGTjYjlQqHbvWiekMBucHyJbXs9VowNQsBjIEzS DCd315uASps1KHcTmB7ptZKGHN7yp4LZScx5cBcs3fb1stgMNQ41I+pdu g==; X-CSE-ConnectionGUID: yLH8hXOxS1alrWq1mbvhIQ== X-CSE-MsgGUID: 07Y5a3x7SE+vhbpT25HR9Q== X-IronPort-AV: E=McAfee;i="6800,10657,11798"; a="84307907" X-IronPort-AV: E=Sophos;i="6.24,170,1774335600"; d="scan'208";a="84307907" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 May 2026 22:49:03 -0700 X-CSE-ConnectionGUID: IkwCqjeQR9yOq1oK522Msw== X-CSE-MsgGUID: PcF6jF0RT1uRjmPQLoH0nw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,170,1774335600"; d="scan'208";a="241308201" Received: from orsmsx901.amr.corp.intel.com ([10.22.229.23]) by orviesa010.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 May 2026 22:49:01 -0700 Received: from ORSMSX903.amr.corp.intel.com (10.22.229.25) by ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Tue, 26 May 2026 22:49:02 -0700 Received: from ORSEDG903.ED.cps.intel.com (10.7.248.13) by ORSMSX903.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37 via Frontend Transport; Tue, 26 May 2026 22:49:02 -0700 Received: from DM5PR21CU001.outbound.protection.outlook.com (52.101.62.6) by edgegateway.intel.com (134.134.137.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Tue, 26 May 2026 22:49:01 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=OjrTzcNOyqT8flpylpaBmp6TDMUVYtGF0IJaj9laPBPo2wmsFqZltL9nATeAFDKL/+nDVOrXbj2PtpxuZAI1i6+55+pmrWXozVMFqHyBj0pwHAOfrtHLvKQ6DjzZF6WI1YKB3308N1iKPA8iF5/1fDGppNpgI8xrkGhGU8cLV+H1yAM21R7dCPaKkRs8mWLftKGrHubU6BlAQnYC9lXqJlDkpNl/uO/9rlP0zWbZ2Ma50e5sFKnABBJRgmZ+eAxAeLO/lLdXLYb6/irRP2EtpoI4vu2THbKIh973jbPerggjz+02++x7ORTAQ6LC/T28hiVmbshn2a70TbDtVN6Yow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZJaW/ech9WJNQ9I+/nVIMX3+ly5bwolCKM57gH+k6jw=; b=sm1y4Q95qWDr/c/jJmPMGNQ0DN3TQ0HahzJKYyR4ziBVqnnTrsMFRgD+EWWNR0jchDu8pE+ywrHigUgVf9MtvI/Si6a29LCvzr8cZL2h6XBe/+2iIfyb0k0dC/mYnDNIBUOFK5viHIhGpMjv4HcEuqk7ZW57w68HgRLCOx5OcvMG5c2A1WtI2ck2li80kfnzNudkXX3GSJxKDwQ3aS7+5E2c5HfHxqtnulORZGePz6bOHFsj9Y+UEp8H2fCUtkpLr2twJb/O2D9SIjKDro5SiDvFNPICUiiyhQHnXSSBxwl2NH/eZdzCHKOcGaHjXLgGipZlepmu6uo6Y9Y1jq+NOA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS4PPF0BAC23327.namprd11.prod.outlook.com (2603:10b6:f:fc02::9) by CO1PR11MB5139.namprd11.prod.outlook.com (2603:10b6:303:95::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.71.11; Wed, 27 May 2026 05:48:59 +0000 Received: from DS4PPF0BAC23327.namprd11.prod.outlook.com ([fe80::a195:49d4:38c5:3891]) by DS4PPF0BAC23327.namprd11.prod.outlook.com ([fe80::a195:49d4:38c5:3891%4]) with mapi id 15.21.0071.010; Wed, 27 May 2026 05:48:59 +0000 Date: Tue, 26 May 2026 22:48:55 -0700 From: Alison Schofield To: Richard Cheng CC: , , , , , , , , , , , , , , Subject: Re: [PATCH v3] cxl/test: Enforce PMD alignment for volatile mock regions Message-ID: References: <20260522054457.5429-1-icheng@nvidia.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: SJ0PR13CA0084.namprd13.prod.outlook.com (2603:10b6:a03:2c4::29) To DS4PPF0BAC23327.namprd11.prod.outlook.com (2603:10b6:f:fc02::9) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS4PPF0BAC23327:EE_|CO1PR11MB5139:EE_ X-MS-Office365-Filtering-Correlation-Id: 8e9c6342-95e7-40ed-d48d-08debbb3a604 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|7416014|18002099003|22082099003|11063799006|6133799003|4143699003|3023799007|56012099006; X-Microsoft-Antispam-Message-Info: 66uDxLEvVIJhvwbSDsm56fgJK9aJyTLOn75eWITxlZX/bm4KoyZbll2YeIasSzF8qyl8TVSYiG/s81Y4Y+I13hTrFJ9LyAtK6itb0wXYuXdxcQE23JKf2gUKMAYRJbkSHWKCLf9p8yYy/svuIk1WkqaezBnHQf+YFPllfG3XN0r+r36yM46NiSOtUSEkAqCNIRUgi6JYfjh7Jd+Z/lGoRP2XU4JIfqroexxwyHu22tRst58Rx9GKb5b2rOvhVkmSeSvKjdUzWzpxg5x8RawUFfUsrj5T6qPz3wjILIWcfU5byIFRouJWS2s2jOHL/qasG87VaH7RMkY7evBmufpMgcV0fdRjdDhXljOziGKYwa+2BfQbYLB4uPEUVIEaC37BgTFMqbJBOAWxIKv32ZcwtZdSyZ2GjKv108eO3oh8S/Eng35mh6C+sWUYyWwEWMDYiqmzwEeuY8zNS6ltdhhf73Y0jkR72bhyqeCDXdozpwCQX1tVTNVqCRB2BR5fOuoriHP67Zv5HUDKax1x8jbjBjWH71I0v0+BWgMOUgxwnKfRqUxDySMIuwjyxRP0A+uMALvqoY93jyQ/OuDYJ/primWXxxmsZiC221dzwSDxUMvOAJ9po2KDPs1ncTIWQ2TkwfnPSRsQQUGpF4XjZvUhcepsctwMYcM9sDU7oUPnA1XjOnRnfX70ZMwVAT72Abxc X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS4PPF0BAC23327.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(7416014)(18002099003)(22082099003)(11063799006)(6133799003)(4143699003)(3023799007)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vpK63wPd2OPXE3Ahgsjf0yVRpOKlEUxGqm20MjFO6Wmo7PrJo4zj9aJBFkyE?= =?us-ascii?Q?uLundqEGfBqtZsqrvrlc6eDHUa60o1kZw74h4QDzIGtFMVu7QsI1rLEatNax?= =?us-ascii?Q?+AZS6OXMU0KkHCrfajlKexaKYj5fGCG9HAsd0o8M0Whq048q4LFovKsHtHgr?= =?us-ascii?Q?iFWFz+tmYVJUxtZYYxjY3Q9JtWfpI3ddjtLWH/rdj9qEqUMOLCAgBVSwmuXw?= =?us-ascii?Q?Y7x5kww49rUwFsm2G8TJHhgP1rXAbmbqkG+iP1svnpGwZb7YcpOXH4mIyWA/?= =?us-ascii?Q?0QfS2Bm8mweK5rSLza4Ohx8aFDD+muUp5SR3LrNrRWWD2gXtAD2kfVgoxpZ+?= =?us-ascii?Q?dm7undDpL7GD7Aypqlc2xW+5ng5ygknnPYl7DPzIz++RFscg7sRhMbRkFdlO?= =?us-ascii?Q?ac3iGK8tHu/dHmZaHRZwqaTONODPD29jqxRZ4EyFpa0MVmCSOMro5xIQGHH8?= =?us-ascii?Q?rpNMujv+CDvTwQd9CJOobhHZli47lX4DM9di0irDpynW5f/qbTsT3+042YEl?= =?us-ascii?Q?0RVR7KhaP6SQ2GLtKpZanKRA2Nq+L6U3Wvfvd6If6JKteT2F30PO3DtBj/8x?= =?us-ascii?Q?RqBnq6p4B/po6EOrteN2IcF7P8a13QVdf49LgrYhI8qF2kaS6+xQhPOK8Xmc?= =?us-ascii?Q?Da9MmxfnJYlk9AHsaQ4pjTwnDZDndfalJ278trXWHLG43KcyamBXZQn2cb3p?= =?us-ascii?Q?Qt4ZRA1dCc7xtAvaycl1NSTNAGw7LjqWLyYHHES3DRdipZoGw9c8LOiqYHhJ?= =?us-ascii?Q?/TfbE4Qw9DbZoX10l0uuFZA/MAfNy1hurWaAC1GwwZqmwbAvKXfEYZwqNqit?= =?us-ascii?Q?mQ7jtE7yJgqlCJmtnNAw/MJw/qvU29zFZgtCGyXyT6iq3d7C1HFCYkRm1zfa?= =?us-ascii?Q?oYptfIU1c47pj3Jj3bNKjKme88pG4JOxuLvhYUAW/oSvnLdXo3OuwOaTblae?= =?us-ascii?Q?aEOdk8P4cSKIJw2uOn7S9zl+G5PsRlEPpS3sAgUv6x9TxWltgM5xlG+c8xMk?= =?us-ascii?Q?BSVHdY7/lLxbz6bNYM1yUaLP+ERpvYa3NHttApsTRVoifost1hwk9e6khPj7?= =?us-ascii?Q?ZqCNtDKMSNIxzqV/FGLuXNFqTIeptxsTRZ9CtJ1dpNn1jQW8tOb0n7Q3jGI5?= =?us-ascii?Q?uYoQTHqJ0UGfI4w6IBjg3M1FpKsw0RZuRK6FlrlaS5Yp7uhBTne+rQOs0cES?= =?us-ascii?Q?mqM/lJcfupsQFt7KN+/uLYwWxl5Wt9/iI+X0UMbkT96gTXL86DRS0wLGdZsC?= =?us-ascii?Q?rcIhtw4bMQ8CmylB7e946rR8mmN5/ZVOaR9KXE4fC67aZx3k1xnZFRaCTdM3?= =?us-ascii?Q?aOWIcl0lt0kDiCiUbGfjL1INwKP90JUVIEhmkwZjWisjI1lZMd/vAdrzsIfq?= =?us-ascii?Q?I/+nm6PyHQ+5o5iqBEN8BTIMyW49maakT38wNQa74dFgCD7Psy933k/T6W/9?= =?us-ascii?Q?MEoadTlXDP2sTGr0mb1lQebU/oYo2ayuWXKeTRJ7JPttv+zd04IfKsSjTeYM?= =?us-ascii?Q?VLcV5TRIe7T2vN0UAIrSvAhNAlR4FOZQux09G9PQHON97EAo6qzJ8rFXjBl/?= =?us-ascii?Q?CduADDY1bYwylXaKcNh4s9vDBE6RUtMRr/dWrFRlhxdbTUAO566sFhRVeDZn?= =?us-ascii?Q?Z7B8vlnmsMG9B+zTNqaRQTMmu0QtbxtoZonGswVdQ1A/6vF3iAaxneckpUav?= =?us-ascii?Q?i4x7jczZAXXZCwd7orusHNDZy7mizpyXYNjRnwMMPvHx0nDSsydWF/8/eFLi?= =?us-ascii?Q?q5SC1KmXQd0YrYDiMK7y7bFSrGIJZUs=3D?= X-Exchange-RoutingPolicyChecked: F7sS6Vpik/28Mjsy8eIDwnHhR0iI2HS45WspNEw89cKE7rUTzhGygPxhNrDRt5iqeVu47LOGCCSXwCbU9YumV210JkeFS8stjsilKdHz1WBx1AguVXlIXS0ao4bS0r3tBlpd2irHuqz7TGtWYTqQdvAwvtnps2IdgrIJMxnZv31NxWlsTgN4U+kmJERfuWdbg7ygqNpGm0yo0DQ1kptdqIvakpnNkTC2PiIZALotFm0iMu6kA8vnqRnhChkaZ24eewr+brZO+JEWPp7+7vNPLP962UBeDVm202bAmgBw/K+288PhR4GGfEfluMZzYU1tAVJak3G0lgYAjbgBDVGxlw== X-MS-Exchange-CrossTenant-Network-Message-Id: 8e9c6342-95e7-40ed-d48d-08debbb3a604 X-MS-Exchange-CrossTenant-AuthSource: DS4PPF0BAC23327.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 May 2026 05:48:59.4769 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ifY3Gxhw9vhm/quvSGRDdVlJRnIEc+8FXMPOPurzAA/3RXi32NQqvMXOtUESzOxWqE6PsKpnfO+2jcyokVZnRnN8bC4gzXnCjJEoiJ8kUUM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5139 X-OriginatorOrg: intel.com On Wed, May 27, 2026 at 12:08:07PM +0800, Richard Cheng wrote: > On Tue, May 26, 2026 at 04:21:30PM +0800, Alison Schofield wrote: > > On Fri, May 22, 2026 at 01:44:57PM +0800, Richard Cheng wrote: snip > > > diff --git a/tools/testing/cxl/test/cxl.c b/tools/testing/cxl/test/cxl.c > > > index 418669927fb0..7a1105f9a0bb 100644 > > > --- a/tools/testing/cxl/test/cxl.c > > > +++ b/tools/testing/cxl/test/cxl.c > > > @@ -318,7 +318,7 @@ static struct { > > > .restrictions = ACPI_CEDT_CFMWS_RESTRICT_HOSTONLYMEM | > > > ACPI_CEDT_CFMWS_RESTRICT_VOLATILE, > > > .qtg_id = FAKE_QTG_ID, > > > - .window_size = SZ_256M, > > > + .window_size = SZ_256M > PMD_SIZE ? SZ_256M : PMD_SIZE, > > > > Why not this: max_t(resource_size_t, SZ_256M, PMD_SIZE) > > > > Hi Alison, > > Thanks for the feedback, but I doubt this will work. > "max_t()" expands to a statement expression, which isn't a constant expression so it can't be used in this file-scope static initializer. > > I did the change and compile, the error is > """ > include/linux/minmax.h:86:9: error: braced-group within expression > allowed only inside a function > 86 | ({ type ux = (x); type uy = (y); __cmp(op, ux, uy); }) > | ^ > test/cxl.c:295:40: note: in expansion of macro 'max_t' > 295 | .window_size = max_t(resource_size_t, SZ_256M, PMD_SIZE), > """ > > So I don't think this approach works, I would like to stick to ternary form if that's ok for you. Sounds good, and right. Thanks for the explanation. > > > + BUILD_BUG_ON(!IS_ALIGNED(MOCK_AUTO_REGION_SIZE_DEFAULT, PMD_SIZE)); > > > > The rule we need to enforce is tha the actual auto region size is > > PMD aligned, not the default definition. So I think this needs to > > be a runtime check of IS_ALIGNED(mock_auto_region_size, PMD_SIZE). > > > > -- Alison > > > > Thanks for the catch, I'll fix this and send a v4 to make it runtime check. > > Do you prefer WARN_ON_ONCE() to be ammend or no? I mean > > """ > if (!IS_ALIGNED(mock_auto_region_size, PMD_SIZE)) > return -EINVAL; > """ > or > """ > if (WARN_ON_ONCE(!IS_ALIGNED(mock_auto_region_size, PMD_SIZE))) > return -EINVAL; > """ > > Which one do you prefer ? or any other idea ? please let me know and I'll make the change. I don't think we need the backtrace of warn, how about this: if (!IS_ALIGNED(mock_auto_region_size, PMD_SIZE)) { pr_err_once("mock_auto_region_size %d must be PMD-aligned\n", mock_auto_region_size); return -EINVAL; } > > Best regards, > Richard Cheng. > > > > + > > > cxl_acpi_test(); > > > cxl_core_test(); > > > cxl_mem_test(); > > > > > > base-commit: 6779b50faa562e6cca1aa6a4649a4d764c6c7e28 > > > -- > > > 2.43.0 > > >