From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73FD654739 for ; Wed, 27 May 2026 06:23:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779863000; cv=none; b=FTPmlr32Wr9bOvY/hfBso55lMfJ6MqN6myHIMM9pQtazhu1QCzLI8vw6BScQG0MJ+l8+XkHNdHYGyI1RoUKXKwFhq6IWZIg8pzjkTaNdMsA+/4dRyq38NfiPSHnLuZfS1233y9W9CVuYCoXVcaj8cPHi0CywD5n7KyjDpzrmXP4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779863000; c=relaxed/simple; bh=WgVg+YDhBvlP4l682o6rxWGmlntGL2iL9iy4u0txc3M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=AoJp9aQRd36bdGVdbmCrqP3+C/qbKqmTdSkb5kVBTO+87aWbJe9rgAviTt6Z1gJpz9PuMiJtnDxX5i7E0pb3Po8pQKzZpjJTRgQZ5/2d8vCjjmC1+/SJEAyWcc8ThzLZCsN0v7oxZxYLxkme/GWPBMNZK8XSM1MdA4JVZFcs/v8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=snxE8LLO; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="snxE8LLO" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=OmPvu22zMGt5fCOMVZzDUG9urPf4VyhQqlkO1rqSdEs=; b=snxE8LLOeVbNgyUgfrKvAtO3cJ Tqosg/QmfYjG8gmaJm9oIZdanUcQdEQLXduHCZHvsCNo3WkJcMPbe6I/6sNENjdPuG2t5mWnYG0IK VajYNJ5SWgMSAzm9JRdIo+Zrsu90ZCC46Ecu35P4F2Ab82mzD2qiaY8G1+XUt+u8XYLWZXQXh86lB /hsTem7R1UPKwcHIw4mf11MZYILkGJKE3WgUsdhN2fdZYhd7hBGrr7Ve61xERSNAxQ2MAGWlRIDC2 lpGlvzaB2ZtKRtJwT36QSOG3xQaE6m4iGY2bS4iGPnFRjpJfFqMzWnIWEsVmyVzD3Ry8p9jtYUCS4 0/nE5C+g==; Received: from hch by bombadil.infradead.org with local (Exim 4.99.1 #2 (Red Hat Linux)) id 1wS7fh-00000003OWu-2mi3; Wed, 27 May 2026 06:23:17 +0000 Date: Tue, 26 May 2026 23:23:17 -0700 From: Christoph Hellwig To: Farhad Alemi Cc: Christoph Hellwig , linux-kernel@vger.kernel.org Subject: Re: [PATCH] freevxfs: don't BUG() on duplicate OLT entries Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html On Tue, May 26, 2026 at 11:49:47AM -0700, Farhad Alemi wrote: > Hi Christoph, > > Thanks for the review. Before sending v2, I tested WARN_ON_ONCE against the > original reproducer, and on a panic_on_warn=y kernel it still panics (the > WARN fires and panic_on_warn promotes it). > Would pr_warn_once() work instead, to keep the diagnostic without the > panic_on_warn coupling? That's fine. People who set panic_on_warn=y for anyting but debug kernels deserve this. > Happy to respin either way — just thought I'd check before doing so. Sure, it's always good to ask!