From: Christoph Hellwig <hch@infradead.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: Christoph Hellwig <hch@infradead.org>,
Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
io-uring@vger.kernel.org, linux-mm@kvack.org,
Leon Romanovsky <leon@kernel.org>
Subject: Re: [PATCH] block: Add bvec_folio()
Date: Tue, 26 May 2026 23:22:29 -0700 [thread overview]
Message-ID: <ahaNpbG15d6StT9d@infradead.org> (raw)
In-Reply-To: <ahXcsrxUFfzoVCOr@casper.infradead.org>
On Tue, May 26, 2026 at 06:47:30PM +0100, Matthew Wilcox wrote:
> How about:
>
> /**
> * bvec_folio - Return the first folio referenced by this bvec
> * @bv: bvec to access
> *
> * bvecs can contain non-folio memory, so this should only be called by
> * the creator of the bvec; drivers have no business looking at the owner
> * of the memory. It may not even be the right interface for the caller
> * to use as bvecs can span multiple folios. You may be better off using
> * something like bio_for_each_folio_all() which iterates over all folios.
> */
Sounds good, although I'd captialize the first word in the sentence.
(Not that anyone should follow my spelling advice in general)
next prev parent reply other threads:[~2026-05-27 6:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-22 18:21 Matthew Wilcox (Oracle)
2026-05-25 6:06 ` Christoph Hellwig
2026-05-25 13:29 ` Matthew Wilcox
2026-05-26 6:43 ` Christoph Hellwig
2026-05-26 17:47 ` Matthew Wilcox
2026-05-27 6:22 ` Christoph Hellwig [this message]
2026-05-27 15:54 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ahaNpbG15d6StT9d@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=leon@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®