From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64F134266BA
	for <linux-kernel@vger.kernel.org>; Wed, 27 May 2026 14:32:10 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1779892332; cv=none; b=YmXJNASciuNHi54SSELncmCyvAwconF4+hji4zB1jdjs9tCMayLZ8g67CZmWCCEY1WQwe+gK3vfAYDEBYDo+lZOXSlD96dbdkD5scCh/WUypV1L8yq2rqxIrRlhvDZ8zOMDfRKMtY64HApzqMlXTM51oryQkO6ehk15C1l6IIro=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1779892332; c=relaxed/simple;
	bh=Z9qhk9SKD/L8muDeH2cB02r4Stf5wSf0njGL/daary4=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=Qhhr42K8Iq37FlRWdushWH8h6B43ZrMSQUr8JiCXrFkPfUFLAntnOtmrQXRJS3Ye5bci8EDYl6JVo+Q+ZREbQjECkLVCxjgUlj8fHgjuUdYf7ErU18YDa4eQAuY6+x40DF92nTx9+UNgjiHgtrPxf0Zh6VKJ8MxdzfOGROYh5zY=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=SxKtsSGy; arc=none smtp.client-ip=100.103.45.18
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="SxKtsSGy"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id C96F11F000E9;
	Wed, 27 May 2026 14:32:09 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org;
	s=k20260515; t=1779892330;
	bh=GzYb46va53a5V7lykYtKMSOYczoGqTemW+PX8cyAiIc=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To;
	b=SxKtsSGy5SFVkgYwJ8OqE9t4UptVrWfraSGByP32Tuuv3pm3gQERIKcGnPtOIiFuh
	 ETtD2wlNfTM/bn9WjHPae3UGfBByxXB+EGz5/e1gO8htoEO3Aymb0GRjr2MOBcGc+G
	 eOauLZeLsAB1wmXotVLomuipLYlxRhn63MZz7xsuvxeZa3JW3rxaBSLNXf3j+Yd/TB
	 /qkL8AVdXILoab3VL+/z0DsDcfsGjWWxkOAAbNB/75aC7in5a7oYZ/k1qINzmMvuoP
	 pYxJBUNwQKZpArthVI/l5wVqiXp2SSv0lq7UCv5Ff0Igw3Ldv4UNcixEi1AMeNAiJ4
	 GCC0Zg+7KXEyQ==
Date: Wed, 27 May 2026 08:32:08 -0600
From: Keith Busch <kbusch@kernel.org>
To: Chao Shi <coshi036@gmail.com>
Cc: linux-nvme@lists.infradead.org, Christoph Hellwig <hch@lst.de>,
	Sagi Grimberg <sagi@grimberg.me>, Jens Axboe <axboe@kernel.dk>,
	Tatsuya Sasaki <tatsuya6.sasaki@kioxia.com>,
	Maurizio Lombardi <mlombard@arkamax.eu>,
	linux-kernel@vger.kernel.org, Sungwoo Kim <iam@sung-woo.kim>,
	Dave Tian <daveti@purdue.edu>, Weidong Zhu <weizhu@fiu.edu>
Subject: Re: [PATCH v5] nvme: reject passthrough of driver-managed Set
 Features
Message-ID: <ahcAaPTOH9ELlAA4@kbusch-mbp>
References: <20260523225629.3964037-1-coshi036@gmail.com>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20260523225629.3964037-1-coshi036@gmail.com>

On Sat, May 23, 2026 at 06:56:29PM -0400, Chao Shi wrote:
> +			switch (le32_to_cpu(c->features.fid) & 0xff) {
> +			case NVME_FEAT_KATO:
> +				if (ctrl->ops->flags & NVME_F_FABRICS)
> +					break;
> +				fallthrough;
> +			case NVME_FEAT_HOST_BEHAVIOR:
> +			case NVME_FEAT_HOST_MEM_BUF:
> +			case NVME_FEAT_NUM_QUEUES:
> +			case NVME_FEAT_AUTO_PST:

I may have been overly restrictive with suggesting AUTO_PST for this
filter. Messing with the other features will break something, but power
state is just user policy. The driver may undo the user setting on a
controller reset, but so what?