From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41D6939903B for ; Wed, 27 May 2026 15:00:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779894020; cv=none; b=jn3zV5h61eLdYSA6aipbc6CafEO42s7Az3n1aH3vrm97HLcBYoJCyuG6jY7383+2y+dCgZXQ1acH4Tf8HFfGu8dwTZ8ZUOxdDEG1TnhgXrVM0aVMbAJgfr1e0Ade/BeyMMQgNWEkpjLmG+Nzf9ab6uvIpqiHdAZTK0jlh8J2wng= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779894020; c=relaxed/simple; bh=lfSJ/AVIHFhZlQvctIwl6yBEtII8T9ls09n6S0I1o3c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VSIomaNGRmZOG7fC2EXjMRLHFyL0WbJZ8WthgbsdQ7KN2FowHES5/Icj2oBKt7WRf6pj0tyKrWEr/8DHi707+cwmJQbsOeQXdhnCFwhlHZVoKiSTt2P9syW1X7nOfoFmHG2uYCwzPCNkiz5byqwcNUZD5bbndLX7LpiUHurXhxQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=N5y+8VfD; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="N5y+8VfD" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9406C1F000E9; Wed, 27 May 2026 15:00:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779894019; bh=WN2eycs/ujPks6xgujkmedWhK8TsKJSPP2kHz2LiIIg=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=N5y+8VfD44ic5nYieykQ5UQQMspzv7yUzHTkHqTVOzHbUihJJUkKRj9gFTcR/DJzn JsIfbir+U5iN2aODgHCjDMcvwXF1xBBARoq0WzA2fJ2nBvCRdCcbfPwFSeN446TCME AemygGppWFIQzCQxFrrKcf0vbqyj7U0NYD8A29SvaH2naH9eDGtVXSl681B+appMWH XiTLmhoHNsYzWk36GcdTRxSgCIMOljOtkCxS3+zAozDiKdNyhC1VMFSxtkJ+SBo2tM PI6ngBDhfAidBiXLDJP80R0KtHCMsgjzKowvfRpxDbvS83wosgOEth/NEapa3gfmFs BQiiUioOnC/fg== Date: Wed, 27 May 2026 09:00:17 -0600 From: Keith Busch To: Chao Shi Cc: Jens Axboe , Christoph Hellwig , Sagi Grimberg , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Sungwoo Kim , Dave Tian , Weidong Zhu Subject: Re: [PATCH] nvme: reject completions for requests that are not in flight Message-ID: References: <20260522153034.2168862-1-coshi036@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260522153034.2168862-1-coshi036@gmail.com> On Fri, May 22, 2026 at 11:30:34AM -0400, Chao Shi wrote: > Oops: general protection fault ... KASAN: null-ptr-deref > RIP: blk_mq_complete_request_remote+0xe5/0xa80 block/blk-mq.c:1319 > nvme_handle_cqe drivers/nvme/host/pci.c:1418 [inline] > nvme_poll_cq drivers/nvme/host/pci.c:1449 > nvme_irq drivers/nvme/host/pci.c:1463 This scenario doesn't sound specific to nvme. Should blk-mq completion check for the IN_FLIGHT state instead?