From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 18972363C5A for ; Wed, 27 May 2026 15:54:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779897289; cv=none; b=d7fnt6pfrZq+/s8nCizAtoKwMGK20Uw+2fGcUfkF09nlzoEqEDAZ/brptn8oRrdfBqwKp9NX7Z0GI7cVKEyP85miWAM2Ihj6nLiC+7BNFJJjGs0HwmkBSP4lMvbUBBiYYbKebg/ypu564rWEIhnN3kGC2hgFNENiNcdzdUIShL0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779897289; c=relaxed/simple; bh=SCKefFkbXP+kGLadfxuxAtgXqNgeIAMkox9Rd4uqbjI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sLZSamZDGlbE3p105Mnd0ctLmmR/vdWgE6jNvT8KZFYB0Avt2YkJPOFKZ1rcpwe4bdlkEuzda0I6JjYizEngmbvLZ3fmg4gbJqX5sIU0cnWsfLeXSoPWzhny5cgv0Dc9I85ZHgQLW16uhbbD7k7EXxgPCAb3Ug51Mew4CNtWaUQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KaEQJrmy; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KaEQJrmy" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 620C01F00A3D; Wed, 27 May 2026 15:54:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779897287; bh=IzWv3CFev7HlBHwUzxxZ5QsEgFECobCH7XEfsL+GtK0=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=KaEQJrmyeogO5ef9d3bSuLDSajWuuA6fJDKvjPdO8bSmWpcKUjvXMZ9ZqgzVf3/He NrXHVqtnmzmp5jCNQqGWAZ6rDJmStDMCOa36M9PFjJwWw5I07zlxtiMbzGcKy3rA1j 1SXvl0u1gwgoXeBN82F0QjW/AkB+G6HPQzDxiLXC/Dphw1TW/eyrgfAsXkCWYL7zYJ HH8dglwochpnuvN8n12f/Awdd29oI1uWK30NB6kZdnGVVvZmgMWXQfYJKxohIADrqc HbSiaBMpt3XzkCdWSsBG40SNtFVHxekizzbxKa5NymkkWd1xHromEtpzn0Hlv55BK8 B6Kj4iaRq4ADQ== Date: Wed, 27 May 2026 16:54:42 +0100 From: Lorenzo Stoakes To: Yi Xie Cc: Christian Brauner , linux-kernel@vger.kernel.org Subject: Re: [PATCH] ipc/sem.c: use unsigned int for nsops Message-ID: References: <20260525004220.19277-1-xieyi@kylinos.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260525004220.19277-1-xieyi@kylinos.cn> On Mon, May 25, 2026 at 08:42:20AM +0800, Yi Xie wrote: > Use unsigned int instead of unsigned for nsops parameter, > to match declaration in syscalls.h. > > Signed-off-by: Yi Xie Pretty sure I R-b'd this :P (didn't I?) not sure if too late since Christian took but FWIW: Reviewed-by: Lorenzo Stoakes Cheers, Lorenzo > --- > ipc/sem.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/ipc/sem.c b/ipc/sem.c > index 6cdf862b1f5c..5ec41de7e85b 100644 > --- a/ipc/sem.c > +++ b/ipc/sem.c > @@ -1981,7 +1981,7 @@ static struct sem_undo *find_alloc_undo(struct ipc_namespace *ns, int semid) > } > > long __do_semtimedop(int semid, struct sembuf *sops, > - unsigned nsops, const struct timespec64 *timeout, > + unsigned int nsops, const struct timespec64 *timeout, > struct ipc_namespace *ns) > { > int error = -EINVAL; > @@ -2220,7 +2220,7 @@ long __do_semtimedop(int semid, struct sembuf *sops, > } > > static long do_semtimedop(int semid, struct sembuf __user *tsops, > - unsigned nsops, const struct timespec64 *timeout) > + unsigned int nsops, const struct timespec64 *timeout) > { > struct sembuf fast_sops[SEMOPM_FAST]; > struct sembuf *sops = fast_sops; > @@ -2294,7 +2294,7 @@ SYSCALL_DEFINE4(semtimedop_time32, int, semid, struct sembuf __user *, tsems, > #endif > > SYSCALL_DEFINE3(semop, int, semid, struct sembuf __user *, tsops, > - unsigned, nsops) > + unsigned int, nsops) > { > return do_semtimedop(semid, tsops, nsops, NULL); > } > -- > 2.25.1 >