From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E9D12E06EF for ; Thu, 28 May 2026 03:03:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779937386; cv=none; b=m0SxJ5SW5JZuAroTVsrCj2/XlnyVkRMiWy3Wg63zNcLXRE5Xibt10zrBCYcXfYJrqhpPC/2TpxtdWiHAmrp/WB+rixD4fU6CN7IumM1ANLfAFBnPc87rvojAkc5BDc3WT/LGymWH0S49g6sp1RMDCmDEm46B1pJeExOS7QQS7l8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779937386; c=relaxed/simple; bh=1ZDSFa6IPlRvDQKLm62tUx2lIQD7fDMIzz5woqRntNk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=uVEmCpRpxS4L3+srkzvPD5kjtxjZC0QbjrkRpFaY7FC2MZRDjsty1RrbHb54ODgommBFr9LITSakNBLqce7W3ty4Qix/KGFkMInaWRI/40b4kkW4FBvBdChh5bDDJoPi3YZR6+H03obureF9xEyr/8KEBrAczNHgB381+Ry7gao= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=g/aO2YGl; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="g/aO2YGl" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 66A0E1F000E9; Thu, 28 May 2026 03:03:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779937384; bh=9T2cjIzZrCgAbBk/8HQTKOkMW08zXo9cpLSyBb/lJOI=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=g/aO2YGlMnhJ41Jkkjr9dT5Yon+FgEs28WKb5Rdz7Y+jsrRANOGyRgPKfsAWg6cBU KsZy6BpBL2PBSU4vzGcXiey6Z3fkHwxn09KIfDuIM9HrNV2SUVbTuCZ33tc34GeBDu em70WeQaHTOfucTrna3V0ulgICrnoD/uwj0fraQ7Hc06DuhEbQq7dW2iqZiY2kVlJd 0B2Tywwtd/WH8tmuz8ot1BzbQLuP8QLdXZoRHMNPpCGRbdZPlJ/Ryoc25ixX3s7Og9 tlOpb8PRO7l1RxmVwuFbvZUbT2pMwH0cSQO/bxL04BBPIot1PdbNNkecPJjATT65Zk 11s7LVBEKpGrg== Date: Wed, 27 May 2026 21:03:02 -0600 From: Keith Busch To: Christoph Hellwig Cc: guzebing , axboe@kernel.dk, sagi@grimberg.me, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Guzebing Subject: Re: [RFC PATCH 0/1] nvme-pci: detect I/O queue depth changes after reset Message-ID: References: <20260527075320.3178600-1-guzebing1612@gmail.com> <20260527131951.GA11071@lst.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260527131951.GA11071@lst.de> On Wed, May 27, 2026 at 03:19:51PM +0200, Christoph Hellwig wrote: > On Wed, May 27, 2026 at 03:53:19PM +0800, guzebing wrote: > > This RFC instead takes the smaller approach of detecting the reset-time > > CAP.MQES change and making it visible. If the live I/O queue depth > > shrinks, reset recovery is failed before recreating I/O queues. If it > > grows, the driver warns and continues with the existing queue resources. > > Unlike the other version this at least sounds doable without creating > a complete mess. So if we can live with this version that'd make me > much happier. Abandoning the device here sounds pretty harsh when blk-mq already supports user space decreasing the q-depth on a live queue. Why can't the driver do the same thing?