mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Zhang Cen <rollkingzzc@gmail.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	Carlos Maiolino <cem@kernel.org>,
	linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org,
	zerocling0077@gmail.com, 2045gemini@gmail.com
Subject: Re: [PATCH] xfs: drain inodegc before quota teardown on mount failure
Date: Thu, 28 May 2026 01:32:15 -0700	[thread overview]
Message-ID: <ahf9j4G0sdSx0Ti5@infradead.org> (raw)
In-Reply-To: <20260528053128.3036120-1-rollkingzzc@gmail.com>

On Thu, May 28, 2026 at 01:31:28PM +0800, Zhang Cen wrote:
> This was not from normal xfstests.  I reproduced it in a KASAN-enabled
> QEMU guest with a disposable quota-enabled XFS image, then forced a late
> mount failure after quota setup while tracing the inodegc and quota
> teardown path.  The failing ordering was:
> 
>   xfs_qm_mount_quotas()
>   late mount failure
>   xfs_qm_unmount_quotas()
>   xfs_qm_unmount() / xfs_qm_destroy_quotainfo()
>   xfs_inodegc_flush()
> 
> with inodegc still able to reach the dqattach/dqget side during the
> teardown window.

Can you come up with an xfstest for this?  I guess you'd need a new
error injection point, but that should not be horrible.


  reply	other threads:[~2026-05-28  8:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-14 16:07 Zhang Cen
2026-05-19  8:40 ` Christoph Hellwig
2026-05-28  5:31   ` Zhang Cen
2026-05-28  8:32     ` Christoph Hellwig [this message]
2026-05-28 13:28       ` Cen Zhang
2026-06-02  7:01         ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ahf9j4G0sdSx0Ti5@infradead.org \
    --to=hch@infradead.org \
    --cc=2045gemini@gmail.com \
    --cc=cem@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=rollkingzzc@gmail.com \
    --cc=zerocling0077@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome