From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDEE62264D6 for ; Thu, 28 May 2026 07:30:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779953426; cv=none; b=Qp1obhUP4zdsEjKXMmmInnaBNbhRm9myRJpvJVUO7aqnBJIyuhYkQp/Dfbo6aqMNPC1eFV/tCyyZjI/F/h7qDACjMvAB6fXzNdV2IKu9cv8Wk5GD8vDuc1VqWhWk/AemwitjNbV1iEAm3xvW4Exuv112ewnPkOpO5Fp/feGdWRE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779953426; c=relaxed/simple; bh=zJiejorxc9hbXeOQMqz4/Z7l9LfvKtYMkzDoqFvR48w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BB2ZRGxVTHS/zYbkEyHX/OFygKRsZsy8Q8wDugBJ45vzhsEHT5cM1f8ovalg96P3PkkVPvaoZFZqNRMd61b3Jv8jhyh72abp483UCdO7C7P3qnG/M3+q8rF/GfhIN87vn2DkP+mOIulxOyePqjHcvrP4LfIV48A4C58YBHeBQ6Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bHYZKYuL; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bHYZKYuL" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-45e7c636e74so6614851f8f.0 for ; Thu, 28 May 2026 00:30:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779953423; x=1780558223; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=FqLb4I3vY1tjULmOl/LkKCXIPPHEkCsfo9G3pGb0IEo=; b=bHYZKYuLLulvPC2nX1eMkEJxIed3SeQAQOiD6AISl0w/t/NOAvUGldJvZF6h5nqs+B Prh9ok/viGY9y14HcYDpr6CyDhQ1YiUsTubq+izUlsjulZYN0Cm2cvQmgkB7Tn4gRfG5 cQCwU3uOTD+0U4eJEGamAuFAH9DyJeso0xK/F2tETwTN6hd1KOaBppLM+BR4tou1hKi9 fwOYGmAhtDDrQWWDEiWl9JxUpmhWSs41VAg4hZStcvHRMUz6l0Qdxr9vkYQIx4i4mrdx w8Bfcj+I6wpr+UMfXHUgLnRr8FW+zU9NoaenqnkZnEFyoeyutqnllpPQgXFJ9ow1LOL4 J32w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779953423; x=1780558223; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FqLb4I3vY1tjULmOl/LkKCXIPPHEkCsfo9G3pGb0IEo=; b=Dv/wq9YjYH0l95kLJ4QuatQv3mAD40C6O5a7PO0OYfJC/IEWBU+hi9bD+DLYwJ/Qp0 S6dy4DLku38F3AtKh/DtkCgQyHOEQviWbE1sTc6mlBZVQDvCQIBaUhHJd/Zlif4ULn5A k1Wv8zmtuxW46+VWML2TcCZXDlc8Z2fmT+m6XCeNXC3FNcsCVJ4eyZLSd7MAaCbfvOAQ X+IYhWB6mSkXAV/pk0sFTMms5dFgza0rQG6yd92cZatgn+vwf1Br8qGU17v7ik7ubqO8 9nz+tmIYTosXyUhl21X7XFv5FPQsoQiN4Oq1rlI1knefBvcFYa7GFvRIuG1XfdoJGgYz HQ7A== X-Forwarded-Encrypted: i=1; AFNElJ8bFMl74l84O4fK6FiHf0u0YVSw0ZODWWVYGzI2p1NrlSSWdPfUj/kAUh+ykgofkHZXZXAlgiWnxOOeU8M=@vger.kernel.org X-Gm-Message-State: AOJu0YzR6PCaUeNkwP4P3tn2B/UzgqHXtGfrZPORBuE+JI2CpbSDZclB RjTog9DhEDafe0AC85PyAuW5tSuudmeDh5PDyr1ekvPOBblmwDrDU3cn X-Gm-Gg: Acq92OGBxYmvoFba4vQIHTdS00/dNVBt8AZIp5uG4TXRBQqaSe35INeDRPT5eLmNoW9 B3NnvD8F2VNImd+eqRxrPR3hSOcdN9jd6V0vMgAcBcjiQth/O8ygm57/5Pbwin2BWD+GcVPHrRp /eXhWbsNb1eVBZlk6lUa20yLInqznpyU2AowAopb4aaube870coyZg/Iwo/9C0hEG5h+Dm0ZB1P up+MCSEoh5xNXCwzc3V0gu3C2GWbSvX/+7BaWbuuCQLQtSJHuo0/8CJmp0zUXcS5rXXizBdcO9Q HBP5v4eNQhmA36w1KIBGeqDbDlwFhOP4A83rpxwQ+FAV3OF7fRxA/aPZ5AnglHJ4OyxBG1G4BGu P8JZlktAb4FaGiuNRiuXr7hnEj1Z9sUUU1knKMtaQX86N8SQZdrHbie79/fHXkZ+Os/nOdPayt3 AXGPefLgLtCqdrPlVaSvkiJXSD6EwkmkieNw== X-Received: by 2002:a05:6000:40cf:b0:452:273:5cd6 with SMTP id ffacd0b85a97d-45eb367fe78mr45727417f8f.1.1779953423184; Thu, 28 May 2026 00:30:23 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45edb5b2ba9sm11402235f8f.31.2026.05.28.00.30.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 May 2026 00:30:21 -0700 (PDT) Date: Thu, 28 May 2026 10:30:18 +0300 From: Dan Carpenter To: Dawei Feng Cc: gregkh@linuxfoundation.org, omer.e.idrissi@gmail.com, hansg@kernel.org, hi@josie.lol, straube.linux@gmail.com, xela@viard.dev, ethantidmore06@gmail.com, liangjie@lixiang.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, jianhao.xu@seu.edu.cn, Zilin Guan Subject: Re: [PATCH] staging: rtl8723bs: fix mismatched free of HalData in rtw_sdio_if1_init() Message-ID: References: <20260525091836.812565-1-dawei.feng@seu.edu.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260525091836.812565-1-dawei.feng@seu.edu.cn> On Mon, May 25, 2026 at 05:18:36PM +0800, Dawei Feng wrote: > padapter->HalData is allocated via vzalloc(), but incorrectly freed > using kfree() in the rtw_sdio_if1_init() error path. Using kfree() to > release this vmalloc-backed buffer can lead to memory corruption. > > Use rtw_hal_data_deinit() to pair the free correctly and free > HalData with vfree(). > > The bug was first flagged by an experimental static analysis tool we > are developing for kernel memory-management bugs. The rest of the commit message from HERE > Manual inspection > confirms that the issue is still present in current mainline. > > An x86_64 allyesconfig build showed no new warnings. As we do not have > suitable RTL8723BS SDIO hardware to test with, no runtime testing was > able to be performed. to HERE should be put > > Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver") > Signed-off-by: Zilin Guan > Signed-off-by: Dawei Feng > --- ^^^ Here under the --- cut off line. We don't need this kind of meta commentary about testing in the permanent git log. Otherwise the patch is correct. regards, dan carpenter