From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 508623ECBE4 for ; Thu, 28 May 2026 12:25:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779971103; cv=none; b=nDtPQ0iMFrW7ftABg5r4OHiT3gZzzQCMtk9WgFYME4beeoaqBHLRi+kWibRK03jZCUui/rniogsiE6g1sFl3eY0dAoVTFqP9xiheK7gciXxfcnJNOP8MIjjLxdq/Y5qGW4YFC8KxQu9qntWrlenDB1wYg/hm2dHDGNpfuW1Xk9Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779971103; c=relaxed/simple; bh=x17copRnpzYu2filojuLFFq2dZrap80ojU+vUgD3k88=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JxSBgNCnfhhUXkW0dZv06/9pEYE9PUR4gQMWJdkRjyVkqkRmsWYZSrS4sXBueUKGQAmGNanK+ut2RL0JYtYgK1lF4mR1eefjHqDzNf4yK6cJMFyfh893ue9eAzSBjGEgYR4ZFvp23kS6TDEs+BZj2ivQKH8tWck/sn4KZBdcIAE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ibA3X1Qh; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=EtT4V4nB; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ibA3X1Qh"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="EtT4V4nB" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779971101; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xpR7Iq4pAgg8A7KjCKBQrxuDLtsVU6/e+1rt/+jcU1s=; b=ibA3X1QhORb0vYPB2kUZsaHgWWt132Y7yNTTtJfUA2rI7OP13PINDvInspfvyWDvGj84/W s2+omHN5T5LLcMLsfvxxfx4PxRor1xeuGgFvPL3t+aBMgDuhJK8T49m5f0BQDB2cuVGvCv AHFYAoex2lAx0T9o42ryabDvLRD2TRQ= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-443-lfoXJhbaN_aaJ1plMDLSiw-1; Thu, 28 May 2026 08:25:00 -0400 X-MC-Unique: lfoXJhbaN_aaJ1plMDLSiw-1 X-Mimecast-MFC-AGG-ID: lfoXJhbaN_aaJ1plMDLSiw_1779971099 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-49045243094so87581985e9.2 for ; Thu, 28 May 2026 05:24:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1779971099; x=1780575899; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=xpR7Iq4pAgg8A7KjCKBQrxuDLtsVU6/e+1rt/+jcU1s=; b=EtT4V4nBe9w97p3JHeHfxGTw2Qgfz3eDm5M44LrHlu5kBkRsotrd+JBe0jhZTWPiSu jIxUBWm8bi8ZksQJr0ziDCXFQgedeG3sZsglXyS5/a6I95wIG2oiZTWriYkiKUnt8GbH MEGzdpgcGmMJBxgwmMs/AH6tS7x2Zlh8NnC3O+bScZnXN2MPJZeVXQR2RFcX0tLIEEq8 LpsT4NUfCY0hYkX7+baomFa/HRibCwv2xgGDXxtKRosYqlxhpMBu1z3uxFfRLbyaQ0Vu 2endf9nb7EBF4yNvPUd4tk19bLTwLM/8VK0Az6w1CrtTVHt01U2mpEuF+Iy+Uqounj9R sYMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779971099; x=1780575899; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xpR7Iq4pAgg8A7KjCKBQrxuDLtsVU6/e+1rt/+jcU1s=; b=n9sLSx6dVNO2b+Qgq5xt4ZG96HL3EPR5CgliwrJ3CQ0rPzOp5VBwa0z/UsafiIdMSD raoXd3EXl7MGUQRWk88CcTY0it/Csjzb2EpC9omYi2ZpeaX8r1DnfYmQakbnmI6oO7oU 8nTyvwf3IFhpWnd1dDwfTX2XExJW1NbJfabPs+YD5vYr2vaVwlENNCLQXJCpjB6o6MRs pBuDQS1q0gryj9CnH+Fd7iEWTl1cS0f9OuXRX/UmWPo6x4WM1YYyGEknovu6k+Zui1tU I3yTqHY3P7wSsxwdc8cWG/bYTXHfnYQZpL1/uu+Ne5tL1cZuVrcVV19PqIC3KrG2hiAO 60nA== X-Forwarded-Encrypted: i=1; AFNElJ8q9YfJS5ZLuaBfUEA+MW6PSpZmtAVjthOBhiyPG98CBa5gjxcDF9CGHFtlRdJQ7X1r2nC0AD/Ho/FlLdA=@vger.kernel.org X-Gm-Message-State: AOJu0YxejGsE0KPo2LxDRSpKi3+qNTICPr9ny/9n/IAC0s3NA0WFact8 MvcjvaaAiuxDNSCyOETFdz+H6ranzCBXkPugqkrg5JcZjBpYllp2FdB11pMPigL2cNxehPgD1rR dHEOfjcK72tCq5XJYyDS44iG+V9nZZxmi2ySJoZZ4pdUtTAJIe9U2Ae80NLWaj+vyCw== X-Gm-Gg: Acq92OHHLuFXHjMqFntIEV69c71jLQucyMbW1bPd4bKQNkBePv1dUiq20kh1xE22UZP k6PDuSR8K1R6y5Ho88h0+qf8EWRG1Ri3/c1/IR8MM9EbGdIOKE1g0E7Y+nzXZ0AfTiPQyotCniS F8wWYWB/PdBCQKQk5ns+kQDKdPnPrzMtQtVEkzBnFQKck0lTpFzuDRiJ48B/No41IpUlnV2XUCH CHaDp7zmuLE7njytrL7ub55xiEwx0rbmUQsGb8khXMYSvWBS3+57AR+z8g0KTzy6GIM5cURg5no 1E8eSpa7mSYlowMUWfM6YW+/k8YKrYHj0sqqbR1lkPugUw32BoTiNx3+1j6lPyL8okJi76W5CyK Mxd/XSbvcgXWpqZmDNVAfBj7RpFfd5zJnVXh7QXZIbznZSU4HHFT+KuJL4JXs2No= X-Received: by 2002:a05:600c:4ecc:b0:485:4388:3492 with SMTP id 5b1f17b1804b1-490424b25abmr432877745e9.11.1779971098982; Thu, 28 May 2026 05:24:58 -0700 (PDT) X-Received: by 2002:a05:600c:4ecc:b0:485:4388:3492 with SMTP id 5b1f17b1804b1-490424b25abmr432877295e9.11.1779971098564; Thu, 28 May 2026 05:24:58 -0700 (PDT) Received: from jlelli-thinkpadt14gen4.remote.csb ([151.29.44.165]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4908b57054esm16559935e9.3.2026.05.28.05.24.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 May 2026 05:24:57 -0700 (PDT) Date: Thu, 28 May 2026 14:24:55 +0200 From: Juri Lelli To: Guopeng Zhang Cc: Ingo Molnar , Peter Zijlstra , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , K Prateek Nayak , linux-kernel@vger.kernel.org, Guopeng Zhang Subject: Re: [PATCH] sched/deadline: Exclude special DL entities from bandwidth moves Message-ID: References: <20260528065324.1303334-1-guopeng.zhang@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260528065324.1303334-1-guopeng.zhang@linux.dev> Hello! On 28/05/26 14:53, Guopeng Zhang wrote: > From: Guopeng Zhang > > SUGOV special DL entities use fake/unused bandwidth. They are already > excluded from regular DL admission control, affinity admission checks, > rq bandwidth accounting, and root-domain rebuild accounting. > > dl_task_needs_bw_move() misses the same exclusion. As a result, > set_cpus_allowed_dl() and cpuset attach may treat a special DL entity as > requiring a root-domain bandwidth move when its affinity mask no longer > intersects the source root domain. > > Return false for special DL entities so root-domain bandwidth move > accounting follows the rest of the SUGOV special-entity handling. > > Signed-off-by: Guopeng Zhang > --- > kernel/sched/deadline.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c > index ddfd6bc63ab1..3653166caa69 100644 > --- a/kernel/sched/deadline.c > +++ b/kernel/sched/deadline.c > @@ -3142,7 +3142,7 @@ static void set_cpus_allowed_dl(struct task_struct *p, > bool dl_task_needs_bw_move(struct task_struct *p, > const struct cpumask *new_mask) > { > - if (!dl_task(p)) > + if (!dl_task(p) || dl_entity_is_special(&p->dl)) > return false; > > return !cpumask_intersects(task_rq(p)->rd->span, new_mask); Makes sense to me. Acked-by: Juri Lelli Best, Juri