From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D683C2E2DFB for ; Thu, 28 May 2026 14:07:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779977254; cv=none; b=IR9pjAnxc3AVPQWJhhNa2Jgb+ycrpZVLpPcNeJFzdErbtwTXawXDt0zZHIuTjUYGG+ENi1OkhuuVFhrRtLtAJjrT+oWkVEK56foknfSXm029eSV2+Db99QdfdXD+xhkXIFHwIFYwD3Nk6qroJFc/AeDsRniWmX1u2gb35MLQtoA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779977254; c=relaxed/simple; bh=2pkvGxgADbS7lN7SVev/d7FTofxmy+WcMJdhfAc2WkA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DscL7Ua5dqoYwkp5qcCOaSjIiC2agp/T7FT/pB4GiV0WRLXeRjI6wtMD/UThb5ZmzmzHdlpBvdZAtusbYxjr+RQdfnPqf0jGBa/tHBqt5NPMkR7Sv1X8Wtvv3WIH9SNdPx7AkcNPGzsWdpdsZzYiVi3pFPam9fLsuVr/FipXqaE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=S0kmtYDF; arc=none smtp.client-ip=209.85.208.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="S0kmtYDF" Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-6877c719cb0so12196140a12.2 for ; Thu, 28 May 2026 07:07:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779977251; x=1780582051; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=DqwQ43i5UxZnypk4nLtxsv3svle94X+tfPaE030Lwh4=; b=S0kmtYDF+9wzUWTVK/IVqBoO49W9vx4z1IctqLO7EV1jYurGYHpEnFMeUZRgDHTZN8 JOgY1gFpaM3YDPjg70hjOKMHFElGLkkJAziRdUbAJq9/5Qok20oWMBWb+RiIkM2sPVv6 +4OxnKDlbpBILa4Af/LPPKXdRQdUDk6pfVcDVahqnq0rYyC685CeljImDjHYcM3cZwEa max0EUzsSgYfjjwaqraqfPWul1rwzji9zCGOlzvm7coZXptuPL34Je1qW6Yhs1/7Xgko 5t8VJ8M7CZDy/mxBNwhpWpcsxWKBtLNqwa5YQ3gNKUkeDfNlj7NnLwdFQrAqU1uHKL8q +H4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779977251; x=1780582051; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DqwQ43i5UxZnypk4nLtxsv3svle94X+tfPaE030Lwh4=; b=ArFsQwDZPmLJTzRqc5f9qxpxVYQJ/foAVn2QV04zet+A0ckBO0jXRMgRnBmbpP+aRr GoB0mBDqWl778jNP1zAXqCw5sxq9F8TDTCpLPOecRqxTCXVzGJT6A80QeeLCAoMRLIW1 qPYBqom/k6hZ3niVlf3rAxPLcZBEYXHqa1W21XqmXJcn9Q9iyGR560cGi3uNsLhVwQlz O7L1xAx9YogLGP1SxCG5vcjxs/J1xCORXxsbhFOjM49wCs3S9Zt0wd++bxg/eTfS0QWl JxVc7LVuyN3F6Q1Q7PKxgVHfeLjL0Ut3VWLzb5sSk8EtTqnmQB/4DLIYaKWXIKV3auPF qDpA== X-Forwarded-Encrypted: i=1; AFNElJ+NNQmnCzI/sESKxsPE1OkV3y+qb/7MwCfjX1Kcs/OOxUIAniyTMxUkOJCTTNr2Ud7YJA7QpnqYQtAdaWA=@vger.kernel.org X-Gm-Message-State: AOJu0Ywtlxz5UPchxUkxBaCehWV7RD7A7H+ThC4KZAxKbT50MygqlySz jeXGI5Hozu0SIg3VOVYx2wq4CK9mHobyvx7SJt1ezxyYoC0uKQYhlPcUFmr8CC/N X-Gm-Gg: Acq92OEF8ivJIBdqV5JmuPQJi7Outx/brZbyjEbRjf5rS+wJld61PEGZ+5VPQwj2QmZ cd/e316EZXj4pkxMycmKIhTxWtbo006A+NmfXkHF9BvxnScxmJS6hvD3XHeiBGp0mhdnzecurG1 Qd1/p4dg+924FJBA0sSQnbq/T/lWMlySr7vesidyaCs1WCEzCOZei5Jw9oFmQKWhZYpsHaDMm5i W914lpj5gjlKgmbhRIHq0e2E1CdDU3AVQEP8UMgFV1GnI+ixXwVbjYazqvfhipKwQC7qFzgup9b cwAuIWN1v10KaMjYuCqLGZQDCzN4GDWMRFbNkZ2+K7ppNMx/nb4tFtDDTUpfnfDU09PYpdP/m3/ 8R21Gwhzrv7Kz0KIcnKAltPprDwQtsMl9wAWYPzrEYQ1rJHFJPZfQu6aH9w86DWeY1iWPBVhKP0 RJvuMOGnUG7q3M9fNY8gLIIv8VGpcEjfYsQQoeXQc9H/qjJhCWgYAWEDPl7p0HUcFtg0AulRs7+ W9C8K3PhblF X-Received: by 2002:a17:907:75cd:b0:bd3:897c:7800 with SMTP id a640c23a62f3a-bdd25cee478mr1301782666b.15.1779977250862; Thu, 28 May 2026 07:07:30 -0700 (PDT) Received: from localhost (226.55.classcom.pl. [195.150.55.226]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-be8a8637bb1sm45031366b.39.2026.05.28.07.07.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 May 2026 07:07:30 -0700 (PDT) Date: Thu, 28 May 2026 16:07:37 +0200 From: Piotr Zarycki To: Sean Christopherson Cc: pbonzini@redhat.com, shuah@kernel.org, dmatlack@google.com, vkuznets@redhat.com, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] KVM: selftests: hyperv_tlb_flush: use swap() to swap PTEs Message-ID: References: <20260528094542.2529735-1-piotr.zarycki@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, May 28, 2026 at 06:13:16AM -0700, Sean Christopherson wrote: > On Thu, May 28, 2026, Piotr Zarycki wrote: > > Replace the open-coded swap with the swap() macro. > > > > Signed-off-by: Piotr Zarycki > > --- > > tools/testing/selftests/kvm/include/test_util.h | 2 ++ > > tools/testing/selftests/kvm/x86/hyperv_tlb_flush.c | 6 +----- > > 2 files changed, 3 insertions(+), 5 deletions(-) > > > > diff --git a/tools/testing/selftests/kvm/include/test_util.h b/tools/testing/selftests/kvm/include/test_util.h > > index d9b433b834f1..a66bc9ccba65 100644 > > --- a/tools/testing/selftests/kvm/include/test_util.h > > +++ b/tools/testing/selftests/kvm/include/test_util.h > > @@ -26,6 +26,8 @@ > > > > #define msecs_to_usecs(msec) ((msec) * 1000ULL) > > > > +#define swap(a, b) do { typeof(a) __tmp = (a); (a) = (b); (b) = __tmp; } while (0) > > This belongs in a common tools/ header, not in KVM's test_util.h. I don't see > an obvious place, maybe tools/include/linux/kernel.h? Good point, v2 below.