From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f172.google.com (mail-oi1-f172.google.com [209.85.167.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 25E46262D0B for ; Thu, 28 May 2026 14:03:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779976996; cv=none; b=LRLeNVIJ0TXaVTc7UnHkEiaFCMomafhI9rg3L+H57B1qD59W6g7kD5RtSGKS7lQid/uVrZePuCerTr7YSqdTsDcXoXXJTtR4Iz+yeh65nxfsfBJ+5Qoe6TLvjIiqN82L9neh83/7hSN9ZIjZjFQ61B0htNd1t5RGoEGhDyLvzkE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779976996; c=relaxed/simple; bh=UhfW80sle2YKirikOWRjeTGOLnc1ebIamFxQXTh+pa4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ea4MpEFk9Pe1cud0VnxMC48oy9t3y6T1j/WxPm6KOZksSGWtHhWeInLCGvNq+qwNvZCYb9m6JL83yeb4uVehpDYMEDRmYrlixqmJor1XrSgLr6ORRD+kESbDGWZjDz7kB7DRRjGc1r7JKGOWnHOwAnWquejMW1XBSjrxLQBsM84= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org; spf=pass smtp.mailfrom=cmpxchg.org; dkim=pass (2048-bit key) header.d=cmpxchg.org header.i=@cmpxchg.org header.b=AYJV2VuL; arc=none smtp.client-ip=209.85.167.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg.org header.i=@cmpxchg.org header.b="AYJV2VuL" Received: by mail-oi1-f172.google.com with SMTP id 5614622812f47-484ba8bc89eso8771437b6e.2 for ; Thu, 28 May 2026 07:03:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg.org; s=google; t=1779976994; x=1780581794; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=rO+A7GjX2+2QgmOEjNdtI+NV3B5SN9zhDQg6nEMiyz4=; b=AYJV2VuLBt2oRyq60ozTe6w83zbY6Kfu90WUbXYBMYXJXMJ500FmKgufkgJi8lj4FR 75liT9ysvV4TMjQ8m+ljyc7/ijIwnM04GprGLyVuXog4AadwXvNt1gljifkFN69sYFQi OLIUgpiZTmEB+0Qj6BZhdIN4j8pZ8KcNwLE8zN6juVmXSds8oC/OUqhtfjqTlyF8FDNx NAeopIOTdOMAOEYl0pFkXsQ3mVaVQG85Pc48L7A2Ww4tTD89kuz1B73OFuoOb56M+r76 yeBIpPtLpfBs/8MSc6g+BP7IlDFrK1FqbpuMCWD/YMNfQVxn89NCmxG+8cMflXLqBmbT Lv+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779976994; x=1780581794; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rO+A7GjX2+2QgmOEjNdtI+NV3B5SN9zhDQg6nEMiyz4=; b=jBnMJN5AQy9YoAEwHTHhBk43zzSeiC4uJOuhJ8UoUJsU9tR3bp/ad9QH8bSIdh9LHS k+1jRLMWUTBWd5osZ1vac5OwdLljqUqM7+CaedoAUX/R/AiLUZgJOLeLMBb05krE3sL4 O82+AffWqyjB02tYzJ92Tw7RCG2VbDMTBBG1AsHPwpWGD4fZPSfjl0fzrxzJROQ4nAh+ gOVDjaDPywh7UdnkobyCnTl1CKc5sJvkb162RFQ1KA5taF8IXKejFxlH38nE19+X+1gr NiYTQGau58QWbyzy+AM8zE3m8ONkdVx2LjHPCEvt51wz64r+vfnwrrzaVH1yYGhYG/s3 4tuA== X-Forwarded-Encrypted: i=1; AFNElJ8alNhX3NP7gGW9+B+Y32AiD6ogqUKsoXnHQ5+sJtaR30jeo/iqr61xwHP8GA3B6ph8VabZXVRd9e66OO4=@vger.kernel.org X-Gm-Message-State: AOJu0YyN/4JDtYu6U33zmAXANt0j//0T2rqLUahf8hutCQi0eW8RXkkK GfYba8gaLSLab8TECjau7Io6QdXLBHlWO8eZLxqpGjwCDLrsMGkkNNuBS/3vwfjn9yo= X-Gm-Gg: Acq92OF2QumMtetYMmI9Lzy5YTQd8DHzbZEJZwoifr7Gd2zgDl+sdutyefzxNdSM3R3 umOX/OINClo010ZmIf5qInZKluuCBL5yf0w/uAjWkRMcVe9dmypRT767hnio3EeOjC+p1XQIDVZ uuGKg+o8nNRbRQsoE1XH8k2bQ+nvW9dBUEh9ltXAagustiMqi4xPEJX+atoXSj9VTd97YrfIybe i1GxIzBu2Nj7mrVrdRHpSmCZ226rVxm7zFMCGX7THhwx28Y5JOOlcl6XchFSRJmdhVJJ++PDyLU o3EtzXBv+fM2D1f6wpcKiOsYhZLAYxSaLFJSUpezf5G2qg1i+4FdFYRN8KBzWHUu0XdaNt6CFi5 jEFcuVsPK8kKXHyuvSTYqtiJwLdxuRBuSbp7XtSjDpSq5h8Tvz2FiKlehYPsyICpgNemKjn92LW x1PPy+OnusDzJg6Tjhdcwj0v1aPINXPVe31jOSDAWBlJE= X-Received: by 2002:a05:6808:191a:b0:485:48da:132e with SMTP id 5614622812f47-4854a224419mr15508945b6e.27.1779976993865; Thu, 28 May 2026 07:03:13 -0700 (PDT) Received: from localhost ([2603:7001:f100:500:365a:60ff:fe62:ff29]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-51706af4fd2sm73661071cf.25.2026.05.28.07.03.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 May 2026 07:03:12 -0700 (PDT) Date: Thu, 28 May 2026 10:03:12 -0400 From: Johannes Weiner To: SeongJae Park Cc: Andrew Morton , David Hildenbrand , Lorenzo Stoakes , Shakeel Butt , Michal Hocko , Dave Chinner , Roman Gushchin , Muchun Song , Qi Zheng , Yosry Ahmed , Zi Yan , "Liam R . Howlett" , Usama Arif , Kiryl Shutsemau , Vlastimil Babka , Kairui Song , Mikhail Zaslonko , Vasily Gorbik , Baolin Wang , Barry Song , Dev Jain , Lance Yang , Nico Pache , Ryan Roberts , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 9/9] mm: switch deferred split shrinker to list_lru Message-ID: References: <20260527204757.2544958-10-hannes@cmpxchg.org> <20260528070807.144064-1-sj@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260528070807.144064-1-sj@kernel.org> On Thu, May 28, 2026 at 12:08:05AM -0700, SeongJae Park wrote: > From 23b5800dd49085707baee5774b74782c3e424f24 Mon Sep 17 00:00:00 2001 > From: SeongJae Park > Date: Wed, 27 May 2026 23:58:07 -0700 > Subject: [PATCH] mm/huge_mm: define memcg_alloc_deferred() for > !CONFIG_TRANSPARENT_HUGEPPAGE > MIME-Version: 1.0 > Content-Type: text/plain; charset=UTF-8 > Content-Transfer-Encoding: 8bit > > Without this, UM mode kunit fails like below. > > $ ./tools/testing/kunit/kunit.py run --kunitconfig mm/damon/tests/ > [00:00:02] Configuring KUnit Kernel ... > [00:00:02] Building KUnit Kernel ... > Populating config with: > $ make ARCH=um O=.kunit olddefconfig > Building with: > $ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=8 > ERROR:root:../mm/swap_state.c: In function ‘__swap_cache_alloc’: > ../mm/swap_state.c:468:26: error: implicit declaration of function ‘folio_memcg_alloc_deferred’ [-Wimplicit-function-declaration] > 468 | if (order > 1 && folio_memcg_alloc_deferred(folio)) { > | ^~~~~~~~~~~~~~~~~~~~~~~~~~ > make[4]: *** [../scripts/Makefile.build:289: mm/swap_state.o] Error 1 > make[4]: *** Waiting for unfinished jobs.... > make[3]: *** [../scripts/Makefile.build:548: mm] Error 2 > make[3]: *** Waiting for unfinished jobs.... > make[2]: *** [/home/lkhack/linux/Makefile:2143: .] Error 2 > make[1]: *** [/home/lkhack/linux/Makefile:248: __sub-make] Error 2 > make: *** [Makefile:248: __sub-make] Error 2 > > Fix by implementing the function for CONFIG_TRANSPARENT_HUGEPPAGE unset > case. > > Fixes: https://lore.kernel.org/20260527204757.2544958-10-hannes@cmpxchg.org > Signed-off-by: SeongJae Park Whoops, thanks for the fix, SJ. I'll incorporate UM builds into my final compile test before sending. Acked-by: Johannes Weiner