From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6268636F8E9 for ; Thu, 28 May 2026 14:14:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779977685; cv=none; b=ddYmPOMpCe+mbwAsjqX46deUB8K4KghrZ+7CoqJ8lLIppLCk6NzzAKE7+5u+MQBW4tk8ii+LWG1UvZdf2BHhCHQ3uIZ7D034oAs2jcL12qN7NvRQ+ZKrcgMT5fruSDut5pvgywff32YCTT9RTVCuNK+gs5q08mGGIL5uMztvJsk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779977685; c=relaxed/simple; bh=rdPGG8pktzYfsd4W8n81NxemFwnNGSn28UK5dAbJa5c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Wleh2FgqUhz6T2WHQc4M4ykiPllfULLHKKrlnAk4L/0GRv86ZdbXBmd36r4S6GSm/9E6A+tDft3Kogtb6bK8EVvu0wV0FLRLLAzf9rTE8R6iFqipCPa1jerZ/n+WxQXCcH1v99OO3vkZN7qAxckZdXGJ8HNA1EF754wwQCbKkls= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qQn/JS3T; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qQn/JS3T" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-441209fb77eso7966094f8f.1 for ; Thu, 28 May 2026 07:14:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779977683; x=1780582483; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=t5ZWNU2/v1WVVM5yKXhZz4uBk/9oPZrNGdrmkhMBSCs=; b=qQn/JS3THjBWSZVSuL5DUZvRxEkAmon2bi8cjHbqptw9161hpod1WBFMCnG2QwQS3Y piMPKQpacW/2o3uTvy6z77KANvfnfIePqZVP8THfQo3h5wsicCIHCDgRMJz3mlh5wxqN 2jtzaveZxR6MyvuoXC+sjrNOxFIkJc/Bzp1MGeZjesfFaXfDZSWuDj1fpDV13rxmlr4z UCqHjYu6TYKHm7qvqfcuh632DgM3RdfeXrFHyQ8swJZt1qitwOVP8J3ZhvRZxCLf5q+a tk4qD0//LnAEbvAnefRBkGh3XZ5c6yYAKkJZySJYPVzcSxin7qcaNMOKdUTpvJ4BU2f1 3udA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779977683; x=1780582483; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=t5ZWNU2/v1WVVM5yKXhZz4uBk/9oPZrNGdrmkhMBSCs=; b=Y9/vb+SlUe3lGhPLo+ygxK0r1tdDg8ZkFQ4Ub3kP1L9dfu7H21bE6U1c4++clGH32e nJRg2ISmJgRtOAr85WJyJXUogQ4BaLD/OiH3883MdW8QqUHzim4lORnJuAkh55C2fmkZ NGMeuis8TYvxBc08q7bqcqXh6f8GBeWEMHwDKqTPmfWNpLOZaRgvU0pq5tN8UKmRgSis MgEjbHQWUAWPsHi67QHCmSNUllINd5+hCZgZKVs18blaS/6d4vBPY9B+5Q9VGKtDirBQ YY9qGyfM/SIGW3qnI6paiVHHW7tH3YYxXACIE53BVkAb+5ZVPWnuy5dHjzBZY+TYBMl0 K+1g== X-Forwarded-Encrypted: i=1; AFNElJ8lpkBHNUwI4HhYFawqRlTh8+NbcwirYOkeUXv8/FQ/TTYyKk251E+9e1GDyW0Xt8ClUyLOCCQi6M95XEA=@vger.kernel.org X-Gm-Message-State: AOJu0YzKvbU8l+6qHyLdJrlg6ej1CwIwKyz4X6nHdYqxXVoNEvggHhrE v43CT6VADsPQHzMIMKg3Xjtc46Zz4dsZ2mxABfs3Y94ffE6iuu5A6ds/WxFQLnDC X-Gm-Gg: Acq92OFf5kBtszBTr46Lre5ouadm+wa3d61bHG86AK2acV6YP+/pa56v8emsA8q3VXT Fodtkxi8aSBJWWYNTInJlgM2eKgns+vV/Thsx4z0AM0rHKyvRfw27jEgF4kQVyI4QvbRgSsJjvx 8YNghJMxdysrzHxRminWeRFvtk4xoJVlSdEf4+/xKn6OT7cfcA28j4m3bKicDfD7+7McOujTGpA +qxFb2i5NTf+dFK0gHpFW0dZ911bT59zyuTTGlMWiLhJoXPzeOJq/7ocJNtP1WxAEnZUdftRVZ2 3e2U6eT3b2gij0xZRRiwrPn91CTLTFbxtDFzs4Oag4gznUJXU9H58/qzpcO/SJdNpxEM3Jh6F5s WmwFLki1g4bgtP8JTDoWNryXX/M+gdKtavN/Zqmu3sxqiCQd8Xc63Eil0UfGoCrXWvFcKEMhvWi kzfZ9kHTnba5/2lmSWbnR240yrWTHkgUwqEw== X-Received: by 2002:a05:6000:29d7:b0:452:bc74:b129 with SMTP id ffacd0b85a97d-45eeceda8bcmr1325768f8f.16.1779977682661; Thu, 28 May 2026 07:14:42 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45eeceb5b5dsm2333753f8f.28.2026.05.28.07.14.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 May 2026 07:14:41 -0700 (PDT) Date: Thu, 28 May 2026 17:14:38 +0300 From: Dan Carpenter To: Onish Sharma Cc: sudipm.mukherjee@gmail.com, gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] staging: sm750fb: rename setAllEngOff Message-ID: References: <20260528133627.10850-1-neharora23587@gmail.com> <20260528133627.10850-2-neharora23587@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260528133627.10850-2-neharora23587@gmail.com> On Thu, May 28, 2026 at 07:06:27PM +0530, Onish Sharma wrote: > Rename setAllEngOff to set_all_eng_off to comply with kernel coding style > and improve readability. > > Signed-off-by: Onish Sharma > --- > drivers/staging/sm750fb/sm750.c | 2 +- > drivers/staging/sm750fb/sm750.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c > index 8f01b3c63fe8..716a8935f58d 100644 > --- a/drivers/staging/sm750fb/sm750.c > +++ b/drivers/staging/sm750fb/sm750.c > @@ -848,7 +848,7 @@ static void sm750fb_setup(struct sm750_dev *sm750_dev, char *src) > sm750_dev->init_parm.mem_clk = 0; > sm750_dev->init_parm.master_clk = 0; > sm750_dev->init_parm.power_mode = 0; > - sm750_dev->init_parm.setAllEngOff = 0; > + sm750_dev->init_parm.set_all_eng_off = 0; > sm750_dev->init_parm.reset_memory = 1; > > /* defaultly turn g_hwcursor on for both view */ > diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h > index 0492b1afbb11..e8885133da2e 100644 > --- a/drivers/staging/sm750fb/sm750.h > +++ b/drivers/staging/sm750fb/sm750.h > @@ -44,7 +44,7 @@ struct init_status { > ushort chip_clk; > ushort mem_clk; > ushort master_clk; > - ushort setAllEngOff; > + ushort set_all_eng_off; > ushort reset_memory; > }; There are no users? Why not just delete it. regards, dan carpenter