From: Tejun Heo <tj@kernel.org>
To: Marco Crivellari <marco.crivellari@suse.com>
Cc: linux-kernel@vger.kernel.org,
Lai Jiangshan <jiangshanlai@gmail.com>,
Frederic Weisbecker <frederic@kernel.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Michal Hocko <mhocko@suse.com>, Breno Leitao <leitao@debian.org>
Subject: Re: [RFC PATCH v2 1/2] workqueue: Add warnings and fallback if system_{unbound}_wq is used
Date: Thu, 28 May 2026 04:23:13 -1000 [thread overview]
Message-ID: <ahhP0e9V4YxyZ_wD@slm.duckdns.org> (raw)
In-Reply-To: <CAAofZF7OYHiVbrtePHgcmOns14O75fqNUzDYu2-CExj3Yc+xaA@mail.gmail.com>
On Thu, May 28, 2026 at 04:14:03PM +0200, Marco Crivellari wrote:
> That's maybe a silly observation on my side.
>
> If I remove the checks from where I placed them and move them deeper
> (__queue_work() for example), I won't know how to print the "caller,"
> making it harder for people to understand which code is using the
> deprecated workqueue.
>
> Printing the stack with dump_stack() is not doable.
>
> Do you have suggestions?
For workqueues, identifying the work function and workqueue name should be
good enough. It's not like these are difficult to find.
Thanks.
--
tejun
next prev parent reply other threads:[~2026-05-28 14:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-26 15:00 [RFC PATCH v2 0/2] workqueue: Add warnings and check WQ flags usage Marco Crivellari
2026-05-26 15:00 ` [RFC PATCH v2 1/2] workqueue: Add warnings and fallback if system_{unbound}_wq is used Marco Crivellari
2026-05-27 18:32 ` Tejun Heo
2026-05-28 8:45 ` Marco Crivellari
2026-05-28 14:22 ` Tejun Heo
2026-05-28 14:14 ` Marco Crivellari
2026-05-28 14:23 ` Tejun Heo [this message]
2026-05-28 14:57 ` Marco Crivellari
2026-05-26 15:00 ` [RFC PATCH v2 2/2] workqueue: Add warnings and ensure one among WQ_PERCPU or WQ_UNBOUND is present Marco Crivellari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ahhP0e9V4YxyZ_wD@slm.duckdns.org \
--to=tj@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=frederic@kernel.org \
--cc=jiangshanlai@gmail.com \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marco.crivellari@suse.com \
--cc=mhocko@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®