From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC3E231E82A for ; Thu, 28 May 2026 14:22:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779978123; cv=none; b=phXrVT2LfFLoa9CQ0ywQLOrGsk6uIQUQrmCH9Ugc0qDtrXu9n7BwzSbg/dEF7aqOS7qFK+z2wtO6KtCaNRuTpLPqU24cur84+Q7G+D76vSaxUIVP75ScOmRp66s6kTZxYcBW7VnXVb96GiWgsC2RpFZ/Uifh2NpB4Kx03UtrkPE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779978123; c=relaxed/simple; bh=IkcEyUWYUbq8Sme4sTLXAXk0TzcJKNN+Y06A25+NrY8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nx924JKDZXtQ67+6J9bGHUokiofy0oDO3WpQfoyGx5eQ7HLUAvdEBjziZOfKVjl8hNGK1J6PlcseXm1sIuQaQRTN4L+/sV0i4Y2YTfdy3hGYHQ+5m0eoWlD447y4ZqnkyE4qV5CVLF5CMNLaGL7AOEPXjhXsxdHPcew/mKTaB94= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=SdCniI3k; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="SdCniI3k" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 123B41F000E9; Thu, 28 May 2026 14:22:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779978122; bh=NCLckmY89Rqs52/VxsqtyVCKU7PuUU3SgoqmhNUH/iQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=SdCniI3kucO8hz+t42eEmeH6a5Y9cbTjrLDfWaNz6LsbvvnAo5T0Bm2+DKnQ0Yht6 RjdOzTbEY+zYmtXyNT05W6U2n7e18rO4V05bteeVY6H964h+1nmMNbcgrd6P/vH8DJ hnVTS5jvQO/gB063e2D36KR4jqxZh0aDK9aha7uYdyK17EDjm0dmXYydk+OXeOsryV BDvqKBhx8D+3muusgJoLWgbGdvw6GQYO6t4wzaSMPuny6muhgsLMXVvri4nttOL9wu iMSHB1E5WXepj5eIyYzB8PlfFLoUioKAbLszgF39RDVEDPEcU9+PzIAozjmmbQfaNa jhCYYBflQVrVA== Date: Thu, 28 May 2026 04:22:01 -1000 From: Tejun Heo To: Marco Crivellari Cc: linux-kernel@vger.kernel.org, Lai Jiangshan , Frederic Weisbecker , Sebastian Andrzej Siewior , Michal Hocko , Breno Leitao Subject: Re: [RFC PATCH v2 1/2] workqueue: Add warnings and fallback if system_{unbound}_wq is used Message-ID: References: <20260526150041.365392-1-marco.crivellari@suse.com> <20260526150041.365392-2-marco.crivellari@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Hello, On Thu, May 28, 2026 at 10:45:23AM +0200, Marco Crivellari wrote: > Hello, > > On Wed, May 27, 2026 at 8:32 PM Tejun Heo wrote: > > [...] > > > + /* > > > + * NOTE: These checks are here to assure that no users will still > > > + * rely on system_wq and system_unbound_wq. > > > + * They can be removed along with those workqueue when the > > > + * time comes. > > > + */ > > > + if (unlikely(wq == system_wq)) { > > > > Can you add an internal flag to mark the workqueues and use a helper so that > > the warning messages aren't replicated in multiple places? Also, do we need > > to have the warning on delayed_queue? Just put it in a single spot where > > they'll all converge. > > Yes, that sounds better indeed. So I can place the warnings directly > inside __queue_work(), calling an inline function? If it's just a single palce, open-coding it should be fine too. Thanks. -- tejun