From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27BB92E7379 for ; Thu, 28 May 2026 20:21:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=192.198.163.9 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779999712; cv=fail; b=aHGNGpnXf6KYoV+dJR+g3sL3f0MYYaHsByUucxfa0yhz9pWWbzqL8w3POiKnQGBBUeukcUcaVPNvxLON1V+JjuqqJnRu6IqW2znhNd1mxHGlo5/kMT+EWXh0VPTt5mB0oySDDHce1McOJv8Zva+acD3skELZTok8CN/truSHCpY= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779999712; c=relaxed/simple; bh=i2CVeVk3qcU9KIdX/2WFQTwU3Nm9hOw4RGLrl4PegP0=; h=Date:From:To:CC:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=jWDuKbXgdGhLx6X1pE51j/HlkNi2xh1S1/sW1+7gfIGo71RrZM5ROIUbkZG7wok7wGCCT3Qx6eRebLI0+jAsBLE+d6Taq9EmAmXuFAIgow9QQ4jA8/pYqkCJwZX6H//GfYkNTVwUyRXCZIkKBS+/3S+iEXR5ccDQwr7qMHn1RSQ= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=DmVsMlTF; arc=fail smtp.client-ip=192.198.163.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="DmVsMlTF" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1779999711; x=1811535711; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=i2CVeVk3qcU9KIdX/2WFQTwU3Nm9hOw4RGLrl4PegP0=; b=DmVsMlTFuWTA09ugCvAhzgj6UeUlfDUNrdxXpLutj4OYQ9PhSLsXZ6DE N71x9Rg6+jvBk151aVi9L3VPjqRi4w/QxMI+avoaCXdrNtGTUtRf8fPJL lwbnVbQ/bOVyqSgDKkt/M755r3XHEe5YYgpyRircdBFxvN+zRfpYHzdv2 NHh97K0X1wHq4n3f8G211rf7bU9YW6iZhfDxmxJs4opiUZYnP+72DCRUU mJMNWDE+BoF4TFA2P7lPfkzdrAVERo+oQgnsK/U/aADth29NvqAYlTzkE ZEq36RfySIcp6fCkDuWICJQfXIOQi/ZGhtJpU4BRkGaO57BHYGBZoE5lG g==; X-CSE-ConnectionGUID: XXHHrktVQwCYpXc2LyKQVw== X-CSE-MsgGUID: OTL0jIjsTUGSJiFiJQthSw== X-IronPort-AV: E=McAfee;i="6800,10657,11800"; a="91539165" X-IronPort-AV: E=Sophos;i="6.24,174,1774335600"; d="scan'208";a="91539165" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 May 2026 13:21:50 -0700 X-CSE-ConnectionGUID: os0y/cLQTOatJqDPFi9o4A== X-CSE-MsgGUID: NlEi6ygwTw2XsxOPP28eAw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,174,1774335600"; d="scan'208";a="272977659" Received: from fmsmsx901.amr.corp.intel.com ([10.18.126.90]) by orviesa002.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 May 2026 13:21:50 -0700 Received: from FMSMSX903.amr.corp.intel.com (10.18.126.92) by fmsmsx901.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Thu, 28 May 2026 13:21:49 -0700 Received: from fmsedg902.ED.cps.intel.com (10.1.192.144) by FMSMSX903.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37 via Frontend Transport; Thu, 28 May 2026 13:21:49 -0700 Received: from CH4PR04CU002.outbound.protection.outlook.com (40.107.201.60) by edgegateway.intel.com (192.55.55.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Thu, 28 May 2026 13:21:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=RhQIZjyzHuUKpr2qOUpeWVXeK+SalZvH6QynOGuUgR+VQKJwOeejOiicpup2+zvC5GWiJ3CJZeKzYJW6DONI3uM1XpiDIinc0VM8MeuIcM1WEEtp3K1TutpqG1FaXAqlXV/TrvyEKic+BlOXF8ejOPud7l8CcW/DXbMF54F5IsLqrsbVcHTVFm50o7YvneQOAp9ICIMlq82QECVUCOFlh7STI+IvvSE8wad8efW2BOSLP1nH9AC18u6cHaPvzpyzlD0nsiElglEu0Fcmn6hCL8q5yr3bsxa8GHgRun/cKKmUwnfL8deNdp7bqYMZrP2Iu/fTEky3fGcfjMzQRdFx/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HzlPs/v390Nf9iiplmvjXhDsHuvaNUSL1rek1dRSOBs=; b=w8KVJkA4nrbq417IdSKUjZzOFVotb0es5Ey8xPfA3RWaT2zSTbDx6T24yj42BFaEr0svZkCmUSViwQCQbsa1YcZ7JHuvwFU682OQw1DSmVfpy2aNWoX1J2HWw3ogvZZPBRtx6gvCreGSNO0hpXCzpk4PipIGQA5vCgVNWO66foC6RPr9A+YR1L65+R/UYra563SYnfaPpMSOcvkHETLnEAEIiAjynaMSA4wqOycqDS+qLku26GZHlVDw417BzFLWWJNbrQBASGoYNqXNg6F8tVsjpZfE5XotCmWclkQaDhSSYPV0znt3eRvXWpSMeRwMgQ4IC2rB70ytnaqRjOswtQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS7PR11MB6077.namprd11.prod.outlook.com (2603:10b6:8:87::16) by CY8PR11MB7899.namprd11.prod.outlook.com (2603:10b6:930:7e::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.71.14; Thu, 28 May 2026 20:21:41 +0000 Received: from DS7PR11MB6077.namprd11.prod.outlook.com ([fe80::5502:19f9:650b:99d1]) by DS7PR11MB6077.namprd11.prod.outlook.com ([fe80::5502:19f9:650b:99d1%6]) with mapi id 15.21.0071.011; Thu, 28 May 2026 20:21:41 +0000 Date: Thu, 28 May 2026 13:21:38 -0700 From: "Luck, Tony" To: Chen Yu CC: , , , , , , , , , , , Subject: Re: [RFC PATCH 1/6] x86/resctrl: Parse ACPI ERDT table and map RMDD domains by L3 cache ID Message-ID: References: <44d0db816f964ffb51367cbf0a4bb982786cac8c.1779872016.git.yu.c.chen@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <44d0db816f964ffb51367cbf0a4bb982786cac8c.1779872016.git.yu.c.chen@intel.com> X-ClientProxiedBy: BY5PR03CA0007.namprd03.prod.outlook.com (2603:10b6:a03:1e0::17) To DS7PR11MB6077.namprd11.prod.outlook.com (2603:10b6:8:87::16) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR11MB6077:EE_|CY8PR11MB7899:EE_ X-MS-Office365-Filtering-Correlation-Id: d74d17e1-3b65-43bd-8d18-08debcf6ba7b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|7416014|376014|4143699003|11063799006|56012099006|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: KoJopFg/zrsYFI2td+8TWJS9yjKhBnGd9ZsGlYrEGfgX1oHRKMRD5SSK2N9fKo0+Z9QZ1dpbt95B3zCs56SJU1y5oarQOCRwQZW0jko2X3UvV4aJSfa9l31qNaKa8P9zutHTmKz4OCesrYYgDfXEeDVwX7h7prhHksbPwzHNlSR9QWIFi6FjaWzqo9J/A7avWmsw+gUX+inpqNUk61J0+BBhKvbHGegnFQYLPNlVSG45LixmPBx3oEaEhpO2NNtZSEFXnpboE+leXWHms658PgmGKhw3MJ6wn8Fk7+UjalA1HFLwNb5DIFo5uCllrNqsqS7FdmPzoiHHDYT3+VGMAXNefh3xcSC4Vj/33RmGsFz8FsCkhDVe3e88QBLedXyaqUDaf23sbTqh3WK/33chWDw/QOTDog7As7D+r3D+S8UIq+VfvYmR61XOFXSNwRaC1Dq9d/6kIMXcLDoa9Ca2UpRceXD0qr6TTGjeS73uHXJ6MNuDQcYFFqcGM9JUtyX4gouJK2Y5tYzY+EhBkIesFGopj4uhDvWV0FLj4ixb7WJDCzSAJs9EYFYiZsm10DKZbEThgk2mysCmCpPD4TDiJbQYa7JElwvj4ATYtaNLwsTqfJ7gK1B+lscy926kTZPBb8qDlOdlrugdmzqM+2aXaeuXHBbgEUV0tJnyM4UBrjL8333ENC8P0j8U4VePx4J8 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR11MB6077.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(7416014)(376014)(4143699003)(11063799006)(56012099006)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?epUZrJcatF5+C7amdBGOYUgrzCuUco0+VL5vOrvwS/NZxWMlj+JMyvczpYg7?= =?us-ascii?Q?RhcEUKS21X36phtquWxOkqP0FxwATFd5lN5m+9Kk6/nEqbWWdVrUovwGNCya?= =?us-ascii?Q?OuQrEJqvMMa8kO2dflUSR2IFq0jX7zdrRsErGJD0NIcfVCq3upJvm8psgose?= =?us-ascii?Q?Ur0ae3yi5ENJ7MFiYn7vhQeWzxZgg07kwhbh38B/GGzkPWgk4nLelyHPWDDF?= =?us-ascii?Q?i1td7A2ppUugIlmr5IBJIbStUwu3fTc2a+VNIDxDJlss9zIHsmLVcyo6GLy9?= =?us-ascii?Q?dZIF188JsKoPim5ijsnpM1OGdwRpASntMsJctC1pZ2gOIvwKwuAq3gPZpXVR?= =?us-ascii?Q?U2qFvRfAkycXTVXAde/jQ+D3nUgyqoEkiMNNE2h6/nzVZwXfDeJABJzwZ0hj?= =?us-ascii?Q?dNl5s6PvlGdcq46f6jbUq7ivrwQh7dn6RQdJO0FlWO7boWdfLf8otIKKP1vp?= =?us-ascii?Q?NDURrSfv8pA42B1AEzNfA3H5cE7WVoEk0FjAXhyVUtgzGCNcRAuKbZ5uVEVi?= =?us-ascii?Q?6WVPEAJEKG9wpgwInTOGX0LFDsXzkVwunlPDBSckKIUGiXN1ID9eF+VLxAcx?= =?us-ascii?Q?oZuwiYQLE3zGZM9DycxpRGPfCypXhP62YE817I7RVpAERyJ40uAkp3/rJ9vt?= =?us-ascii?Q?5fLilz1nobtAi+54aG+GnRrOvccFg440+668yuL6h9orqTN3yb4SzUvgtp6d?= =?us-ascii?Q?THB+Ojd6mzYD738zHGdStZ4MEvgGtnA3XeKsyZxZSnevuFCNG6Eb+7cOXkJX?= =?us-ascii?Q?1LVhusrAeC+frX+Rgf3HN9F0Qz28gYyPeAS4ZZd8b36137oA5obQi4t1LoZW?= =?us-ascii?Q?TrGurq6ATZpYGB5qwmcivTpLy5/SAhpDU/p4I4W2VEE09tau5mJGFjicReso?= =?us-ascii?Q?zc7ykkrHgwUPlDE+B886Kmq4Im7NniUtaSHfxmDoNd+3KahpQuOSlqqWTg5e?= =?us-ascii?Q?DqT83MGIty6oS8dcsq48v+n7ANZLdsUmQv6PnaRCgfIrtOp56MZX5DgyODVq?= =?us-ascii?Q?oZpVRs/0meuNK+yEDzEcIqdjwx4aUS8wSwrpNZ2/81Q22GuFTKVH+RPM2yp0?= =?us-ascii?Q?5YZhuC3vHiimQM8H+qoyHu5xiiQHDvmQbpkO1eGIH9+4S45tcBXyyEzhg7o8?= =?us-ascii?Q?R0ohXNzJsdHabRxLqRsKBtFVY69gBGXKs8j7DFKLnlIjfnfaGvwgHkN6E0oT?= =?us-ascii?Q?+akQjkGX8EC0vZlhh+GNbyJZuP5Dd9Kk/M8N7v6zQ82jryirtOqcBavyO+EG?= =?us-ascii?Q?U6idEcyIiRdDKSyQjs0LGLrfVrUttZPBXsxI4uWCVjOh7W1xxSKwKYApdlyz?= =?us-ascii?Q?ompI2ijBv4mj3A8Q71GhWXEO9rha3sqUywocHcam8X68RWd6sVPWvhvHcpr6?= =?us-ascii?Q?lzqCWSB3VMTcF3LI1V5vjIOOJY+OHa0HqJjrYjRjIJgLltMJPnt7XAC6lzEp?= =?us-ascii?Q?ZXG+FH+7I6+ZoZWhjfb04Bes1QqEejYdmcOp6ZcqGrMkNmP5Ox2W+YM4lPZT?= =?us-ascii?Q?ZxlNSfgaGCBPXQBX00d/lLPqUgQvKf8vTCrNuT4EG1iE4Zifih0AwM+/EbXr?= =?us-ascii?Q?/tnvgVYXcRyp4TWEmqiqoX/8eERgn9qjIlIlHb+O7m2sS8gouVLd5PwJ8Fsx?= =?us-ascii?Q?tKziCkTLpQ8f161BRe0XL4P44mLoLZ65hysRXtwdCKej5ParGZzX01L9yXfs?= =?us-ascii?Q?uNiP+XW5/4xnFPd52g8aimaRnEypa7A021nwmxVU02A08WB9FwGpIAGpNd+b?= =?us-ascii?Q?kpmM8ej4Pg=3D=3D?= X-Exchange-RoutingPolicyChecked: eV/WDea2L91WuUhhWCQCbLcT3w6IYX7YKbyTcPOIoZewLO2DYhYqsCSfahiCmsaXt9mfrKwXiaQ9eKj7DASqEMQnnVz5ftiSmCjZym4UYkqTnYdlzZKCNrzqaQKw4IOWIXCLDZu0Uw+QAYbf+x2v7rPa/HHP0HFb4FmAuMMCACS36TeAyx1balMI5Cse/53CBUCxRBOvrmW0wXVpDyvhhUiAY2yRQasec8AfMaoKq5Lc9TlNOSKVvIyeKWZalPnCSXQ/1enIJFamPPzuyPis7s5E1eIB3zYX+Y4YyLGGGR3JIS8CkEm8Dl9NLndMWY0S6yEXvIRU6FJK8FtiP7c0ng== X-MS-Exchange-CrossTenant-Network-Message-Id: d74d17e1-3b65-43bd-8d18-08debcf6ba7b X-MS-Exchange-CrossTenant-AuthSource: DS7PR11MB6077.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 May 2026 20:21:41.1413 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0irDvZ/PtAlqWXMfdYMRTtBiFKtxgM32E5tGOFio7D2gNHNOxnETF+CyDch+6aZiCy9YAo/WkaFKRqNROnGKoA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7899 X-OriginatorOrg: intel.com On Wed, May 27, 2026 at 05:26:54PM +0800, Chen Yu wrote: > +static __init int get_l3_cache_id_from_cacd(struct acpi_erdt_cacd *cacd) > +{ > + int num_ids, cpu, online_cpu = -1, cache_id = -1, tmp; > + struct cacheinfo *ci; > + > + if (cacd->header.length < sizeof(*cacd) + sizeof(cacd->X2APICIDS[0])) { > + pr_warn(FW_BUG "Invalid x2apicid CACD table\n"); > + return -1; > + } > + > + num_ids = (cacd->header.length - sizeof(*cacd)) / sizeof(cacd->X2APICIDS[0]); > + > + guard(cpus_read_lock)(); This file should #include (maybe some other headers too) to follow the "include-what-you-use" best practice (which is only lightly enforced in the kernel - but saves pain when some refactor breaks your code because the implicit chain of includes is changed). -Tony