From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5419933FE36 for ; Fri, 29 May 2026 07:55:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780041304; cv=none; b=R4RyShp/OP1vdNVn0UFwWxyN01i3LFkcdE9TOIMkzXjlkRO+WM39VImAXHqaR3IYtGwXoUWRwkQ0rpYfF7gYj3TBU58iOGXzijGrIOpkgDyyM3tXZiOjgGAuMxto5MsHmtQWpEtnv9ElBKw/nrjAA0a8GX5S5eCwzV4G+FSBBi8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780041304; c=relaxed/simple; bh=RkS7WzdVXZTKNqv2HuQwFG3ciFYmigOpDjNSH5EoriI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WmxnlpNSLdXPxNdLlDWvStnl+1emrVSLnoixVksffuRi9B9hMsfnVgTdbIQdzRFiz0kINmeBh2IBAMDCuufvw4zosEVVlJb9XJI/8kqnyQ02i9fCcY1UgHAiKOqg7jdhi4ASK/gWfGwGsf2C5Yqd9Wl2LdDBBTeU5L19MCz+C5U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=A2X0b66f; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="A2X0b66f" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4891e86fabeso45852895e9.1 for ; Fri, 29 May 2026 00:55:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1780041301; x=1780646101; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=rwrPCj2IqJEcRJugk6Ecz2xdcmK5e89mwdODai47RFE=; b=A2X0b66f2auNExa6ecfSSnPqJ/K9Rdknaol/P4/XVGqh2a81HKWwYAy9pkmvIHYdQr nbGSuvxvphfQwOLXIEd5qwVGT1MUwa3UY++v+Req/ml7mTausk6zpveVLKt2jm88KxWm 9SkD/By/2ESECbESTmLPTMoStSPzDhaoa0o2LD6loDPuc2KXf5FR2k5VqQd1Xg1YYbtS gwawovJsFTMm4DGpQ1EYYUlEMApcu21CM/ARIu8soNhIv/ISbmiSxeSMHbFmaTXocT/B fMTELZN1fMDJRpc65sQTFWvp2ijkVStAZzY4or6k8Bh+gnpEL0l8dF6GBcyD/570foXu cphQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780041301; x=1780646101; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rwrPCj2IqJEcRJugk6Ecz2xdcmK5e89mwdODai47RFE=; b=m3kfFnCWrweoqHYK5q4Vp+q45zeJHevlEJKOGe/htbBy9mT/MJiSSc+Ac8jYbGRN/i aYwJe61Q/6X4kEtKRhXbdu3smBaPPk6Ue221YBc0IoJ8o/uCjEY9G+flbtmXweRjTsY2 NPvroeaNF5qWC3ZgR4rXaIfDUfA6Tgoo/exyptCcKoxNTEzxXN0JURkUnEr2YADQh/4D uvHnL3R47PLDzgsi4tM6+tDaDzq0zszzIkKiJkZAejBPPvpe3I1GKBotStkcE/7d3POk VJJ/T86MJpomc0JTwLsqwyonToF6eaDdb0UhbYAH/V5Z5mpWDnf8utJJczM5r0E4N0Sh 8uMA== X-Forwarded-Encrypted: i=1; AFNElJ/uQrX2/zNprMNrHNETJTGWtiWkdVRcnEVrmhQbhmCYuCe1E8XvvQhZ31zshOp8Ooj1MkjejG73xzDqrac=@vger.kernel.org X-Gm-Message-State: AOJu0YxUieHDBZxjhHfGMtaeDsqBX2wQ0A7Os+b5cecwVcXEwgcnJcVa 8FBgzWdj43I+03aKbf0C2EE3JnGtEI6Sw4HNL7DbxC0y8UkP6oW7wz64rqoSBhhqABY= X-Gm-Gg: Acq92OEX8PkBMR0Pqf/JTABUevRPYjThJ8g4X9HlkZqWu3QgTAXk3ToMHwWugcTznQL lcDeRfdnGl09KRWLvtnJ0peRWFitExzm5k9pdIMZN76ZJxcMDs9qw8tekZfqZhjb6TBc1Lk3aHn zS3q3h/J1wxVdYavd1WjirGhlYKowPmGJf8ZCjvr/DhsEUkBVUOn2daNv+ipThyQGMlEBHNv+N2 Gssa3mEDezjQ8hYUJ0wC8EQTDxb48lhtS1NSom4jSs4GzBR+3xBxmNK8UuRhIXWty0iK/oQSFjz B/KjdFwg0BfOQYgCq615Y7pmNlmlVoAtaHjfptIzr5+DqlG0aUxtExCTvd/6tXWRpXcv5A1OD3U 8q270lPVnbtEhcCEPjYM2AR4gZ9mreF1zvY5r4Mg2uVx150zgm2xJ2tvINqwZxlCIMHUYv6t+nu kuOro/SAANlL3q4i7Ap77inMg9ztVdd2WqfJzoDVpnCO56Q39hSKc+lhZX9Iw2/32dVCJPcm36O HQCWf4IGOBaIR4kB8e6tli6AwP4tRG9RXss X-Received: by 2002:a05:600c:4504:b0:48f:be94:d82c with SMTP id 5b1f17b1804b1-4909c0b33fcmr30600785e9.19.1780041300797; Fri, 29 May 2026 00:55:00 -0700 (PDT) Received: from localhost (p200300f65f47db043f932d8b97293bf6.dip0.t-ipconnect.de. [2003:f6:5f47:db04:3f93:2d8b:9729:3bf6]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-4909ca65f54sm27221465e9.5.2026.05.29.00.54.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 May 2026 00:55:00 -0700 (PDT) Date: Fri, 29 May 2026 09:54:58 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Arnd Bergmann Cc: Inki Dae , Seung-Woo Kim , Kyungmin Park , David Airlie , Simona Vetter , Krzysztof Kozlowski , Chen-Yu Tsai , Marek Szyprowski , Arnd Bergmann , Alim Akhtar , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/exynos: fix size_t format string Message-ID: References: <20260527194525.45762-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="jnujdylfqv2kbd66" Content-Disposition: inline In-Reply-To: <20260527194525.45762-1-arnd@kernel.org> --jnujdylfqv2kbd66 Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH] drm/exynos: fix size_t format string MIME-Version: 1.0 Hello, On Wed, May 27, 2026 at 09:45:07PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann >=20 > The exynos_gem->base.size argument is a size_t rather than an > unsigned long, so adapt the printk() format string accordingly: >=20 > In file included from drivers/gpu/drm/exynos/exynos_drm_gem.c:16: > drivers/gpu/drm/exynos/exynos_drm_gem.c: In function 'exynos_drm_alloc_bu= f': > drivers/gpu/drm/exynos/exynos_drm_gem.c:69:49: error: format '%lx' expect= s argument of type 'long unsigned int', but argument 6 has type 'size_t' {a= ka 'unsigned int'} [-Werror=3Dformat=3D] > 69 | DRM_DEV_DEBUG_KMS(drm_dev_dma_dev(dev), "dma_addr(0x%lx),= size(0x%lx)\n", > | ^~~~~~~~~~~~~~~~~= ~~~~~~~~~~~~~~~ > 70 | (unsigned long)exynos_gem->dma_addr, exyn= os_gem->base.size); > | ~~~~= ~~~~~~~~~~~~~~~~~ > | = | > | = size_t {aka unsigned int} >=20 > The dma_addr in the same line is already printed using a cast > to unsigned long, so change that similarly to use the correct > %pad format. >=20 > Fixes: 11e898373fba ("drm/exynos: Drop exynos_drm_gem.size field") > Signed-off-by: Arnd Bergmann > --- > drivers/gpu/drm/exynos/exynos_drm_gem.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/gpu/drm/exynos/exynos_drm_gem.c b/drivers/gpu/drm/ex= ynos/exynos_drm_gem.c > index 297a93b087cd..8e357f2beb9e 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_gem.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_gem.c > @@ -66,8 +66,8 @@ static int exynos_drm_alloc_buf(struct exynos_drm_gem *= exynos_gem, bool kvmap) > if (kvmap) > exynos_gem->kvaddr =3D exynos_gem->cookie; > =20 > - DRM_DEV_DEBUG_KMS(drm_dev_dma_dev(dev), "dma_addr(0x%lx), size(0x%lx)\n= ", > - (unsigned long)exynos_gem->dma_addr, exynos_gem->base.size); > + DRM_DEV_DEBUG_KMS(drm_dev_dma_dev(dev), "dma_addr(%pad), size(0x%zx)\n", > + &exynos_gem->dma_addr, exynos_gem->base.size); > return 0; > } > =20 > @@ -80,8 +80,8 @@ static void exynos_drm_free_buf(struct exynos_drm_gem *= exynos_gem) > return; > } > =20 > - DRM_DEV_DEBUG_KMS(dev->dev, "dma_addr(0x%lx), size(0x%lx)\n", > - (unsigned long)exynos_gem->dma_addr, exynos_gem->base.size); > + DRM_DEV_DEBUG_KMS(dev->dev, "dma_addr(0x%pad), size(0x%zx)\n", > + &exynos_gem->dma_addr, exynos_gem->base.size); Inconsistent formatting. The first hunk used dma_addr(%pad), the second adds "0x". Chen-Yu Tsai's patch[1] was better in that regard. Best regards Uwe [1] https://lore.kernel.org/all/20260408064936.1342321-1-wenst@chromium.org/ --jnujdylfqv2kbd66 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmoZRlAACgkQj4D7WH0S /k4uLAf8CDNBSWkI/8nW1u/hhrBYD4t2URn0LO0re8mpGRHjxAyA2ted0Ag3jvDa 8F55jr1ySezFOkOTycAdA+yW6AiferDGR6YbeeJURQtgw6/OR0QQ/iHO+PC2ZyjC 9q6ls8fHy2K99TM2nwUh2SjbucVfCUhCXYL8iK88guLXcWdOfAyFJMT5Q1iQEhAU qW8lFER+hwe6VMeTZQk5CyqPhsUcYz0Pt+qVkGs3hOBbIL505NlsnPzSDgsE6kC/ GnmGyW63GGoVoyA6J1C6ybt/geR4ilr12gm+rZqKDU9Wydfwz/kfmA3sc5JzWVZT xF6rNWt7febUyDzSmbvzndFdKi1DcA== =vHrt -----END PGP SIGNATURE----- --jnujdylfqv2kbd66--