From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48430385D60 for ; Fri, 29 May 2026 09:50:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780048230; cv=none; b=tPVqXNxn7XWX4HvgryPzmz+lfj6S+coWGL7Ug3vrXbfSdEY4hd5Rv7bmkS+2Uv03+X4Sf3ZPnypmFYEzx6cKN/Tc4qxzseSl1lYY5w8mM83IlnirQpeF9t++WNCoMa2FFnEbH2fDWnGN1g8fU9b0SeD+/N2n3lJ3+qiFK1xQoa0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780048230; c=relaxed/simple; bh=noZUE1IsUXwbMFZP5oM/PyOkLNyKjBND2J+rs0wlh3o=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GBnw26DMA5Cn2REd1G24brbHWadN4CRkcJol4FIgGitEcK1XFlRrI/2ViwnQZekFuKBtXpdZlMzgXbFTBZLDRfxg9UTFqAvzFYdKWrRUyTUF1R5Rlkps5+bzu8uLMngntElAKzA3Wbg1huGi/pbr/CuDNmsv9FEzZIiJ/KDKgJ4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us; spf=none smtp.mailfrom=resnulli.us; dkim=pass (2048-bit key) header.d=resnulli-us.20251104.gappssmtp.com header.i=@resnulli-us.20251104.gappssmtp.com header.b=Uw8+YmgH; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=resnulli.us Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20251104.gappssmtp.com header.i=@resnulli-us.20251104.gappssmtp.com header.b="Uw8+YmgH" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-45eec22fab7so820760f8f.3 for ; Fri, 29 May 2026 02:50:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20251104.gappssmtp.com; s=20251104; t=1780048225; x=1780653025; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=noZUE1IsUXwbMFZP5oM/PyOkLNyKjBND2J+rs0wlh3o=; b=Uw8+YmgH0VYSod7/gUgbBpnNZhzmW3Y+wSosHBWnPyjXK2zzJ3kCrYrkk/GrZnCX5g GhzYHAn54BL4awyJFYIzc2jc2SaoCAw2utl+SLIi3kscJtPtkZLvmoMRrDeGU/BDAlzJ smmWUHezOcC+s0HkVe0DzS754kYY7qKKaZ6UdAnmTiuJFLvAZ3ha6Lt+4btm5eIU6zcq FvS4qZAP9oFQuLFWYReUKNRhomuQ52eQxnp11jA9S8YNjGvzwRKkelwZKhvvd6dZpvA4 U+Z/IHEk8Muwa0t6nayR2Vh4M53L/MK3fybY6f4H/ZI7OQgrkwDF8KFiMlQJS8V77s+c A2xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780048225; x=1780653025; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=noZUE1IsUXwbMFZP5oM/PyOkLNyKjBND2J+rs0wlh3o=; b=J6LoUvZQheeTPE9el9/m2v3miE9VrZDyUp6w4I6m0gMEUCWX5WjdqVq9bokWeC2l2q i4xMhl6NZHhtZHTyGtJNXfYgUcq5XLv1vjFeqxRfg/kBrgxaG1i5Cg5ltxk3yUHUvsSA ly2qpRoy52V/GTKEGH2TstUFtMCio7PKbZB7SjemxPK0vbwfmUdhdXdSYZ8S7+hlU2Ig 32qyHiuG0k7X8oOOf2FeoESWkGwfXYlRc8/coiTsX7B+5Q+rjOCzRslV2PEA/cN2d0Lj fKyM+vXZ/XOUETA+wSPVLtvVzfzlQ8HNy+UTEVwQVIRBb4JaiCLgyiId0969h+ky0q2e gMUQ== X-Forwarded-Encrypted: i=1; AFNElJ/pXMCiEDuUGDN1EVTEmGxvPm9Glas4eNWANbenkMjW1gdWksefKZoCirdcxD9v3ZEjPMsTsXoZEu8ZtZs=@vger.kernel.org X-Gm-Message-State: AOJu0YwGHoIRRSR8GVny9+qdCHBklifCB1o+xE6KpbzznR1qvOz/ExY9 28W9fZG+c4/4bCuzKxyIPL8f1Edu5dqH6xdtOf+qh4IcN3SWzrqgblhjAmgHsyDNE8c= X-Gm-Gg: Acq92OFZmyYDzeNPwj1+fGSZftpZwSIFS2Wquc8JD+HPq9zZKUKlmJbYDB5w7RC2t6O zV2T9YhI6OQIVnEtm5/hGwb08ksyor/vJmf98e6a8YmgpTh1ZHeCxtcXFjAUlVmz9v9f5Hajehp svdHpLilycVx/nx6V+e5mRh52Cxnjm/0aNpEJgw6E3Fpt4N7lo/AeR6+4cy1KK3fkfSNjZJmJ1S dO12/f7kswtReklFkI7dYCW+RTwkbBIJujnjgrjZF/WC9sBUWnBSOVLA+UTlk97yY0bQ3aVo8kP 4h9VZ6qHx10B+x6SMm74apd91J5oKcNX+dS+Gm2j010LNwX9kvlr964GSVZfbwksN57c6estm9k VScdq4qLdRBoXfTnVh1JZ19kQ/ScpmU4FeVUq4MKY+f/cK3HX6vMpSzW4dicwgGmmCu2JTk+fAA Q6rvApQx7sv1LYOd83SM6B2OpQfYOJxr/6I+kIehy6Pw== X-Received: by 2002:a05:6000:21c6:b0:45e:7418:a3f2 with SMTP id ffacd0b85a97d-45ef14481a4mr2488243f8f.26.1780048225062; Fri, 29 May 2026 02:50:25 -0700 (PDT) Received: from localhost ([128.77.52.126]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45ef354bb7asm2425833f8f.20.2026.05.29.02.50.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 May 2026 02:50:24 -0700 (PDT) Date: Fri, 29 May 2026 11:50:19 +0200 From: Jiri Pirko To: Mark Bloch Cc: Jiri Pirko , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , "David S. Miller" , Tariq Toukan , Leon Romanovsky , Saeed Mahameed , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, Gal Pressman Subject: Re: [PATCH net] devlink: Release nested relation on devlink free Message-ID: References: <20260528191411.3270532-1-mbloch@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260528191411.3270532-1-mbloch@nvidia.com> Thu, May 28, 2026 at 09:14:10PM +0200, mbloch@nvidia.com wrote: >devlink relation state is normally released from devl_unregister(), which >calls devlink_rel_put(). This misses devlink instances that get a nested >relation before registration and then fail probe before devl_register() is >reached. > >That flow can happen for SFs. The child devlink gets linked to its >parent before registration, then a later probe error calls devlink_free() >directly. Since the instance was never registered, devl_unregister() is not >called and devlink->rel is leaked. > >Release any pending relation from devlink_free() as well. The registered >path is unchanged because devl_unregister() already clears devlink->rel >before devlink_free() runs. > >Fixes: c137743bce02 ("devlink: introduce object and nested devlink relationship infra") >Signed-off-by: Mark Bloch Reviewed-by: Jiri Pirko