From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61F27397B05 for ; Sat, 30 May 2026 09:36:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780133779; cv=none; b=o2OpD9nX6B2uADAjetocWSrOq111as+iNpdTreQU+BUTcdQO9oz6aH5Cr59I43+0eXTS/Qd92jsF1jUVBvnUpkoAAaE08CssCh0Vuy18q62pJVj3k30EDnWwd3vwZvA5kbg/jDLrGXWf0gkge+G+N4EWpiPPX+o8AQl73aFIoRk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780133779; c=relaxed/simple; bh=+0+8FiCd18kI8hiOaDqSaIdtuBj0B+wKf0CXrKOWjB8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pOGLOXPxNHscIsUAiuk2OXAbQ/ecj3yve/NgSua58BenO26ciRf0XRo+PtPoyxuWWAzd1DBL3oeyh+Fu+o20fpofT+pjljcXFerDluwtL3WsXa7/Sa3Pgyx+Csudd/WZo4DnjeuFMk7wY70PdW/kCC3GcJbFgfAOGggZem30AYI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=K3iVdbyO; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="K3iVdbyO" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4903997fcb5so88606535e9.2 for ; Sat, 30 May 2026 02:36:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780133777; x=1780738577; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=fs6KkFLSXRDO0ZpFQL2dVWBRgXAWAtlVmxEcHXqi7PY=; b=K3iVdbyOJYYS/n+ehLsX5k8r9/z4dPhONIf0Hkbc8cC9GfZaeCu74LV1Ne/wQnlJAJ U9fr5UTBdvroym/KVc6vtahDTd05eTl/OVSPmP32YsJwp7RQAtLKCKGPPrFZJbEu8V+0 q5X09BP482gvlQ3YrKhQjGmTv2H2DxpsoMReHf2LcoKF+BS/JJIMEZgi/hGBXaP+y/+s SdzZ2h1sxiKUeTzllG18InrwPkcwozCGPHCXVk6mEWUs89a9L7qwZFIVOEjiGKaCIJak PXXFX5GaqM99Ev02vwtLqn/YVEbcnNeTmjMA2VS3XlDk94ExbBrhNEgSjCID8Rp/1yGv 39jQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780133777; x=1780738577; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fs6KkFLSXRDO0ZpFQL2dVWBRgXAWAtlVmxEcHXqi7PY=; b=Ok0kvqm9GO6eWvychgKIcRaO5PPr2j/oMGP2sBmAWnPnwItV+JGo9C1qs8yrSEoBG2 I+lClhcx00Bbe3xAcUnk/U6XvfQKIB7S21anDdozsYdyG1+ugpp44qXT+d0ccGbLMjMl 0kCYrj/96A4n/r1AaHm8vlQQ5FNVsEaWPaJW+Cwv4nr/pNi4WI291kJT+/2439Tc9n4O R0py75CRbAeKGiaja9AzlnHe1Ogrd910Z7GYqUUDV9MxYdeVCKpBfn2374v1Smn8wbGN nWkE/VdL5WLwjmmGdOYuFjMwPm7q+hlHnzwCneWENXRZBseILb8o+If+SHgz7A3iAHFc FHOg== X-Gm-Message-State: AOJu0Yze2m+76K45BrdMcIkNgzy/0ch/qhZkcSNTCZwcPqACDuXKzqo8 NFjGm3GLWocRaqt4rYcc2WzXcI2Uxm5mXRDr2P0Wi4b317QYtArZgh+8 X-Gm-Gg: Acq92OEDfYE9SqL3N0jfpW7Ug90k4+/xWfElj2/WlRg7md4/Zd+dEKDAj+6tEqstRNr tnXDmVY2vqPMU2NsYaPmvTVb/xRD0KERl2Dd8kn4d8Sp82Y8MxobdconO0O1b+6JTH7Y3QcM1JN Gs1SBYq9fifePijqRKAhdhYkEmcr+o8gDaM1m82crMPq6OXXDgFL7I+/lEHW0sm4s7maC8Iu+Df NOpv9g1Jz/LuaW4s+sWLR+2mSC5WNPjFHrIbQibB35RY3rq/GUOR8zaFhBF1rRdddNfmOyaSnV7 3ayqwT+D0th1CIZfs2dae+We4G164OEvYPGFeV4SlqNI3xUAsSuVgrmusY+6C2xCAi9RbFhMNwf 1vWaHRyrUYQdSYkfmnNSclB+K+5ZAyiqIm+ZZ8YxD8MxL8GMidU3rCZZ/6oX1Zq3E1ZPgHISEnm ayiVJBw+K8Z2jDm73Q4EKTdE8s507xf85lqw== X-Received: by 2002:a05:600c:1d28:b0:48f:e230:c3fa with SMTP id 5b1f17b1804b1-490a2988decmr53248845e9.32.1780133776688; Sat, 30 May 2026 02:36:16 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4909c967c6csm107091045e9.2.2026.05.30.02.36.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 May 2026 02:36:16 -0700 (PDT) Date: Sat, 30 May 2026 12:36:12 +0300 From: Dan Carpenter To: Thomas Gleixner Cc: LKML , x86@kernel.org, Michael Kelley , Dmitry Ilvokhin , Radu Rendec , Jan Kiszka , Kieran Bingham , Florian Fainelli , Marc Zyngier Subject: Re: [patch V6 04/16] x86/irq: Make irqstats array based Message-ID: References: <20260517194421.705253664@kernel.org> <20260517194931.196070643@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260517194931.196070643@kernel.org> On Sun, May 17, 2026 at 10:01:48PM +0200, Thomas Gleixner wrote: > +int arch_show_interrupts(struct seq_file *p, int prec) > +{ > + const struct irq_stat_info *info = irq_stat_info; > + > + for (unsigned int i = 0; i < ARRAY_SIZE(irq_stat_info); i++, info++) { > + if (info->skip_vector) > + continue; > + > + seq_printf(p, "%*s:", prec, info->symbol); ^^^^ ^^^^ Ideally, this would be called "width" instead of "prec" since this isn't a precision specifier "%.*s", it's a width "%*s" specifier. This was introduced in 2009 in commit 7a81d9a7da03 ("x86: smarten /proc/interrupts output"). It's done consistenly everywhere and it's pretty clear that width is intended. Static checkers complain because people use precision specifiers for to not write beyond the end of the output buffer and this looks so suspicious. regards, dan carpenter > + irq_proc_emit_counts(p, &irq_stat.counts[i]); > + seq_puts(p, info->text); > + } > + > + seq_printf(p, "%*s: %10u\n", prec, "ERR", atomic_read(&irq_err_count)); > + if (IS_ENABLED(CONFIG_X86_IO_APIC)) > + seq_printf(p, "%*s: %10u\n", prec, "MIS", atomic_read(&irq_mis_count)); > + return 0; > +}