From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2141C233722 for ; Sun, 31 May 2026 17:24:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780248287; cv=none; b=O2x/3mdpLUXOijwyem5LPgIXRLr2CeROswxnCiIcy7LXULI/tB7UDzPXZDGNyejt69hi4/wqy1vZzvuWlxu3bHlgnY9CzB4u6QatXLptufYf7GQiMbML/gUCN7nktB8qrbAGoDnTEBPcQLz5MpYaTptjSa+Izk6UgvZjlKwZkcQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780248287; c=relaxed/simple; bh=ky3L5cRsLB+b8CxvBfdtboA2OUoWuWGplH03HCAsw88=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lNvkqAklms9+hJCejEHK5CVk5j2YW1+9XtQxxmkRjAhkg2DjECMURaP5Z/Rf0irHjKD3oxYU3Rg/ZDi/RA+yTU7L2OHf1FVbnmSWTv1R3XYhJ63o7rBeeO4RGYxpEsg2jWXPyx7OErPzOiyvKTMNQCtuP3XmSNzVp7OO57HJfMg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=QScKu/TI; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Zd6NpnrD; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="QScKu/TI"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Zd6NpnrD" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64V0bQGJ392568 for ; Sun, 31 May 2026 17:24:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=ljfg8GLQiAYFLZevBkHWq2Ge 6r6LCF8k5rc/boN+Qf8=; b=QScKu/TIj1K0knnLG1Yg4AqkaKgcfVQc1Tjf/vZh 6UcXzTMVKq+yl0YhNSZOzhPIB3QbGAO513Tcg6Bf88uxxtiFsH3i0x8RN7u6M+Cw yxYhuebox5vDkPrbiw3/Whki1ZyJKaVo8lT86aWI4RfwqQxrO+D6bDEZSMhrn1Sd Czt5PKCEtusbpozPPu/mYhuZu2YL5YpJZGs2wdFBr+0LCnLAJ1Ks8Zvlpct61COq 8hpMgdGSc+veTVMjgMIDIIqj+0xwjz+kN8KqofTzJ6nWtd4sPQmgrENr2/Dj3v6T 2d5tpNVi2+6Nw9Vz08jxlwdlZ0yxPn7KJswQDwLEGTUBmw== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4efs2hc16s-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 31 May 2026 17:24:45 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-36d992fa39eso825316a91.3 for ; Sun, 31 May 2026 10:24:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780248285; x=1780853085; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ljfg8GLQiAYFLZevBkHWq2Ge6r6LCF8k5rc/boN+Qf8=; b=Zd6NpnrDTatCChSxSlW3pRWo8SBBghVCGCNS0++Bj823dvZS6o9HlcyntNEswUhX7W IURfZQC9ds4rMOKOABe3J39xemBwRGVoWbVEAXsCTmxRY20XnDCmeldQSe9NKwBhN8GT vGzHlGVjulq+XXFZJWK4ZEqxAbNYKBoHn62BIiPSURsBirUtwmj8ZWZEwUV891eOZqaz Y6IrsE7SWfGvV0bAil0OApViT4cSGCG3CpBxHdZ3xpqIboJbqo1uEsSDTXBJbU8i5dr8 bXaX02fbrVOA85qwdoK0y+9IQq5IJU1nSfDYr4v5pqJVvNjQy+/DZcfeteXDXacw63G5 3KjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780248285; x=1780853085; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ljfg8GLQiAYFLZevBkHWq2Ge6r6LCF8k5rc/boN+Qf8=; b=qMpluGfs7s+C9KPGjrnfLdRYFbR0NrPYxYWlkGre2hgEmk00eXAZfhCEx1RXW8a77b P2LkuYEmoMXMTWDoG385mUvWeV3B9xFpTiYv8cTzc4G0EjNJsWy9RLKjCx+UxjYgXche +x3X0cK8Xc/WD+oAz9zrT81MnJp5wPlHklxrbtJUonuDlCcPIcha3lOhTSNbB8XHVg6O H+qcPofz+xaa2NRcsh0NA4wRRHHUnk2s1qFTV8Fr4/ihae966h8jCP5zOFUocYQDqkX+ JbMidChLX3SC9VphYm3o3tEqtgRu7xjTNjZYGGBkXYXrYm7sRxMJY1o2zUK3FuBZQnVv u6BA== X-Forwarded-Encrypted: i=1; AFNElJ/zuDW5v8smSFqwA3xPjwg/tsh2NC0Wu2o147/aSGno7H0ar51B4fRj/bIfFt59etgl/OKqS1kWUs6Bhd8=@vger.kernel.org X-Gm-Message-State: AOJu0YySqJyF7ml8QrQ8dzTegPo1e/sMNeDt+U5Sg6nG/bUlvW+9kTY3 3jTnd9+tuY4oalb89dsnXc1m8F5QcA5478sSBA3krykhuk+UeXrxBLiR/ZZ7qNXEo1xDmLR0Hhk IVLI0mlCaGGpoA5EZ8XmjJTtflKP1TkdSeXgks4Jk8krEGna9hhYP8oAgjm80X9Zijsg= X-Gm-Gg: Acq92OH61vO0A8B2PZeSQgA9Wcrj87C4ukXdqDAJD3tziYSefIu1y+c0op84wZvUDD8 NccHZasVyA75aHAeFvn0QCbEG4Mjh+IYQoPlrvqY/qVZk0JoATQI6D4kaf9kxesm6f767mfgYP/ d6oCDRvpGYHKEq00O94a/ZjSHrzgcfo5oI2Pc9CS2FU0s7gCKEh45XFCumg/ByiUPXFPYCav/ds kXVHg1gWrs65HoPJqdy3LCOUZHhNrQdnGXMdAQcj69AFOP4SrbQ34ATqU4tyHLxhmvp/mp3rF7Z Do5lwp+bm5M2+XTkwvbDafIAlcW5nfxgGgALzOtOC9UeV03JU5HIHDfFZH/feax3kGCmZ+jvwYL 1wDRRQfZ+JutH0lkbwiAoYt4t/buw6F0IpGgJXB+11637N6jeuYDjlYFku+YO+kWXBvhuQg== X-Received: by 2002:a17:90b:574e:b0:36d:635a:ac1b with SMTP id 98e67ed59e1d1-36d635ab5e9mr5465219a91.22.1780248284758; Sun, 31 May 2026 10:24:44 -0700 (PDT) X-Received: by 2002:a17:90b:574e:b0:36d:635a:ac1b with SMTP id 98e67ed59e1d1-36d635ab5e9mr5465215a91.22.1780248284278; Sun, 31 May 2026 10:24:44 -0700 (PDT) Received: from hu-arakshit-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36bc6b50edesm8030762a91.14.2026.05.31.10.24.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 31 May 2026 10:24:43 -0700 (PDT) Date: Sun, 31 May 2026 22:54:38 +0530 From: Abhinaba Rakshit To: Ram Prakash Gupta Cc: Adrian Hunter , Ulf Hansson , konrad.dybcio@oss.qualcomm.com, linux-mmc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, pradeep.pragallapati@oss.qualcomm.com, manivannan.sadhasivam@oss.qualcomm.com Subject: Re: [PATCH v1 1/1] mmc: sdhci-msm: Set ice clk rate Message-ID: References: <20260529081045.2877910-1-ram.gupta@oss.qualcomm.com> <20260529081045.2877910-2-ram.gupta@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260529081045.2877910-2-ram.gupta@oss.qualcomm.com> X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTMxMDE4OCBTYWx0ZWRfX0x6GIi5jiQ4C O/gT9vzpHcbzEDIr1DIXWyde3fWP76TF0BCZ9M54XeC4q3Go4K+at/HMZ+0/Bw8IqqkCbQfC2Bb jkvnbe3hbBzlK4K2T3bSfflITxU/pxu5Z5CCN2k16jbpA+yylIq0Ytu2f4fVDT1Z/WDgFzFaBrD CdSne0cI9XpV6flc7Y1fcMxcnpnEcgdQdlKCmuIxaG3r6unSXhGAdk4zhxilUVS3WWXxtmjtD8u jU7ldQ3hErl40yjLAMXuh5ISh2UtWF1Ak5U9OraSpVQiqctFbxAdXvwkxOIgQoB9taKfQH5Y+jS l4N9Gst74EKGkPiRuIi/9qlejxMIE2P2fA1B4YgTpF4JZXMAnHxPx9BDoICdk6VGlKsQtGoqHr0 T6TDNC1tcKnNCny/7pXeHF6GYUHD8kqRvKD+jjryaghiBPsAoNlUz+r8Plp4rL63RCMaljcdoT3 MHeEnLfgnLUpUHd4hKw== X-Proofpoint-ORIG-GUID: R072ZrpMuBC26pvuohSUWVwOH7ETvKw- X-Proofpoint-GUID: R072ZrpMuBC26pvuohSUWVwOH7ETvKw- X-Authority-Analysis: v=2.4 cv=UIvt2ify c=1 sm=1 tr=0 ts=6a1c6edd cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=kj9zAlcOel0A:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=pPzFWFYw7oQxx3fYbUYA:9 a=CjuIK1q_8ugA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-05-31_05,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 bulkscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 malwarescore=0 priorityscore=1501 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2605310188 On Fri, May 29, 2026 at 01:40:45PM +0530, Ram Prakash Gupta wrote: > Set ice clk rate from sdhci msm platform driver, needed for > target which are having legacy ice support, and need sdhci msm > platform driver to set rate. > > Signed-off-by: Ram Prakash Gupta > --- > drivers/mmc/host/sdhci-msm.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c > index b4131b12df56..c6a073718aa4 100644 > --- a/drivers/mmc/host/sdhci-msm.c > +++ b/drivers/mmc/host/sdhci-msm.c > @@ -286,6 +286,7 @@ struct sdhci_msm_host { > /* core, iface, cal and sleep clocks */ > struct clk_bulk_data bulk_clks[4]; > #ifdef CONFIG_MMC_CRYPTO > + struct clk *ice_clk; /* ICE clock */ > struct qcom_ice *ice; > #endif > unsigned long clk_rate; > @@ -2708,6 +2709,17 @@ static int sdhci_msm_probe(struct platform_device *pdev) > return ret; > } > > +#ifdef CONFIG_MMC_CRYPTO > + /* Setup ICE clock */ > + msm_host->ice_clk = devm_clk_get(&pdev->dev, "ice"); > + if (!IS_ERR(msm_host->ice_clk)) { > + /* Vote for max. clk rate for max. performance */ > + ret = clk_set_rate(msm_host->ice_clk, INT_MAX); > + if (ret) > + dev_err(&pdev->dev, "ice clk set rate failed (%d)\n", ret); If we keep dev_err(), the failure path should probably go to bus_clk_disable. However, since boosting the core clock to max is kept optional, I think dev_warn() is more appropriate here and avoids making this a fatal error. Abhinaba Rakshit