From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com [209.85.160.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 113663BD246 for ; Mon, 15 Jun 2026 08:18:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781511536; cv=none; b=WlgxRsznt+QlufpbnIiOxWtdSit1w0Ixyl8xz3ZTOC/5XL02aExJ/YTafU74mCT1B4LCrZggiaIoJvt48JOtKeDYVB7Y8LoITqW5DgpBw7PEKhU9bxfbH/nO4thaF6CqLTXiUOctFVfUmdT5D+xTqN6PIwze6VEfrWxonfKmu4w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781511536; c=relaxed/simple; bh=C6GWuDxvvQ0aygQNHKFgBKGLEGmdldxySmV/5dbAu7M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IRzGheEiITXpcmc9X7gBMbzn2ZqeTVEv7y1mWawvTkCpO33aAmJN5g2+gDrArurN1E0YX0bbt0UapS6BMY/hV6qJdRWvgOi5ZhYMBEG871BDWY58l004PPjmcRM7urNhC9fdpyq2UPzmEVNs3vigo8E4nlYS0gCPoy3Cah9Qv9g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=de+MVLok; arc=none smtp.client-ip=209.85.160.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="de+MVLok" Received: by mail-qt1-f175.google.com with SMTP id d75a77b69052e-5177945a22eso21268541cf.1 for ; Mon, 15 Jun 2026 01:18:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781511534; x=1782116334; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=fWLdQLm3J2zWM1QA3MmZV2U2D1DL/u5j1Qzgws/RERo=; b=de+MVLokZMwfp+f+Ir/nJm20pRXwu+79sCDZE5nT7pe7JpeF0iL9b7/T/aVtezQGmA x691XSF4ye0e2edc3u1wkotFsbBBv7KY/xKQNPJua6H4nxkseyR9oyYj0nIhe4p0sOfo hMwnyDR421P4W1eozLzJNg6PHTCHgX04QHCsrgZLXbCbPXU2xgYZKnXO3aoQMJqrFcy1 cgFvmmWEJZ5s7SytLb7D7Ak/Hqk+yTvmhk5RdYDSPxYadY88XdImalRAYZdjXdTBNvu5 +X2hKfBAvRJPopYiDsj34Iw7K3OZtmDt4MPogI2lf9lwQx1sMbIuXqc81n33h3eWJrL6 R37g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781511534; x=1782116334; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fWLdQLm3J2zWM1QA3MmZV2U2D1DL/u5j1Qzgws/RERo=; b=HhKML8r0MSItv0DVNMEPpVodJO4EGzthjmP9HevNNy944dZMUFaCCcurHxJhtkuPDS 0Hl/1j9RK04pqZ3b87Lx2zv1Iiwoha55artLPbwnAdhnhizn534wGNfvVs/2yXplKaqr Vd3M0iCVruZONfhiV7tjnRRypu2v3ya4FBg+oC9jiQKM87OT62YRLhdFWnxqivR45s5E qVUhZZmehzT8+c9MIO2RIHSTYBeJ1Cz0h9/RsM7YjOoFxcGrAUvMo8R5SNt+dJd/9TRP 7DIG3rCdFvxiiat+rnCnug1Cc+rwYZOq0CiK2aa8X+FGsctcUIn+YGncjQvNSgSfKk/J 9vUw== X-Forwarded-Encrypted: i=1; AFNElJ+cD+kDVtFy3QxRdV8vBI3GgbpD6nd0h9B1Q0RfRjpsoQN07k9+Oq3/0jpvKx+gT2PhZNrU76KX2con0ko=@vger.kernel.org X-Gm-Message-State: AOJu0YyqfRJ3CzsbofWV+b+Rp1qbv1CQCT++/pcdzkhgeUGIAIqDm2oO OTM7MICBM7VC9eOBaBXL+122B+ys1feWf6xWnucSEFxJwe25g1h7XFRz X-Gm-Gg: Acq92OEp/HOU8asVIMmSFQhJddqq1csP0L6pcG416VYvzc0S00XN6MWnZQyLdhSdO9s E3CEFkO0DCA2tJoctVNcgBfrfHfJB7UqTmk8TbyOLUTnP0TdDPxfoins/CJocfNyNGJlSWmHCRQ XsQf2cmdfomucfdsHQJCcN8Jz1AdHnCrcNb3aZEwjGtvS2vHViBYpB/wzpzkUhaQdzRWbcf9k03 qzrWxZ+n7jOzUOuHtwOqgjz+Js4N12MtHniH1ReQVBogdCxMMUgP0R6ptLqnIJb8lipwNjZ/IbZ hT6RHWnKvku5ORuGaEwbiurPBY96D1cQzx2icYzc9+StDGn+0z2ZTgOWwJXDwn7Mck4Cb0kus3e 5gGcb46XxJ/N0dOmrSwm0u3Ag4VrJP82MW+SWumgybWHJ2rau6guP5M60xEskGmuOkWxEPlnYMW pL8Cqo0G4v9hI9wpd8 X-Received: by 2002:a05:622a:14c:b0:50d:9f02:86c7 with SMTP id d75a77b69052e-517fe4effd5mr188145831cf.13.1781511533908; Mon, 15 Jun 2026 01:18:53 -0700 (PDT) Received: from localhost ([43.225.189.75]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-517fb6428a6sm118854651cf.12.2026.06.15.01.18.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jun 2026 01:18:53 -0700 (PDT) Date: Mon, 15 Jun 2026 11:18:46 +0300 From: Dan Carpenter To: Ayush Mukkanwar Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, skhan@linuxfoundation.org Subject: Re: [PATCH 1/2] staging: octeon: add missing tasklet_kill in cvm_oct_tx_shutdown Message-ID: References: <20260614114739.87061-1-ayushmukkanwar@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260614114739.87061-1-ayushmukkanwar@gmail.com> On Sun, Jun 14, 2026 at 05:17:38PM +0530, Ayush Mukkanwar wrote: > The TX cleanup tasklet can be scheduled by the watchdog IRQ handler > to execute cvm_oct_tx_do_cleanup. There can be a pending tasklet in > the queue which might run after the cvm_oct_remove() frees net_device > structures, causing a use-after-free in cvm_oct_tx_do_cleanup() as it > iterates cvm_oct_device[] which is an array of netdevice pointers. > Add tasklet_kill() after free_irq() to ensure the tasklet is no longer > scheduled or running before teardown proceeds. > > Signed-off-by: Ayush Mukkanwar > --- Looks good. A couple process though. 1. It needs a Fixes tags. 2. You need to say when you are using AI. I think you're supposed to say which AI tool you are using as well. 3. You need to say that the patch has not been tested. regards, dan carpenter