From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f176.google.com (mail-qk1-f176.google.com [209.85.222.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61E9D3090D4 for ; Mon, 15 Jun 2026 07:43:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781509413; cv=none; b=cCf6XdiyWtst+4BguPSXJcx/J6qBnkT1+/NNoG2vuW2thM3mm7AYyOsguA1SchTPLZ01TiwYRzlAdD0Nxh8gywr2rHoDZCDKbvlyDk9ykuAoGi4/ZJTM2dBdo2hF9AZ0kP/Z/sBTBaQsujohCEQUaL0ydveaDYfvs624tOYgvQo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781509413; c=relaxed/simple; bh=9m4ZYYBF0HAaVco7yIQJUeZ2zkdgdUYJFxX9i9XutvY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YEBreu+7ehbHFpfiRpoxWQ7klHGI9P5JhuEQMRZ37KSSLic1tCAoL6rjCwwuTmrtoZLlZ1SqMI7c8upQGt5RFA8OcEhY7fftDl6zsaIHgoEOXZJEBMpWpWKPsIBu0Yq5Q0Gn7mTKDuVH7WfEO9pFRJvo/0aqZIlnFKoB33mx4RU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MLcdHMxw; arc=none smtp.client-ip=209.85.222.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MLcdHMxw" Received: by mail-qk1-f176.google.com with SMTP id af79cd13be357-915d64fead9so415837585a.0 for ; Mon, 15 Jun 2026 00:43:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781509411; x=1782114211; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=oaRgS/uFb77TxuMeOW1cQwkMhqfMxgU2v3XEuTWv4wI=; b=MLcdHMxwBo53zANg78/dzZzmmrohOFLaf7LjADISlDsrN+FX/6FiOcmn4lzXnJZTKE Z/Pv0XiGleFD0uiQvynlorXYOcFY4/3s90bcsOxPl2BvXMLkHtYWw55yuO11V28xM3mr +9fMIUWpYtV2+Hl/9HungKx/SiYF+ZmywogH8nrPguRMeI7TasRxux70s1JZEoA2VhYh YeAf6iFUyFd2wIAFGMn7/VHNgBYc1P8P7M0i1BDTDdlDrbhDpNcg+kMXSJloKHa7/T7S G5L3U4Uj9XXQJfhWU6pEN1BKwstRMHIXPMLm0OHrB0+K/Sn45yDVy0lfSWFRAbtcpy1E TOPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781509411; x=1782114211; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oaRgS/uFb77TxuMeOW1cQwkMhqfMxgU2v3XEuTWv4wI=; b=B4i7Y/rp0K/serGzqxl999kLnxhVoJtp8ItQnEiijF/UmGj/hYvpO7iHrHDUSi8bbM FLsuSpE5OpWMqFlBw6wyF/N1HffXGdYeRbR8A+crDU4WrP3UatTp5gBFsTaGtDFUsbop vLhTh9EnjLkD+oI4VrztBXJTB8j7Dfx07x4vHTxtNrWs+m1mFm19t4d3gSC41vibwBbl dd7Az+MamM/Vw6Mh7W8y/jbmxRhRl/C+zk94A+nMddlIaZZaTesmIyeBqag1qmIcaJ9W SC4xC20jqqhPuLPHh4tj0XGNUBAd54g+BRD0+KP3pKyRbDB+9Zo/LuAaEdPM7AYgeIf4 nGNA== X-Forwarded-Encrypted: i=1; AFNElJ/G30eV3+CVfEBRbaD6UFzffP70ep79/HAL1LeCQHQh3HfPVCvyvIIwzPeq158v9KIsbMYKQrk2WyG8x4g=@vger.kernel.org X-Gm-Message-State: AOJu0Yzjbyy6U/G/Tt4E3igr2GKugmDdSeR62wcg8uOEknjJDiaZLwPP ZjhLVujkts13bfOf/K3Nq18W3ijPd+ETpRUq+AWyrcAXMwHGurR8zr0q X-Gm-Gg: Acq92OFbnxBqP8RWTzxpbjRPWCNk3wNEUe9GqP3ilwnAoQC1fLr18L6fp8oKysK1G1T v5bMWxtqe21hLGIbFM16mReES2fHSLYd8jtG5jIpNttsGycmUZImidkKuqaVCw4d644hvfN5IO3 KLxgdvb7dplp0pTCyOqG540BZEWjeu0k61foTHeySVowdbEiG9aWWLVf8psXKDedHtVULcAbKR/ ZBSkCQGdWA0MXNeRwsjy3acEP9TreIWv2AJIeM9AdJLU4ZTmlTxMnE3qIdaFEiA0oKbbOefK4+P 9kWrc2PeRpjyBu77dRjNDonJgYNH6r2MXOZAKEydJIwX6KykgJGMPUrloDuwJK0EDbayjKAcCXx k7AXhO8ZIKmN/BqkgXfI+O8R0NK/m7xbTlxBnAnAhizvn7DH2RbAstsMMLlaG0d21pe0Iwdrhd4 cMQ7XioM1C329u9Xte X-Received: by 2002:a05:620a:f10:b0:915:6ac6:c0a8 with SMTP id af79cd13be357-91619f012bbmr1797683285a.28.1781509410914; Mon, 15 Jun 2026 00:43:30 -0700 (PDT) Received: from localhost ([43.225.189.75]) by smtp.gmail.com with ESMTPSA id af79cd13be357-9161a0541d3sm1035385785a.39.2026.06.15.00.43.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jun 2026 00:43:30 -0700 (PDT) Date: Mon, 15 Jun 2026 10:43:24 +0300 From: Dan Carpenter To: Hungyu Lin Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] staging: rtl8723bs: convert update_attrib to return errno Message-ID: References: <20260614182309.96110-1-dennylin0707@gmail.com> <20260614182309.96110-5-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260614182309.96110-5-dennylin0707@gmail.com> On Sun, Jun 14, 2026 at 06:23:09PM +0000, Hungyu Lin wrote: > Convert update_attrib() to return 0 on success and a > negative errno on failure. Update rtw_xmit() to handle > the returned error code. > > No functional change intended. > > Signed-off-by: Hungyu Lin > --- > drivers/staging/rtl8723bs/core/rtw_xmit.c | 17 ++++++++--------- > 1 file changed, 8 insertions(+), 9 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c > index b6d9332958f5..fb2fd3f5de77 100644 > --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c > +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c > @@ -741,17 +741,17 @@ static s32 update_attrib(struct adapter *padapter, struct sk_buff *pkt, struct p Change this to int as well. regards, dan carpenter