From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA64B3A3E96 for ; Wed, 3 Jun 2026 14:43:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780497795; cv=none; b=DGenfCdlfDztKUDtfiSbpA3sm81PsStFnNrIITXSNp91SaE0RhlGuLxYmUoZDzDWV5aFcWAgxGt5s+JBquRNyFcoVpz4NLC5z+2Fgf1KG8DKCGR4SRgMRZI2nC310bHutVabxv57lNB6UV4KMK6wq1dp6rCEAN5INpkYyIu6nb0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780497795; c=relaxed/simple; bh=gAxjbPDCoUueiU8oQp9n1YVQDmZMib8737Yuiuudheo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=azmNs8JGs1gAUOYAkttK3c4uJ3rENW32N9HvSRiY0fOzkVyhE1jXN8Ev7IinW/MhD9dxg05OTd4MJIdXxAo2/mOpAfd5o+z+BGKBkEWpWpWSmLTIAfZLi8UEuPVyyaifZs3FWwi/Gm2EjVgSlbvNH9UDQLzY45QyyoUa5GPOeOg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=IPqRxu8J; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="IPqRxu8J" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8DEF11F00893; Wed, 3 Jun 2026 14:43:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780497794; bh=HO0DkCPaiCMTj5drrMHS+LD2sBJcByoKiY6OnaW3sbI=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=IPqRxu8JJtt9BAyRyd32+vgchzha7oqvDvw97Czp6wU7ORKb8BD3bc0mKCMPX9qFy jodTd7nhQAhbL2UGOz5SnmI849/UUyfNmR4HBOnqUtpYCdCFmqRnHA6gkS8HuHAIa6 YmwwxZgMCepuz1hs1IFVYnj3EbcclOLwt3rw137keecoM5qTHGEfzq9S9lEKUi95sw O//iTbik1nfl3jXOR6o40AROvmX87Kp8GXpkyasBokteMXQfcpqHNyd34rAPR2DyRg 0YCKOihmy+Q4wKinjviC1IvGiV6/Tm0fW45uGplk/70SMDdutbhFRMCYHNeZch2H3c wZpG7hUQoiYjw== Received: from johan by xi.lan with local (Exim 4.99.3) (envelope-from ) id 1wUmoK-0000000AYJL-0Fxn; Wed, 03 Jun 2026 16:43:12 +0200 Date: Wed, 3 Jun 2026 16:43:12 +0200 From: Johan Hovold To: Mark Brown Cc: Liam Girdwood , linux-kernel@vger.kernel.org Subject: Re: [PATCH] regulator: bq257xx: drop confusing configuration of_node Message-ID: References: <20260408125347.189345-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260408125347.189345-1-johan@kernel.org> On Wed, Apr 08, 2026 at 02:53:47PM +0200, Johan Hovold wrote: > The driver reuses the OF node of the parent multi-function device but > still sets the of_node field of the regulator configuration to any prior > OF node. > > Since the MFD child device does not have an OF node set until probe is > called, this field is set to NULL on first probe and to the reused OF > node if the driver is later rebound. > > As the device_set_of_node_from_dev() helper drops a reference to any > prior OF node before taking a reference to the new one this can > apparently also confuse LLMs like Sashiko which flags it as a potential > use-after-free (which it is not). > > Drop the confusing and redundant configuration of_node assignment. > > Link: https://sashiko.dev/#/patchset/20260408073055.5183-1-johan%40kernel.org > Signed-off-by: Johan Hovold > --- > > This is a follow-up to the reused OF node imbalance series: > > https://lore.kernel.org/lkml/20260408073055.5183-1-johan@kernel.org/ > > to address a false-positive Sashiko report. Can this one be picked up now? Johan