From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B0BE2DA762 for ; Wed, 3 Jun 2026 13:28:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780493321; cv=none; b=hltbNhT4Tf3Mx9mlQPpzMBVJ4o32bUf4VSPDTbD86akvZM+CJ6z9EFzpf+eWnAu0hgqm2ttHVwGmttF6QP18yDO/CWcUwasgXxtpHyS/uaxGfwC11eAxJWZfSqSMT16wR32ZIDsmPzB53gTe/ABSTREdzEQYV2o2B6rUPK0uC8k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780493321; c=relaxed/simple; bh=9BWuaZqYbE2xZQJ56+qGW6ufhtqU4X4Evjgd7IH1HgI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MqHh6uiqwgOu9QvDQSvpLvKU3DSe0Lc5myUPCrPG6sNrKhKu7G0jTJAhU8k8xxM30ALcptlKQQ8dlkd9XH8e8Qq0n0j7BK93agw7Vb+OSbB0XRP8rxD0mhSi4r6zCItfSn1aNG44RZR6j3ZOt7wFuvhwFFfI7tlJE9wIaZ0Ht/Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=mODDCWFn; arc=none smtp.client-ip=209.85.160.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="mODDCWFn" Received: by mail-qt1-f170.google.com with SMTP id d75a77b69052e-51765331535so323141cf.1 for ; Wed, 03 Jun 2026 06:28:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1780493319; x=1781098119; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=wV8eYWbv/I03NtOIpbrdNUBR1gCQqSNReaPud8ZUHs4=; b=mODDCWFnSVie6N7/JnQJh0bNh8N6tJb/r6Hig9QaAQY98uFGQtcDLeY2OCzWx8AR/t IxxQmdix6VEfXvzErJiBarEi61ExsMNSuZaJl1Gzb6V/0/FRaOu23z+xReH8r1QFpuHH WJ1Y61K5ckP0EyqaY78mDvxjVWWgPChgB0yV8kSYMGJgZMSGyTAkk1oFXuUgxiGyqoG2 GAYwocKlVKNFfrGCg54PWfdIKzyuCcnT4JwQtojkCSpv8I/G/xpqYYi9ci0Kc+mY2udF 2JLW4ZLlpSUgfq/lKdsV6E4VdM5FzyuWuklm3ijaBuMo1KN2Qcav+e/1v1vowT/v3yvW aPBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780493319; x=1781098119; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wV8eYWbv/I03NtOIpbrdNUBR1gCQqSNReaPud8ZUHs4=; b=B6HfQAJHF2LPL1lvxoS97wrICrNL1BqRsXseqLDGeKVeIqM/jy722Zft8D77w5nRg9 4BeImR/cFOoIGecs/hN5avace25r9ie19mVnlXkS+SYxreqvcAjNSeWhwdQgLrtM2s5i aDBXXg9gj2L1mdmPbT5vXjJkkz/EeziPCZ3Vhim267wrWV4Gm1CEwADEGxQ45bIjkG8E jDVVF1DFsepTJ1FokvsIEHmqgnEb61/OgUaREUDRBg9v6uaOfDbCN9hE+p/Q3+Hac4M9 61QOkh1UX222YRPu3sN4njfvhCfs0zD31JET4uJqcN+OK4oevM/NdWnHaV6u8OvAby3L Qvcg== X-Forwarded-Encrypted: i=1; AFNElJ8RxNERcHUn3dTcXAO2OaQX1b0zOurpOS/44sSfwzGWQgjqmnnWtlL6qt7oC0tJ83IlJ29KY8vQl5MO7f0=@vger.kernel.org X-Gm-Message-State: AOJu0YxJBSk/l2pnNrEBA4XLQDVyDNBUtIxfQ85ZD5xZt9dLN/W8LSYZ xQ+4vrSLrh9NztCtDYRVrCNfu+Ju1B1dbmIDb1k3svvXQFWcwESZnc/WUsSf11nvnw== X-Gm-Gg: Acq92OEnZq8ayfe6B6NCbsRP6Er3DJSMBdw+ODFw02OJXgWck5kWvaqhDjGMYSfjTQD eqVPrlFswBHKqz1xc1os3h+cszC3j12o4l+a0Wml8ofiI6mbktvstWA+V4Z9yPF5dxmnGWI9j9X dKXvAKqx1aAdG/4Zb2duOUaoHblkGA32jKbh7yTc8klNn7LGw+ccXaFTb/gPGBOR7msLgWCgFMW /L52FjDj5VDQMdOuYW+KIC2OY93B5N0S/NtfBhAcXAEqt6OwI7ebWLgZOdJFA+ew71RYyXsiF/d fpVzCshBUeai0YzK5odLliMIs1N5DDjnGraUzNC8MZYdAN3R3eCDL0g15SqebGAqquOTG6quxvk iAMu6ViJw7oPJYTMACKaN9lO54c1cVct/kez2kD7tNMzIQt+plXoHVip8rRXiuaO8ziDi/Y3TdB LUbe/6Q/u2p6M5F+50wzfDqhZ1R13M8ih7CxqRkTzeLONlLDRfPdOcmMISzyWBtUGSw4mZuks= X-Received: by 2002:ac8:6897:0:b0:516:d25f:f038 with SMTP id d75a77b69052e-5177b9a4747mr6943111cf.10.1780493317250; Wed, 03 Jun 2026 06:28:37 -0700 (PDT) Received: from google.com (199.255.142.34.bc.googleusercontent.com. [34.142.255.199]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8ceccdb915csm20063146d6.14.2026.06.03.06.28.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jun 2026 06:28:36 -0700 (PDT) Date: Wed, 3 Jun 2026 13:28:29 +0000 From: Pranjal Shrivastava To: "Tian, Kevin" Cc: "iommu@lists.linux.dev" , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Joerg Roedel , Will Deacon , Robin Murphy , Baolu Lu , Jason Gunthorpe , Bjorn Helgaas , Samiullah Khawaja Subject: Re: [PATCH v7 3/5] iommu/arm-smmu-v3: Fix a UAF in the probe_device error path Message-ID: References: <20260601143644.2358771-1-praan@google.com> <20260601143644.2358771-4-praan@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Jun 03, 2026 at 07:31:38AM +0000, Tian, Kevin wrote: > > From: Pranjal Shrivastava > > Sent: Monday, June 1, 2026 10:37 PM > > > > Clear the iommu->priv to NULL while returning an error from probe_device. > > > > Fixes: a2be6218e649 ("iommu/arm-smmu-v3: Improve add_device() error > > handling") > > Signed-off-by: Pranjal Shrivastava > > probably add a note that UAF is theoretical at this point. > > iommu_init_device() calls dev_iommu_free() right after @probe_device() > fails... Ack. This is just to prevent a UAF against future refactors. I saw the intel & amd iommu drivers doing it and felt this is missing from smmuv3 > > Reviewed-by: Kevin Tian Thanks, Praan