From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f175.google.com (mail-qk1-f175.google.com [209.85.222.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A9CB3BFAF6 for ; Thu, 4 Jun 2026 05:29:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780550986; cv=none; b=UPEIytS21QtLBMUxiS98SVl0flMkrEXmSNA300h/Nrg3Hf4HQQydpm0chhIqs5TiPZrj/d1n6WPAQaI9tJq01Xb9UDohC3E1TzXxEie7WEQoUcj00tJvJlfyYtOx/3ZGN3Lsy8yvPCjZbcbO2wwt3qt/tJWiGRxzby7vdsMwDWM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780550986; c=relaxed/simple; bh=ZVnJ5NCX/p+cRPW4D0M9BPRbTE4rckvjLK2biRRIeMU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=eSsAAEZ6kfloNbcKEni6OR67FNO/cmxJ4LyAOXYmi3LCkaGCHYuTy2aX11dMby4Tsy4wy7Oz7X2WiO326z74wcnTzmaAGEFWgnM/lh+1o8aOIj51u74Zfb5390OXdfomtlv5QAb0Rm4vtIAKGqp6NFbvImST/dd1l215YolMKu8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gBUxm7Zb; arc=none smtp.client-ip=209.85.222.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gBUxm7Zb" Received: by mail-qk1-f175.google.com with SMTP id af79cd13be357-91591f19c30so57404585a.1 for ; Wed, 03 Jun 2026 22:29:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780550983; x=1781155783; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=xBAn1dyOd78qsH0ClP79pBbz2f8l06Jgjt1qYTGR5f4=; b=gBUxm7Zbs+XgpinIuE4944K+CyN+ZxfTWiNdQdlsaU5q5ykq53Pnx7lXlyLEEuIS6x m5DjZLQ0xH9KHudJtwtcCxqaN7rKbXcMaPa1Q39IMTzT0y95rKAqCEQqSDPq/h9PpHCL lG3ugryPPg/N4NBlDRaNOO5NaQKxkO3o22VlET3TrOtS+1wx7E1KPfgNjTZuy2fuVvQY RGxkrtnLH3pl3BJtGdbZQE4XGL0I8gMzx7GVuQ4/0uYvYDOG89al7kcV4oG0YUMRu7fC uYX9CWuO42YeWyyxuGh1WUZMCtOhRRle7m7ZbhCiMykUWqHIGuBxbGLX/AuDUMDsE6S0 9Cxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780550983; x=1781155783; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xBAn1dyOd78qsH0ClP79pBbz2f8l06Jgjt1qYTGR5f4=; b=RbYc+oVOToB/nZufeGscG+8u5Zk4lvHVroBpaJU/w7/hdZrxO0hOnNlFGXnwQyiVF3 BD9Sz2ET05X/NJPVd6M2Tl8gAKPOkeiB2uIO7NqRkTyvxfvTTmoB0uHRRNCMamo8Xt3g nnjork7FCyH/DXDfA7qqUg+0VFk7oM97uzL/S869PWnSpKqUlZmdFbPpzsL6PM1qitCB 4Adc+BIZcMPtTrg3r83Y0wXjI0FSGaVW3E2ORYwPTHg6SAl2P4S66rlUWa40dLm1a5y+ VCkEosa2jawFR9r+C9SrLG+JDUZk7sdjZlv5r5p7Z7+rYwDCflRKwYCLWxmZQageopdM Fj5g== X-Forwarded-Encrypted: i=1; AFNElJ8vCLZlbI4cf49ATaByJWMkVQ0+tOR4m69v8hE+bp28hGTQP0QkZSW9wpw0IK6BrsaY1gjd/R/jH0isEFs=@vger.kernel.org X-Gm-Message-State: AOJu0YyjyFEfLJJkJe06cF3DSPWG5YD7HjeSalafOMjeN7LOQgiSVAeE 0Hg8Rx/Vr6D5G2TjLAfHqCJemPwlUDBsCBeJoRL3pZG9MDtVymblgB9a X-Gm-Gg: Acq92OGJIuf2T1OmujAOciHe3ay1UBdAFBQPjGbJxjuUM9tGYqsDnzYmq5M/5dMaSSj anZbuc/ckZ8lHskNRxzdDmU8lZyt9EVhpfITsxawXU9gL4Tzx0HxmVnsPoE8JYxPReONMMkxgCT Vlk71lW+3WpxEZ2WXSjpjRp6t8nh629O6Y8thX7Tcc8a5YPKqbdZ5snL9cQu+h3a4m6d6RiitgR N++OMhFP4rT6l/7EUSj1G99aUF73LFfWxHYB7MfX5e8COSh9U/IfNf9bnEelI5AHbyqTg0fQe3R MfD3OguYzsu3Cd8p/AWgUyB6rISBFUlWWizLKPb08xvJOsC13u7VBOstsdoo6X1BY7/EAf797Yh JPhhPUVCZ8bM8CouuNSYaoruAvcc7DlGohjz7f6DhqBGREi/hP4NR9N0j0DanwiDYo3ARcDBssB eM062q3qoFsBc5OlUxc5xnSEEWOU69YgQFy+1ZIg== X-Received: by 2002:a05:620a:28c9:b0:915:9bc2:8019 with SMTP id af79cd13be357-9159bc280ecmr315220185a.53.1780550983119; Wed, 03 Jun 2026 22:29:43 -0700 (PDT) Received: from localhost ([149.40.50.195]) by smtp.gmail.com with ESMTPSA id af79cd13be357-9158a37bae6sm479934585a.31.2026.06.03.22.29.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jun 2026 22:29:42 -0700 (PDT) Date: Thu, 4 Jun 2026 08:29:36 +0300 From: Dan Carpenter To: Eugene Mavick Cc: gregkh@linuxfoundation.org, khomenkov@mailbox.org, ethantidmore06@gmail.com, m.steinmoetzger@gmail.com, tomasz.unger@yahoo.pl, arthur.stupa@gmail.com, jannik@jrehkemper.de, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4] staging: rtl8723bs: remove unnecessary parentheses Message-ID: References: <20260604045112.830216-1-m@mavick.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260604045112.830216-1-m@mavick.dev> On Thu, Jun 04, 2026 at 12:51:12PM +0800, Eugene Mavick wrote: > Remove unnecessary parentheses to clear checkpatch.pl warnings > > Example of fixed warnings: > CHECK: Unnecessary parentheses around dvobj->cam_cache[id] > > Signed-off-by: Eugene Mavick > --- When I'm reviewing patches one thing that I'm checking is that if people deliberately tries to slip something unexpected into the patch. I created a script to help me strip away many of the common staging changes so I can focus on the interesting stuff. https://github.com/error27/rename_rev This is v4 of this patch and so at this point what I really want is for my script to say there is nothing unexpected at all. Almost everything here is related to the checkpatch warning about &(foo->bar). Some of the other changes are good, but at this point, I just want to get something we can apply. Do the other changes in a different patch. Here is the output from my script that I want removed. `cat email.txt | rename_rev.pl -r amp` > struct mlme_ext_priv *pmlmeext = &padapter->mlmeextpriv; > struct mlme_ext_info *pmlmeinfo = &pmlmeext->mlmext_info; > > - if ((pmlmeinfo->HT_info_enable) && (pmlmeinfo->HT_caps_enable)) { > + if (pmlmeinfo->HT_info_enable && pmlmeinfo->HT_caps_enable) { Good but do it in another patch. > pmlmeinfo->HT_enable = 1; > } else { > pmlmeinfo->HT_enable = 0; > @@ -152,7 +152,7 @@ > > case 2: /* auto */ > default: > - if ((pmlmeinfo->ERP_enable) && (pmlmeinfo->ERP_IE & BIT(1))) { > + if (pmlmeinfo->ERP_enable && (pmlmeinfo->ERP_IE & BIT(1))) { Same. > if (pregpriv->vcs_type == 1) { > psta->rtsen = 1; > psta->cts2self = 0; > @@ -168,13 +168,13 @@ > > if (encryp_protocol == ENCRYP_PROTOCOL_WPA || encryp_protocol == ENCRYP_PROTOCOL_WPA2) { > pbuf = rtw_get_wpa_ie(&bssid->ies[12], &wpa_ielen, bssid->ie_length - 12); > - if (pbuf && (wpa_ielen > 0)) { > + if (pbuf && wpa_ielen > 0) { No. Don't do this. > rtw_parse_wpa_ie(pbuf, wpa_ielen + 2, &group_cipher, > &pairwise_cipher, &is_8021x); > } else { > pbuf = rtw_get_wpa2_ie(&bssid->ies[12], &wpa_ielen, bssid->ie_length - 12); > > - if (pbuf && (wpa_ielen > 0)) > + if (pbuf && wpa_ielen > 0) No. Don't do this. > rtw_parse_wpa2_ie(pbuf, wpa_ielen + 2, &group_cipher, > &pairwise_cipher, &is_8021x); > } > @@ -182,8 +182,11 @@ > > pmlmepriv->NumOfBcnInfoChkFail++; > > - if ((pmlmepriv->timeBcnInfoChkStart != 0) && (jiffies_to_msecs(jiffies - pmlmepriv->timeBcnInfoChkStart) <= DISCONNECT_BY_CHK_BCN_FAIL_OBSERV_PERIOD_IN_MS) > - && (pmlmepriv->NumOfBcnInfoChkFail >= DISCONNECT_BY_CHK_BCN_FAIL_THRESHOLD)) { > + if ((pmlmepriv->timeBcnInfoChkStart != 0) && > + (jiffies_to_msecs(jiffies - pmlmepriv->timeBcnInfoChkStart) <= > + DISCONNECT_BY_CHK_BCN_FAIL_OBSERV_PERIOD_IN_MS) && > + pmlmepriv->NumOfBcnInfoChkFail >= > + DISCONNECT_BY_CHK_BCN_FAIL_THRESHOLD) { This seems unrelated to parentheses. Do it another patch. > pmlmepriv->timeBcnInfoChkStart = 0; > pmlmepriv->NumOfBcnInfoChkFail = 0; > return _FAIL; > @@ -228,7 +231,7 @@ > struct wlan_bssid_ex *cur_network = &pmlmeinfo->network; > unsigned char *rate = cur_network->supported_rates; > > - if ((pmlmeinfo->HT_info_enable) && (pmlmeinfo->HT_caps_enable)) > + if (pmlmeinfo->HT_info_enable && pmlmeinfo->HT_caps_enable) Good but do it in another patch. > pmlmeinfo->HT_enable = 1; > > if (pmlmeinfo->HT_enable) > > done. regards, dan carpenter