From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F6B937DEBA for ; Thu, 4 Jun 2026 07:54:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780559679; cv=none; b=tv7LGOxaP6o1845HQMqkrLYWbBdDf9gihXlMn/sfRCnz24vuUxdJYGjuXen7iOrIOGqYzf7blNYcteY+Mt9AaJZGCwbaXr4V+w6xtJnKUPJD7RbkatzTiF+n2Gus+L2gQ5JT6DUhql2j/VEaNVSPGom09HH6/XRjvfpNBYhCEtM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780559679; c=relaxed/simple; bh=PVxmen+bYmM7qoldOKUgzjpQJR5H2ZvpeASWrcYATc4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=X4M0T3cKtwTMz7OkA81gKs3NdjAg9M9qOOYCYpb1s6rzY7iVR2JG6CeI5ruYOsA6BSs3vGgXGORJi5GBmLh7bzZ90C0IlctMQjVIm1if2aXWVc/6pEaQlIt9LZNawSmX+kXgV6FAX4dBYJcSSqU+tgknu7A1hs3Fp1TPJXGPQSU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=e7ApuWv+; arc=none smtp.client-ip=209.85.160.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="e7ApuWv+" Received: by mail-qt1-f170.google.com with SMTP id d75a77b69052e-51761d27612so4528931cf.3 for ; Thu, 04 Jun 2026 00:54:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780559677; x=1781164477; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=XOlcBZYHQX5Abwo0UCHHT+CLoF6eErYHJpQG/xW25CM=; b=e7ApuWv+vIzGvt+NV4smYhEDUImBR6JJKleTS3t6AmbswLjsKq/h3KG15zTXN5jBhS YbWzZTmUkECheyjVMTles1JHczlpnb5XG+zuPpL1pqzaRwdbjAQ8yaLIzB8S/vERLobr 5Qjd1lvZMcD3ABzs6i6t5ZqgveLE9GmmYQON+hiJGk05qlvJkcceXjA2Cayk/SjyhId8 i7M6FPXntEdi1UIP3OnRYQh9/3PWIzDbMQ4SgaUAu1+2a8f5FRghcdcNKpnsiw87PscP NM2+52lm7eaJ5xLXVv++9hVq+PPZlOpUcChHCazdjRHVQksyTAXiIH00m3DqXrBZOVWP rdYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780559677; x=1781164477; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XOlcBZYHQX5Abwo0UCHHT+CLoF6eErYHJpQG/xW25CM=; b=JckIJZFtq9etCJ2uqBQL/Tq9lRFg2i82PTn79Z2cZa9ua+pQrc6Wwn8RFm8lQbWwXy iWEXuSBFfvKw6u3bw7NYpuGD8ptsD1XBdd5QtUCkzT5rVHbr2PWGIS+MYn/BycFOXPhJ WL58HTdisgdyY5/I29BHuKZEJaQ+2MKeZXIRhMGagh91JMQlzxK0OXPKG8lC+ED52Kcg 8LnOgybEf/y1o3riBWjt1IWG6EqeUvH3JvkezYrb3QLam65buEZwDvpKqqDuTMceigdh hr4+bENKEfi6oC4+1WIV7EFVTGBmmWCMvwRJetQekv7kQFLm4y+nSXy17biLmmXdGXMy JwWw== X-Forwarded-Encrypted: i=1; AFNElJ/DIdJNpk4VggxWBwLT6tQADwBQsLIU3ht9RkpTeHg9DIfYTaSH/wdtu/370+CgFyyEcDUUVd8G4kSd7n4=@vger.kernel.org X-Gm-Message-State: AOJu0YxUky5e0hxmhr+WRV1PwKP0r2Oh7Qbk2TBtSExDHH/pnwkrV6eV ZLyfXIUnLPKyFlU8t+PzR95CDdPOrxPKsoYsmFLL9PNtCkhxdjbWS0rMU5ba+nDk X-Gm-Gg: Acq92OGVHRaCNJxcp98s+G48Hl4HCIjw9JlWkw8C7jB0HeWCe7WDe1/YTWRaCcugQI6 VMcjzg2qUHNQepdSmJCLbtPqPbKqHr6Ez+8n9J1g9sfkR4uKDG1usmm8uUlm4M/U1E8vEAnByFF M2+B2vxHsNxcLwbP/EH3uzbh9/AErxd4l9Tck++xQK3UVgsa8J1lvUd1GNhYlK6MUBlchf12r/H Zq+bp+odn/pAGwaD4bNovBSVJv98xUg0nTy2A400rTSOAStz39IMOGumGjD7so+j4kz9btbedWH 5ADX30nOyzN1PE4dyarnIxvFH59qBfvREKoeF8kvYKqQACOEMicb1smcvZZrkhIqr+MLqOzrcGV PQQShMtBvmF4xmM9gLMWxn9yWlArqFZhVnAIIjHzuPIkTvYRKZ3IOSr7mbePB0VX+Sfa1t0zZKS VrzQTfVN36BVK5SDXjdVIk6Gq/+cs= X-Received: by 2002:a05:622a:313:b0:516:508b:bf4d with SMTP id d75a77b69052e-51778789b11mr103486471cf.56.1780559677286; Thu, 04 Jun 2026 00:54:37 -0700 (PDT) Received: from localhost ([149.40.50.195]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-51775c07e91sm46401871cf.4.2026.06.04.00.54.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jun 2026 00:54:35 -0700 (PDT) Date: Thu, 4 Jun 2026 10:54:30 +0300 From: Dan Carpenter To: Eugene Mavick Cc: gregkh@linuxfoundation.org, khomenkov@mailbox.org, ethantidmore06@gmail.com, m.steinmoetzger@gmail.com, tomasz.unger@yahoo.pl, arthur.stupa@gmail.com, jannik@jrehkemper.de, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5] staging: rtl8723bs: remove unnecessary parentheses Message-ID: References: <20260604045112.830216-1-m@mavick.dev> <20260604074923.841460-1-m@mavick.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260604074923.841460-1-m@mavick.dev> On Thu, Jun 04, 2026 at 03:49:23PM +0800, Eugene Mavick wrote: > Remove unnecessary parantheses around &(foo->bar) type statements to > improve code readability > > Signed-off-by: Eugene Mavick > --- >From my perspective I'm seeing this patch twice in a day... Just wait a bit... Remove this part as well. if ((pmlmepriv->timeBcnInfoChkStart != 0) && (jiffies_to_msecs(jiffies - pmlmepriv->timeBcnInfoChkStart) <= DISCONNECT_BY_CHK_BCN_FAIL_OBSERV_PERIOD_IN_MS) - && (pmlmepriv->NumOfBcnInfoChkFail >= DISCONNECT_BY_CHK_BCN_FAIL_THRESHOLD)) { + && pmlmepriv->NumOfBcnInfoChkFail >= DISCONNECT_BY_CHK_BCN_FAIL_THRESHOLD) { pmlmepriv->timeBcnInfoChkStart = 0; pmlmepriv->NumOfBcnInfoChkFail = 0; return _FAIL; regards, dan carpenter