From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E6C7838D3E3 for ; Thu, 4 Jun 2026 07:58:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780559909; cv=none; b=SRTWCc+7oMblT2K8NToKQgT1ZRZYLUDiJdXphyTuC1I59uojsXQ/909CqsP5U8sz1/bkEC6Foi57I6xPZOVe6RPLgivnIA9pI2YSddIpmeQjw9TdlTVAKpHkfMNdetOQI6oRDeGhdwOBlkCLWNmxeWyMJ3YWTfVnz4GWIoSLRJE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780559909; c=relaxed/simple; bh=UuFyfnBxLDJQby/SNgkcPJjeKlBwDfw9ymISOLmhuIQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UyHOudTNdcqftSDWhU9sJRPpzBtGPSmzyxW6imfGJ2Fg5xQnrilZT2OmpGXgL8VJ3cbBeNA3NqGT4+NhhvtmWoY5wO9YQVxaOuRXgjsc7tMgMODmbW2NYOwo9IzomXlmfYONeByrtvLRmxfG+U/yjF5btUB7ty0K/0TrnV21MMk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fdJiXYq/; arc=none smtp.client-ip=209.85.160.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fdJiXYq/" Received: by mail-qt1-f177.google.com with SMTP id d75a77b69052e-516e1525aa3so5481411cf.3 for ; Thu, 04 Jun 2026 00:58:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780559907; x=1781164707; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=lut5XuTSnmwiBdSG4109L0bbC3YpWSUfYyKpQA0USYo=; b=fdJiXYq/B3RnmFybVsGDA5d63l1v8sdmvQA+shmq5oufutssXp1RlNNrFqH1hfw3MX 5PsERjgHQbpPaKXjwqijmSH2ORR257RPo9dUru5x2pDYDpli5Sq551vMDi0DdC4kQlBt MbDp5TLnNsISegpGsARbtXJ7S7TLvFwOsakBjNgchJZO4Aw5CeD3rzpLbkNJSBrvl3BV GNwRViRpprj2fGRkmxIDyHu7B9o5XV+dFf8OiNNH4ssTh3FWz7+7V1Hx+/dBgP+8TUbv OcEVA8rpgZv8b6wA9qaDvafiVNV+VvCj9pSR1wLccFcVtW+I6xVZg8p0fQUcsA+6bloS vr9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780559907; x=1781164707; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lut5XuTSnmwiBdSG4109L0bbC3YpWSUfYyKpQA0USYo=; b=iPCva8eH3BaKwC3k1RL/tu3jzX71ZoOqDavNV3AV7feyRBEYWi2CQ+zSss+3qpVBzM pEfa3ixFY2HFvJBpXwrJPFb/3vFCt7F6SNRno/87H5Z2LA3U1soWZrfT4LwZov2zzJd2 s07TeXBDPcIqBoXPfLCB21oy8D2ca8gtVOA2J6w6ahQ25GnPRZnBTp3U7AbtqhPPTtrY 9Yyjhi8/vu1/aJG556ixrkSZwDZ1F5lB7U8T+l+YSLPliBeTZbrlmEiLRSjA8Ud/yWF1 LgUYVFZQt8emAHE+m/iZnoxBx+Z3i5a0WwkwGAugiiEZULmOrwbBnAiQdsdoO0JVNF/x AFrg== X-Forwarded-Encrypted: i=1; AFNElJ8o0FmLL6NmotyKh6/pKPxIY/sfkvG6hLaBy6pFMd7Pv/RkokL8lRSnJ6z5ox+nN3kbZAhMrlGRccDM6q8=@vger.kernel.org X-Gm-Message-State: AOJu0Ywty+6P+rqlNwHpyO8E45gfFH4WrMGx9pajsSLlkTfsfPFRxKKm kBgyJeODPtW5QcrorAsNMMLdzZShf62afk+qC2kw5cQ48UHeIaDPm0bX X-Gm-Gg: Acq92OEDpv0PmlImTfqFhw0sbUw2+UWaD3mu+JtttFsO035EY+5JCbwjLeRXpyNSdM5 w3jD1hifP04SMUJoNPA3QgLeEZyaFM6EGj1d8KsJMG2wJpiJiFixWyLEHhcG4ZoTg/VVZGtSV5y lQ45LW/mwm7BEpkloCkoyAdojSNYbZn+YNKVTct94g03wcnQN1nTk2/MQDx/GQSG6uoRZ2+7RzI KhQ94DtKDD/HPrjLX+kH9ugGrOjDYePZBGfR1QuOk4URBcfKDv1FITlgRtQPTYGpXARWTCbT6Fh 6pxi4F/L1zxQmMUQi8rgZ2lIydZuMvjW+f9UsZBrOFQ7TJFanOHJT9dn+1/yVg0PjStQ4yx2wZO nJ3VnTXQAOKh4lL7QBFb1VIdaXm2ij5rG1auZ5CbZtrMRbALEqZfWCO7kRWaF0m3Ob3Dvj0Qy9r LKg0ImGMcWw08u7wfdjuFBlpbX3dc= X-Received: by 2002:a05:620a:1d0b:b0:915:8f76:8001 with SMTP id af79cd13be357-9158f768409mr982190385a.48.1780559906917; Thu, 04 Jun 2026 00:58:26 -0700 (PDT) Received: from localhost ([149.40.50.195]) by smtp.gmail.com with ESMTPSA id af79cd13be357-9158a3d7280sm508837785a.41.2026.06.04.00.58.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jun 2026 00:58:26 -0700 (PDT) Date: Thu, 4 Jun 2026 10:58:20 +0300 From: Dan Carpenter To: William Elder Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8723bs: remove comparisons to boolean literals Message-ID: References: <20260603193753.195640-1-williamxelder@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260603193753.195640-1-williamxelder@gmail.com> On Wed, Jun 03, 2026 at 01:37:53PM -0600, William Elder wrote: > @@ -847,7 +846,7 @@ static void bwmode_update_check(struct adapter *padapter, struct ndis_80211_var_ > if (!pIE) > return; > > - if (phtpriv->ht_option == false) > + if (phtpriv->ht_option) This patch introduces multiple bugs where true/false are reversed. regards, dan carpenter